Skip to content

Commit d2355ea

Browse files
jaredgalanisjaredgalanis
committed
fix lint
1 parent 99a9c89 commit d2355ea

File tree

2 files changed

+89
-15
lines changed

2 files changed

+89
-15
lines changed

‎node-tests/replace-url-versions.js

Lines changed: 78 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,83 @@ const replaceURLVersions = require('../scripts/helpers/replace-url-versions');
33

44
describe('replace url versions', function () {
55
it('works', function () {
6-
expect(replaceURLVersions('https://api.emberjs.com/ember/release/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/');
7-
expect(replaceURLVersions('https://api.emberjs.com/ember/release', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15');
8-
expect(replaceURLVersions('https://api.emberjs.com/ember/3.20/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/');
9-
expect(replaceURLVersions('https://api.emberjs.com/ember/3.20', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15');
10-
expect(replaceURLVersions('https://api.emberjs.com/ember/release/classes/Application', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/classes/Application');
11-
expect(replaceURLVersions('https://api.emberjs.com/ember-data/release/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15/');
12-
expect(replaceURLVersions('https://api.emberjs.com/ember-data/release', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15');
13-
expect(replaceURLVersions('https://api.emberjs.com/ember-data/release/classes/Model/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
14-
expect(replaceURLVersions('https://api.emberjs.com/ember-data/3.20/classes/Model/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
15-
expect(replaceURLVersions('https://api.emberjs.com/ember/release/classes/@ember%2Fapplication/methods/getOwner', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/classes/@ember%2Fapplication/methods/getOwner');
16-
expect(replaceURLVersions('https://guides.emberjs.com/release/getting-started/', '3.15', '3.15')).to.equal('https://guides.emberjs.com/v3.15.0/getting-started/');
17-
expect(replaceURLVersions('https://guides.emberjs.com/release/getting-started/', '3.16.0', '3.16.0')).to.equal('https://guides.emberjs.com/v3.16.0/getting-started/');
6+
expect(
7+
replaceURLVersions(
8+
'https://api.emberjs.com/ember/release/',
9+
'3.15',
10+
'3.15'
11+
)
12+
).to.equal('https://api.emberjs.com/ember/3.15/');
13+
expect(
14+
replaceURLVersions(
15+
'https://api.emberjs.com/ember/release',
16+
'3.15',
17+
'3.15'
18+
)
19+
).to.equal('https://api.emberjs.com/ember/3.15');
20+
expect(
21+
replaceURLVersions('https://api.emberjs.com/ember/3.20/', '3.15', '3.15')
22+
).to.equal('https://api.emberjs.com/ember/3.15/');
23+
expect(
24+
replaceURLVersions('https://api.emberjs.com/ember/3.20', '3.15', '3.15')
25+
).to.equal('https://api.emberjs.com/ember/3.15');
26+
expect(
27+
replaceURLVersions(
28+
'https://api.emberjs.com/ember/release/classes/Application',
29+
'3.15',
30+
'3.15'
31+
)
32+
).to.equal('https://api.emberjs.com/ember/3.15/classes/Application');
33+
expect(
34+
replaceURLVersions(
35+
'https://api.emberjs.com/ember-data/release/',
36+
'3.15',
37+
'3.15'
38+
)
39+
).to.equal('https://api.emberjs.com/ember-data/3.15/');
40+
expect(
41+
replaceURLVersions(
42+
'https://api.emberjs.com/ember-data/release',
43+
'3.15',
44+
'3.15'
45+
)
46+
).to.equal('https://api.emberjs.com/ember-data/3.15');
47+
expect(
48+
replaceURLVersions(
49+
'https://api.emberjs.com/ember-data/release/classes/Model/',
50+
'3.15',
51+
'3.15'
52+
)
53+
).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
54+
expect(
55+
replaceURLVersions(
56+
'https://api.emberjs.com/ember-data/3.20/classes/Model/',
57+
'3.15',
58+
'3.15'
59+
)
60+
).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
61+
expect(
62+
replaceURLVersions(
63+
'https://api.emberjs.com/ember/release/classes/@ember%2Fapplication/methods/getOwner',
64+
'3.15',
65+
'3.15'
66+
)
67+
).to.equal(
68+
'https://api.emberjs.com/ember/3.15/classes/@ember%2Fapplication/methods/getOwner'
69+
);
70+
expect(
71+
replaceURLVersions(
72+
'https://guides.emberjs.com/release/getting-started/',
73+
'3.15',
74+
'3.15'
75+
)
76+
).to.equal('https://guides.emberjs.com/v3.15.0/getting-started/');
77+
expect(
78+
replaceURLVersions(
79+
'https://guides.emberjs.com/release/getting-started/',
80+
'3.16.0',
81+
'3.16.0'
82+
)
83+
).to.equal('https://guides.emberjs.com/v3.16.0/getting-started/');
1884
});
1985
});

‎scripts/helpers/replace-url-versions.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,22 @@
1-
module.exports = function replaceURLVersions(str, emberVersion, emberDataVersion) {
1+
module.exports = function replaceURLVersions(
2+
str,
3+
emberVersion,
4+
emberDataVersion
5+
) {
26
let output;
37

48
// guides use `v3.20.0` version format
5-
const emberPatchVersion = /\d+\.\d+.\d+/.test(emberVersion) ? emberVersion : emberVersion + '.0';
9+
const emberPatchVersion = /\d+\.\d+.\d+/.test(emberVersion)
10+
? emberVersion
11+
: emberVersion + '.0';
612
output = str.replace(
713
/https:\/\/guides.emberjs.com\/(release|v\d+\.\d+.\d+)(\/?)/g,
814
`https://guides.emberjs.com/v${emberPatchVersion}$2`
915
);
1016

11-
const emberDataPatchVersion = /\d+\.\d+.\d+/.test(emberDataVersion) ? emberDataVersion : emberDataVersion + '.0';
17+
const emberDataPatchVersion = /\d+\.\d+.\d+/.test(emberDataVersion)
18+
? emberDataVersion
19+
: emberDataVersion + '.0';
1220
output = str.replace(
1321
/https:\/\/guides.emberjs.com\/(release|v\d+\.\d+.\d+)(\/?)/g,
1422
`https://guides.emberjs.com/v${emberDataPatchVersion}$2`

0 commit comments

Comments
 (0)