Skip to content

Commit b9b1b63

Browse files
MinThaMieMinThaMie
committed
Fix linting
1 parent 08d6d0e commit b9b1b63

File tree

10 files changed

+78
-87
lines changed

10 files changed

+78
-87
lines changed

‎app/services/store.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export {default} from 'ember-data/store';
1+
export { default } from 'ember-data/store';

‎lib/content-generator/index.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
2-
2+
// eslint-disable-next-line n/no-unpublished-require
33
const StaticSiteJson = require('broccoli-static-site-json');
4+
// eslint-disable-next-line n/no-unpublished-require
45
const MergeTrees = require('broccoli-merge-trees');
56

67
const COMMON_CONFIGS = {

‎tests/acceptance/changes-test.js‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -11,68 +11,68 @@ module('Acceptance | changes', function (hooks) {
1111

1212
// Check new features in Ember.js
1313
const newFeaturesInEmberJS = findAll(
14-
'[data-test-package="Ember.js"] [data-test-feature]'
14+
'[data-test-package="Ember.js"] [data-test-feature]',
1515
);
1616

1717
assert.strictEqual(
1818
newFeaturesInEmberJS.length,
1919
43,
20-
'We see 43 new features that occurred in Ember.js since version 3.15'
20+
'We see 43 new features that occurred in Ember.js since version 3.15',
2121
);
2222

2323
// Check deprecations in Ember.js
2424
const deprecationsInEmberJS = findAll(
25-
'[data-test-package="Ember.js"] [data-test-deprecation]'
25+
'[data-test-package="Ember.js"] [data-test-deprecation]',
2626
);
2727

2828
assert.strictEqual(
2929
deprecationsInEmberJS.length,
3030
33,
31-
'We see 33 deprecations that occurred in Ember.js since version 3.15'
31+
'We see 33 deprecations that occurred in Ember.js since version 3.15',
3232
);
3333

3434
// Check new features in Ember Data
3535
const newFeaturesInEmberData = findAll(
36-
'[data-test-package="Ember Data"] [data-test-feature]'
36+
'[data-test-package="Ember Data"] [data-test-feature]',
3737
);
3838

3939
assert.strictEqual(
4040
newFeaturesInEmberData.length,
4141
21,
42-
'We see 21 new feature that occurred in Ember Data since version 3.15'
42+
'We see 21 new feature that occurred in Ember Data since version 3.15',
4343
);
4444

4545
// Check deprecations in Ember Data
4646
const deprecationsInEmberData = findAll(
47-
'[data-test-package="Ember Data"] [data-test-deprecation]'
47+
'[data-test-package="Ember Data"] [data-test-deprecation]',
4848
);
4949

5050
assert.strictEqual(
5151
deprecationsInEmberData.length,
5252
18,
53-
'We see 18 deprecations that occurred in Ember Data since version 3.15'
53+
'We see 18 deprecations that occurred in Ember Data since version 3.15',
5454
);
5555

5656
// Check new features in Ember CLI
5757
const newFeaturesInEmberCLI = findAll(
58-
'[data-test-package="Ember CLI"] [data-test-feature]'
58+
'[data-test-package="Ember CLI"] [data-test-feature]',
5959
);
6060

6161
assert.strictEqual(
6262
newFeaturesInEmberCLI.length,
6363
74,
64-
'We see 74 new features that occurred in Ember CLI since version 3.15'
64+
'We see 74 new features that occurred in Ember CLI since version 3.15',
6565
);
6666

6767
// Check deprecations in Ember CLI
6868
const deprecationsInEmberCLI = findAll(
69-
'[data-test-package="Ember CLI"] [data-test-deprecation]'
69+
'[data-test-package="Ember CLI"] [data-test-deprecation]',
7070
);
7171

7272
assert.strictEqual(
7373
deprecationsInEmberCLI.length,
7474
10,
75-
'We see 10 deprecations that occurred in Ember CLI since version 3.15'
75+
'We see 10 deprecations that occurred in Ember CLI since version 3.15',
7676
);
7777
});
7878

@@ -81,68 +81,68 @@ module('Acceptance | changes', function (hooks) {
8181

8282
// Check new features in Ember.js
8383
const newFeaturesInEmberJS = findAll(
84-
'[data-test-package="Ember.js"] [data-test-feature]'
84+
'[data-test-package="Ember.js"] [data-test-feature]',
8585
);
8686

8787
assert.strictEqual(
8888
newFeaturesInEmberJS.length,
8989
8,
90-
'We see 8 new features that occurred in Ember.js between 2.17 and 3.3'
90+
'We see 8 new features that occurred in Ember.js between 2.17 and 3.3',
9191
);
9292

9393
// Check deprecations in Ember.js
9494
const deprecationsInEmberJS = findAll(
95-
'[data-test-package="Ember.js"] [data-test-deprecation]'
95+
'[data-test-package="Ember.js"] [data-test-deprecation]',
9696
);
9797

9898
assert.strictEqual(
9999
deprecationsInEmberJS.length,
100100
9,
101-
'We see 9 deprecations that occurred in Ember.js between 2.17 and 3.3'
101+
'We see 9 deprecations that occurred in Ember.js between 2.17 and 3.3',
102102
);
103103

104104
// Check new features in Ember Data
105105
const newFeaturesInEmberData = findAll(
106-
'[data-test-package="Ember Data"] [data-test-feature]'
106+
'[data-test-package="Ember Data"] [data-test-feature]',
107107
);
108108

109109
assert.strictEqual(
110110
newFeaturesInEmberData.length,
111111
5,
112-
'We see 5 new features that occurred in Ember Data between 2.17 and 3.3'
112+
'We see 5 new features that occurred in Ember Data between 2.17 and 3.3',
113113
);
114114

115115
// Check deprecations in Ember Data
116116
const deprecationsInEmberData = findAll(
117-
'[data-test-package="Ember Data"] [data-test-deprecation]'
117+
'[data-test-package="Ember Data"] [data-test-deprecation]',
118118
);
119119

120120
assert.strictEqual(
121121
deprecationsInEmberData.length,
122122
1,
123-
'We see 1 deprecation that occurred in Ember Data between 2.17 and 3.3'
123+
'We see 1 deprecation that occurred in Ember Data between 2.17 and 3.3',
124124
);
125125

126126
// Check new features in Ember CLI
127127
const newFeaturesInEmberCLI = findAll(
128-
'[data-test-package="Ember CLI"] [data-test-feature]'
128+
'[data-test-package="Ember CLI"] [data-test-feature]',
129129
);
130130

131131
assert.strictEqual(
132132
newFeaturesInEmberCLI.length,
133133
2,
134-
'We see 2 new features that occurred in Ember CLI between 2.17 and 3.3'
134+
'We see 2 new features that occurred in Ember CLI between 2.17 and 3.3',
135135
);
136136

137137
// Check deprecations in Ember CLI
138138
const deprecationsInEmberCLI = findAll(
139-
'[data-test-package="Ember CLI"] [data-test-deprecation]'
139+
'[data-test-package="Ember CLI"] [data-test-deprecation]',
140140
);
141141

142142
assert.strictEqual(
143143
deprecationsInEmberCLI.length,
144144
1,
145-
'We see 1 deprecation that occurred in Ember CLI between 2.17 and 3.3'
145+
'We see 1 deprecation that occurred in Ember CLI between 2.17 and 3.3',
146146
);
147147
});
148148

‎tests/acceptance/index-test.js‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module('Acceptance | index', function (hooks) {
3535
assert.strictEqual(
3636
currentURL(),
3737
'/changes?fromVersion=2.17&toVersion=3.3',
38-
'We see the correct URL.'
38+
'We see the correct URL.',
3939
);
4040
});
4141

@@ -48,16 +48,16 @@ module('Acceptance | index', function (hooks) {
4848

4949
// Check Ember.js
5050
let features = findAll(
51-
'[data-test-package="Ember.js"] [data-test-feature]'
51+
'[data-test-package="Ember.js"] [data-test-feature]',
5252
);
5353
let deprecations = findAll(
54-
'[data-test-package="Ember.js"] [data-test-deprecation]'
54+
'[data-test-package="Ember.js"] [data-test-deprecation]',
5555
);
5656

5757
assert.strictEqual(
5858
features.length,
5959
8,
60-
'We see that 8 features were added to Ember.js between 2.17 and 3.3.'
60+
'We see that 8 features were added to Ember.js between 2.17 and 3.3.',
6161
);
6262

6363
assert.isFeatureCorrect(features[0], {
@@ -75,7 +75,7 @@ module('Acceptance | index', function (hooks) {
7575
assert.strictEqual(
7676
deprecations.length,
7777
9,
78-
'We see that 9 deprecations were added to Ember.js between 2.17 and 3.3.'
78+
'We see that 9 deprecations were added to Ember.js between 2.17 and 3.3.',
7979
);
8080

8181
assert.isDeprecationCorrect(deprecations[0], {
@@ -93,13 +93,13 @@ module('Acceptance | index', function (hooks) {
9393
// Check Ember Data
9494
features = findAll('[data-test-package="Ember Data"] [data-test-feature]');
9595
deprecations = findAll(
96-
'[data-test-package="Ember Data"] [data-test-deprecation]'
96+
'[data-test-package="Ember Data"] [data-test-deprecation]',
9797
);
9898

9999
assert.strictEqual(
100100
features.length,
101101
5,
102-
'We see that 5 features were added to Ember Data between 2.17 and 3.3.'
102+
'We see that 5 features were added to Ember Data between 2.17 and 3.3.',
103103
);
104104

105105
assert.isFeatureCorrect(features[0], {
@@ -117,7 +117,7 @@ module('Acceptance | index', function (hooks) {
117117
assert.strictEqual(
118118
deprecations.length,
119119
1,
120-
'We see that 1 deprecation was added to Ember Data between 2.17 and 3.3.'
120+
'We see that 1 deprecation was added to Ember Data between 2.17 and 3.3.',
121121
);
122122

123123
assert.isDeprecationCorrect(deprecations[0], {
@@ -135,13 +135,13 @@ module('Acceptance | index', function (hooks) {
135135
// Check Ember CLI
136136
features = findAll('[data-test-package="Ember CLI"] [data-test-feature]');
137137
deprecations = findAll(
138-
'[data-test-package="Ember CLI"] [data-test-deprecation]'
138+
'[data-test-package="Ember CLI"] [data-test-deprecation]',
139139
);
140140

141141
assert.strictEqual(
142142
features.length,
143143
2,
144-
'We see that 2 features were added to Ember CLI between 2.17 and 3.3.'
144+
'We see that 2 features were added to Ember CLI between 2.17 and 3.3.',
145145
);
146146

147147
assert.isFeatureCorrect(features[0], {
@@ -159,7 +159,7 @@ module('Acceptance | index', function (hooks) {
159159
assert.strictEqual(
160160
deprecations.length,
161161
1,
162-
'We see that 1 deprecation was added to Ember CLI between 2.17 and 3.3.'
162+
'We see that 1 deprecation was added to Ember CLI between 2.17 and 3.3.',
163163
);
164164

165165
assert.isDeprecationCorrect(deprecations[0], {
@@ -184,22 +184,22 @@ module('Acceptance | index', function (hooks) {
184184

185185
// Check Ember.js
186186
let features = findAll(
187-
'[data-test-package="Ember.js"] [data-test-feature]'
187+
'[data-test-package="Ember.js"] [data-test-feature]',
188188
);
189189
let deprecations = findAll(
190-
'[data-test-package="Ember.js"] [data-test-deprecation]'
190+
'[data-test-package="Ember.js"] [data-test-deprecation]',
191191
);
192192

193193
assert.strictEqual(
194194
features.length,
195195
0,
196-
'We see that 0 features were added to Ember.js between 3.3 and 2.17.'
196+
'We see that 0 features were added to Ember.js between 3.3 and 2.17.',
197197
);
198198

199199
assert.strictEqual(
200200
deprecations.length,
201201
0,
202-
'We see that 0 deprecations were added to Ember.js between 3.3 and 2.17.'
202+
'We see that 0 deprecations were added to Ember.js between 3.3 and 2.17.',
203203
);
204204
});
205205

‎tests/helpers/features-deprecations.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ function setupCustomAssertions(assert) {
1616
.hasAttribute(
1717
'href',
1818
link,
19-
'We see the correct URL for the feature version.'
19+
'We see the correct URL for the feature version.',
2020
)
2121
.hasText(
2222
`(${version})`,
23-
'We see the correct text for the feature version.'
23+
'We see the correct text for the feature version.',
2424
);
2525
};
2626

@@ -36,11 +36,11 @@ function setupCustomAssertions(assert) {
3636
.hasAttribute(
3737
'href',
3838
link,
39-
'We see the correct URL for the deprecation version.'
39+
'We see the correct URL for the deprecation version.',
4040
)
4141
.hasText(
4242
`(${version})`,
43-
'We see the correct text for the deprecation version.'
43+
'We see the correct text for the deprecation version.',
4444
);
4545
};
4646
}

‎tests/integration/components/cli-update-commands-test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ module('Integration | Component | cli-update-commands', function (hooks) {
1919
.dom('[data-test-command="Ember CLI Update"]')
2020
.hasText(
2121
'ember-cli-update --to 3.14',
22-
'We see the correct command for running ember-cli-update.'
22+
'We see the correct command for running ember-cli-update.',
2323
);
2424

2525
assert
2626
.dom('[data-test-command="Run Codemods"]')
2727
.hasText(
2828
'ember-cli-update --run-codemods',
29-
'We see the correct command for running codemods.'
29+
'We see the correct command for running codemods.',
3030
);
3131
});
3232
});

‎tests/integration/components/ember-versions-form-test.js‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,17 @@ module('Integration | Component | ember-versions-form', function (hooks) {
2323
});
2424

2525
test('selecting and changing fromVersion and toVersion', async function (assert) {
26-
assert.expect(2);
27-
2826
this.onSubmit = ({ fromVersion, toVersion }) => {
2927
assert.strictEqual(
3028
fromVersion,
3129
'3.15',
32-
'We get the correct value for fromVersion.'
30+
'We get the correct value for fromVersion.',
3331
);
3432

3533
assert.strictEqual(
3634
toVersion,
3735
'3.18',
38-
'We get the correct value for toVersion.'
36+
'We get the correct value for toVersion.',
3937
);
4038
};
4139

@@ -59,8 +57,6 @@ module('Integration | Component | ember-versions-form', function (hooks) {
5957
});
6058

6159
test('Submit button should be enabled initially', async function (assert) {
62-
assert.expect(1);
63-
6460
await render(hbs`
6561
<EmberVersionsForm
6662
@onSubmit={{this.onSubmit}}
@@ -71,8 +67,6 @@ module('Integration | Component | ember-versions-form', function (hooks) {
7167
});
7268

7369
test('Submit button should be enabled when selected fromVersion is less than toVersion', async function (assert) {
74-
assert.expect(1);
75-
7670
await render(hbs`
7771
<EmberVersionsForm
7872
@onSubmit={{this.onSubmit}}
@@ -85,8 +79,6 @@ module('Integration | Component | ember-versions-form', function (hooks) {
8579
});
8680

8781
test('Submit button should be disabled when selected fromVersion is greater than toVersion', async function (assert) {
88-
assert.expect(1);
89-
9082
await render(hbs`
9183
<EmberVersionsForm
9284
@onSubmit={{this.onSubmit}}
@@ -99,8 +91,6 @@ module('Integration | Component | ember-versions-form', function (hooks) {
9991
});
10092

10193
test('Submit button should be disabled when selected fromVersion is equal to toVersion', async function (assert) {
102-
assert.expect(1);
103-
10494
await render(hbs`
10595
<EmberVersionsForm
10696
@onSubmit={{this.onSubmit}}

0 commit comments

Comments
 (0)