Skip to content

Commit d1737ae

Browse files
Merge pull request #9 from ember-tooling/ember-canary-renderComponent
Move to `renderComponent`
2 parents e20544b + 0a4c352 commit d1737ae

5 files changed

Lines changed: 63 additions & 104 deletions

File tree

docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"dependencies": {
1818
"astro": "^5.6.1",
1919
"ember-astro": "workspace:*",
20-
"ember-source": "6.7.0-beta.1",
20+
"ember-source": "~6.8.2",
2121
"sharp": "^0.34.2",
2222
"vite": "^7.1.3"
2323
}

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,20 @@
3838
"@rollup/plugin-babel": "^6.0.4",
3939
"babel-plugin-ember-template-compilation": "^2.4.1",
4040
"decorator-transforms": "^2.3.0",
41-
"ember-source": ">= 6.7.0-alpha.1",
4241
"ember-strict-application-resolver": "^0.1.0"
4342
},
4443
"devDependencies": {
4544
"@ember/library-tsconfig": "^1.1.3",
4645
"concurrently": "^9.2.1",
4746
"prettier": "^3.6.2",
4847
"prettier-plugin-ember-template-tag": "^2.1.0",
48+
"ember-source": "~6.8.0",
4949
"release-plan": "^0.16.0",
5050
"typescript": "^5.9.2"
5151
},
5252
"peerDependencies": {
53-
"astro": "^5.0.0"
53+
"astro": "^5.0.0",
54+
"ember-source": ">= 6.8.2"
5455
},
5556
"packageManager": "pnpm@10.15.0",
5657
"ember-addon": {

pnpm-lock.yaml

Lines changed: 57 additions & 73 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/client.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// waiting on renderComponent
22
// https://github.com/emberjs/ember.js/pull/20962
3-
import { renderApp } from "./render-app-island.js";
43
import { template } from "@ember/template-compiler";
4+
import { renderComponent } from "@ember/renderer";
55

66
function withProps(props, slots, component) {
77
return template(`<EmberAstro_client_component__ @props={{props}} @slots={{slots}} />`, {
@@ -28,7 +28,7 @@ export default function emberAstroClientRenderer(element) {
2828
return;
2929
}
3030

31-
let result = await renderApp({ element, component: withProps(props, slots, component) });
31+
let result = await renderComponent(withProps(props, slots, component), { into: element });
3232

3333
existingApplications.set(element, result);
3434
element.addEventListener("astro:unmount", () => result.destroy(), { once: true });

src/render-app-island.js

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)