Unable to detect V2 Addons

[wagenet]

This is because it looks for the presence of ember-cli-build.js, which is not present in V2 Addons. I'd like ELS so I at least get template linting support in VSCode.

[lifeart]

Hey @wagenet! Thank you for issue, sorry for delayed response.
In theory, we could rely on ember-template-lint dependency to detect 'ember-like' project.
But I'm open for any suggestions (https://github.com/lifeart/ember-language-server)

[simonihmig]

I think this issue was accidentally closed, by some commit that referenced it wrongly. Seems the repo migration messed up some things here, see home the commit
feat: named slots context autocomplete (#381) seems to refer to this issue, but was probably meant to refer to lifeart#381

@lifeart can we re-open this please? Could you also shed some light into the current status. Like this test seems to suggest v2 addons are supported, but I am still seeing expected ELS features to not work inside a v2 addon (template-lint integration for example).

[simonihmig]

Is it this line that ties it into ember-cli-build.js?

If this is about identifying which packages are Ember apps or addons (v1 or v2), I think the detection would need to be like this:

const isEmberAddon = packageJson.keywords?.includes('ember-addon');
const isEmberApp = 'ember' in packageJson && !isEmberAddon;
const addonVersion = Number(packageJson['ember-addon']?.version ?? 1);
const isEmberV1Addon = isEmberAddon && addonVersion === 1;
const isEmberV2Addon = isEmberAddon && addonVersion === 2;

[lifeart]

Hi @simonihmig! Thank you for re-visiting it!
V2 addons has basic support, it means we support v2 addons, if layout is same as in v1.
At the moment we ignore embroider transformed addons - #413

Is it this line that ties it into ember-cli-build.js?

• not really, it should act like 'or' means, we looking for ember-cli-build.js or package.json.

To detect addon version we use this code:

ember-language-server/src/utils/layout-helpers.ts

Line 432 in 966b1bd

export function addonVersion(info: PackageInfo) {

I am still seeing expected ELS features to not work inside a v2 addon (template-lint integration for example).

• I think we could solve it, if you have any sample reference.

[simonihmig]

not really, it should act like 'or' means, we looking for ember-cli-build.js or package.json.

I don't really have any understanding of the codebase tbh, but isn't this part basically saying that we add a package if it has a package.json and is a GlimmerX project, or if it has ember-cli-build.js? If that's the case, v2 addons don't fit in there.

I have just tried ELS with https://github.com/CrowdStrike/ember-headless-form, but I think any other v2 addon codbease would work as well. I am adding a dummy.hbs with contents of <div {{on 'click' @onSubmit}}></div> (which should trigger no-invalid-interactive template lint rule):

• when I do that inside the v2 addon (packages/ember-headless-form/components) I don't see linting errors in VS Code (ignoring Glint error)
• when I do that inside the test-app (test-app/app/components), I get to see the no-invalid-interactive red squiggles