move build of ember-debug to rollup (#2645)

Author: mansona

.prettierignore

@@ -3,6 +3,7 @@
 
 # compiled output
 /dist/
+/ember_debug/dist/
 
 # misc
 /coverage/

ember-cli-build.js

@@ -7,13 +7,7 @@ const concatFiles = require('broccoli-concat');
 const stew = require('broccoli-stew');
 const writeFile = require('broccoli-file-creator');
 const replace = require('broccoli-string-replace');
-const Babel = require('broccoli-babel-transpiler');
-const moduleResolver = require('amd-name-resolver').resolveModules({
-  throwOnRootAccess: false,
-});
 const Funnel = require('broccoli-funnel');
-const ensurePosix = require('ensure-posix-path');
-const path = require('path');
 const packageJson = require('./package.json');
 const { map, mv } = stew;
 
@@ -33,16 +27,6 @@ const options = {
 options.minifyJS = { enabled: false };
 options.minifyCSS = { enabled: false };
 
-// Stolen from relative-module-paths.js in ember-cli-babel
-function getRelativeModulePath(modulePath) {
-  return ensurePosix(path.relative(process.cwd(), modulePath));
-}
-
-// Stolen from relative-module-paths.js in ember-cli-babel
-function resolveRelativeModulePath(name, child) {
-  return moduleResolver(name, getRelativeModulePath(child));
-}
-
 module.exports = function (defaults) {
   let checker = new VersionChecker(defaults);
   let emberChecker = checker.for('ember-source');
@@ -100,41 +84,11 @@ module.exports = function (defaults) {
   app.import('node_modules/compare-versions/index.js');
   app.import('node_modules/normalize.css/normalize.css');
 
-  // Ember Debug
-
-  let emberDebug = 'ember_debug';
-
-  let sourceMap = new Funnel('node_modules/source-map-js', {
-    files: ['**/*.js'],
-    destDir: 'ember-debug/deps',
-  });
-
-  sourceMap = new Babel(sourceMap, {
-    plugins: ['transform-commonjs'],
-  });
-
-  const backburner = new Funnel('node_modules/backburner.js/dist/es6', {
-    files: ['backburner.js'],
-    destDir: 'ember-debug/deps',
-  });
+  let emberDebug = 'ember_debug/dist';
 
   emberDebug = new Funnel(emberDebug, {
     destDir: 'ember-debug',
     include: ['**/*.js'],
-    exclude: ['vendor/startup-wrapper.js', 'vendor/loader.js'],
-  });
-
-  emberDebug = mergeTrees([sourceMap, backburner, emberDebug]);
-
-  emberDebug = new Babel(emberDebug, {
-    moduleIds: true,
-    getModuleId: getRelativeModulePath,
-    plugins: [
-      ['@babel/plugin-transform-class-properties'],
-      ['@babel/plugin-transform-class-static-block'],
-      ['module-resolver', { resolvePath: resolveRelativeModulePath }],
-      ['@babel/plugin-transform-modules-amd', { noInterop: true }],
-    ],
   });
 
   const previousEmberVersionsSupportedString = `[${packageJson.previousEmberVersionsSupported

ember_debug/.gitignore

@@ -0,0 +1,2 @@
+node_modules/
+dist/

ember_debug/babel.config.cjs

@@ -0,0 +1,11 @@
+module.exports = {
+  plugins: [
+    ['@babel/plugin-proposal-decorators', { version: 'legacy' }],
+    ['@babel/plugin-transform-class-properties'],
+    ['@babel/plugin-transform-class-static-block'],
+  ],
+
+  generatorOpts: {
+    compact: false,
+  },
+};

ember_debug/libs/source-map.js

@@ -1,5 +1,5 @@
 import BaseObject from 'ember-debug/utils/base-object';
-import * as SourceMap from 'ember-debug/deps/source-map';
+import * as SourceMap from 'source-map-js';
 const notFoundError = new Error('Source map url not found');
 
 export default class extends BaseObject {

ember_debug/package.json

@@ -0,0 +1,25 @@
+{
+  "name": "ember-debug",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "watch": "pnpm build --watch",
+    "build": "rollup --config",
+    "prepare": "pnpm build"
+  },
+  "devDependencies": {
+    "@babel/plugin-proposal-decorators": "^7.25.9",
+    "@babel/plugin-transform-class-properties": "^7.25.9",
+    "@babel/plugin-transform-class-static-block": "^7.26.0",
+    "@rollup/plugin-babel": "^6.0.4",
+    "@rollup/plugin-commonjs": "^28.0.3",
+    "@rollup/plugin-node-resolve": "^16.0.1",
+    "backburner.js": "^2.8.0",
+    "glob": "^11.0.2",
+    "rollup": "^4.39.0",
+    "source-map-js": "^1.2.1"
+  },
+  "exports": {
+    "./*": "./*.js"
+  }
+}

ember_debug/rollup.config.js

@@ -0,0 +1,48 @@
+import { nodeResolve } from '@rollup/plugin-node-resolve';
+import commonjs from '@rollup/plugin-commonjs';
+import { babel } from '@rollup/plugin-babel';
+import { globSync } from 'glob';
+
+export default {
+  input: [
+    'main.js',
+    ...globSync('adapters/**/*.js'),
+    'utils/version.js',
+    'port.js',
+    'utils/ember.js',
+    'models/profile-node.js',
+    'libs/promise-assembler.js',
+  ],
+  output: {
+    format: 'amd',
+    amd: {
+      autoId: true,
+      // id: 'ember-debug/[name]',
+      basePath: 'ember-debug',
+    },
+    chunkFileNames: '[name].js',
+    dir: 'dist',
+  },
+
+  plugins: [
+    babel(),
+    nodeResolve(),
+    commonjs(),
+    /**
+     * this plugin forces each of the intenral dependencies for each of the chunks to be prefixed with ember-debug
+     */
+    {
+      name: 'rollup-plugin-name-amd-modules',
+      renderChunk(code) {
+        let splitCode = code.split('\n');
+
+        splitCode[0] = splitCode[0].replaceAll(
+          /'\.\/([^']*)'/g,
+          `'ember-debug/$1'`,
+        );
+
+        return splitCode.join('\n');
+      },
+    },
+  ],
+};

ember_debug/utils/ember.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports */
 import { emberSafeRequire } from 'ember-debug/utils/ember/loader';
 
 let Ember;
@@ -14,31 +15,29 @@ try {
   Ember = window.Ember;
 }
 
-let {
-  ArrayProxy,
-  Namespace,
-  ActionHandler,
-  ControllerMixin,
-  CoreObject,
-  Application,
-  MutableArray,
-  MutableEnumerable,
-  NativeArray,
-  Component,
-  Observable,
-  Evented,
-  PromiseProxyMixin,
-  Service,
-  Object: EmberObject,
-  ObjectProxy,
-  VERSION,
-  ComputedProperty,
-  meta,
-  get,
-  set,
-  computed,
-  _captureRenderTree: captureRenderTree,
-} = Ember || {};
+let ArrayProxy = Ember.ArrayProxy;
+let Namespace = Ember.Namespace;
+let ActionHandler = Ember.ActionHandler;
+let ControllerMixin = Ember.ControllerMixin;
+let CoreObject = Ember.CoreObject;
+let Application = Ember.Application;
+let MutableArray = Ember.MutableArray;
+let MutableEnumerable = Ember.MutableEnumerable;
+let NativeArray = Ember.NativeArray;
+let Component = Ember.Component;
+let Observable = Ember.Observable;
+let Evented = Ember.Evented;
+let PromiseProxyMixin = Ember.PromiseProxyMixin;
+let Service = Ember.Service;
+let ObjectProxy = Ember.ObjectProxy;
+let VERSION = Ember.VERSION;
+let ComputedProperty = Ember.ComputedProperty;
+let meta = Ember.meta;
+let get = Ember.get;
+let set = Ember.set;
+let computed = Ember.computed;
+let EmberObject = Ember.Object;
+let captureRenderTree = Ember._captureRenderTree;
 
 let getEnv = () => Ember.ENV;
 

ember_debug/utils/ember/own-runloop.js

@@ -1,4 +1,4 @@
-import Backburner from 'ember-debug/deps/backburner';
+import Backburner from 'backburner.js';
 
 let currentRunLoop = null;
 export function _getCurrentRunLoop() {

ember_debug/vendor/startup-wrapper.js

@@ -55,11 +55,11 @@ var EMBER_VERSIONS_SUPPORTED = {{EMBER_VERSIONS_SUPPORTED}};
       });
 
       let emberDebugMainModule = requireModule('ember-debug/main');
-      if (!emberDebugMainModule['default']) {
+      if (!emberDebugMainModule) {
         return;
       }
-      window.EmberInspector = emberDebugMainModule['default'];
-      window.EmberInspector.Adapter = requireModule('ember-debug/adapters/' + adapter)['default'];
+      window.EmberInspector = emberDebugMainModule;
+      window.EmberInspector.Adapter = requireModule('ember-debug/' + adapter);
 
       onApplicationStart(function appStarted(instance) {
         let app = instance.application;
@@ -149,7 +149,7 @@ var EMBER_VERSIONS_SUPPORTED = {{EMBER_VERSIONS_SUPPORTED}};
       return;
     }
 
-    const adapterInstance = new (requireModule('ember-debug/adapters/' + currentAdapter)['default']);
+    const adapterInstance = new (requireModule('ember-debug/' + currentAdapter));
 
     adapterInstance.onMessageReceived(function(message) {
       if (message.type === 'app-picker-loaded') {