Remove mapBy and filterBy (#2600)

Author: RobbieTheWagner

app/components/object-inspector.js

@@ -26,7 +26,7 @@ export default class ObjectInspector extends Component {
     if (nested.length === 0) {
       return '';
     }
-    return `.${nested.mapBy('property').join('.')}`;
+    return `.${nested.map((item) => item.property).join('.')}`;
   }
 
   get isNested() {

app/libs/resizable-columns.js

@@ -81,7 +81,7 @@ export default class {
     let saved = this.storage.getItem(this.getStorageKey());
     if (saved && saved.columnVisibility) {
       let savedIds = keys(saved.columnVisibility).sort();
-      let schemaIds = this.columnSchema.mapBy('id').sort();
+      let schemaIds = this.columnSchema.map((col) => col.id).sort();
       if (!compareArrays(savedIds, schemaIds)) {
         // Clear saved items
         this.storage.removeItem(this.getStorageKey());
@@ -221,7 +221,7 @@ export default class {
       let diff = this.tableWidth - totalWidth;
       while (diff > 0) {
         columns
-          .filterBy('visible')
+          .filter((col) => col.visible)
           .sortBy('width')
           .forEach((column) => {
             if (diff > 0) {

tests/unit/resizable-columns-test.js

@@ -188,53 +188,57 @@ module('Unit | Lib | ResizableColumns', function (hooks) {
     resizableColumns.build();
 
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['1', '2'],
       'shows/hides according to schema',
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      true,
-      true,
-      false,
-    ]);
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [true, true, false],
+    );
 
     resizableColumns.toggleVisibility('3');
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['1', '2', '3'],
       'toggles the third column correctly',
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      true,
-      true,
-      true,
-    ]);
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [true, true, true],
+    );
 
     resizableColumns.toggleVisibility('1');
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['2', '3'],
       'toggles the first column correctly',
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      false,
-      true,
-      true,
-    ]);
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [false, true, true],
+    );
 
     // Confirm correct caching
     resizableColumns = new ResizableColumns(this.options);
     resizableColumns.build();
     assert.deepEqual(
-      resizableColumns.columns.filterBy('visible').mapBy('id'),
+      resizableColumns.columns
+        .filter((col) => col.visible)
+        .map((col) => col.id),
       ['2', '3'],
       'caching overrides schema visibility settings',
     );
-    assert.deepEqual(resizableColumns.getColumnVisibility().mapBy('visible'), [
-      false,
-      true,
-      true,
-    ]);
+    assert.deepEqual(
+      resizableColumns.getColumnVisibility().map((col) => col.visible),
+      [false, true, true],
+    );
   });
 
   test("resets cache correctly if schema doesn't match cache", function (assert) {