Remove remaining property methods from EmberObject

Author: wagenet

packages/@ember/-internals/glimmer/lib/helpers/mut.ts

@@ -29,7 +29,7 @@ import { internalHelper } from './internal-helper';
   // my-child.js
   export default class MyChild extends Component {
     click() {
-      this.incrementProperty('childClickCount');
+      set(this, 'childClickCount', this.childClickCount + 1);
     }
   }
   ```

packages/@ember/-internals/glimmer/lib/helpers/readonly.ts

@@ -34,7 +34,7 @@ import { internalHelper } from './internal-helper';
   ```app/components/my-child.js
   export default class MyChild extends Component {
     click() {
-      this.incrementProperty('childClickCount');
+      set(this, 'childClickCount', this.childClickCount + 1);
     }
   }
   ```
@@ -95,7 +95,7 @@ import { internalHelper } from './internal-helper';
 
   export default class MyChild extends Component {
     click() {
-      this.get('clicks').incrementProperty('total');
+      set(this.clicks, 'total', this.clicks.total + 1);
     }
   }
   ```

packages/@ember/-internals/glimmer/tests/integration/components/contextual-components-test.js

@@ -779,7 +779,7 @@ moduleFor(
         ComponentClass: class extends Component {
           @action
           changeValue() {
-            this.incrementProperty('myProp');
+            set(this, 'myProp', this.myProp + 1);
           }
         },
         template: strip`

packages/@ember/-internals/glimmer/tests/integration/components/utils-test.js

@@ -2,6 +2,7 @@ import { moduleFor, ApplicationTestCase, RenderingTestCase, runTask } from 'inte
 
 import { tracked } from '@glimmer/tracking';
 import Controller from '@ember/controller';
+import { set } from '@ember/object';
 import {
   getRootViews,
   getChildViews,
@@ -32,7 +33,7 @@ moduleFor(
           isExpanded = true;
 
           click() {
-            this.toggleProperty('isExpanded');
+            set(this, 'isExpanded', !this.isExpanded);
             return false;
           }
         },
@@ -44,7 +45,7 @@ moduleFor(
         @tracked isExpanded = true;
 
         toggle = () => {
-          this.toggleProperty('isExpanded');
+          set(this, 'isExpanded', !this.isExpanded);
         };
       }
 

packages/@ember/-internals/runtime/tests/mixins/observable_test.js

@@ -1,4 +1,5 @@
 import type { Renderer, View } from '@ember/-internals/glimmer/lib/renderer';
+import { getFactoryFor } from '@ember/-internals/container';
 import { inject } from '@ember/-internals/metal';
 import { FrameworkObject } from '@ember/object/-internals';
 import type { ViewState } from './states';
@@ -49,6 +50,11 @@ class CoreView extends FrameworkObject {
     this._currentState = this._states.preRender;
   }
 
+  get _debugContainerKey() {
+    let factory = getFactoryFor(this);
+    return factory !== undefined && factory.fullName;
+  }
+
   @inject('renderer', '-dom')
   declare renderer: Renderer;
 

packages/@ember/-internals/views/lib/views/core_view.ts

@@ -7,7 +7,7 @@ import {
 } from 'internal-test-helpers';
 import { service } from '@ember/service';
 import EmberObject from '@ember/object';
-import { get } from '@ember/object';
+import { get, set } from '@ember/object';
 import { RSVP, onerrorDefault } from '@ember/-internals/runtime';
 import { later } from '@ember/runloop';
 import { action } from '@ember/object';
@@ -651,7 +651,7 @@ moduleFor(
         value = 0;
 
         increment() {
-          this.incrementProperty('value');
+          set(this, 'value', this.value + 1);
         }
       };
 

packages/@ember/application/tests/visit_test.js

@@ -1,9 +1,7 @@
 import { assert } from '@ember/debug';
 import type { ElementDescriptor, ExtendedMethodDecorator } from '@ember/-internals/metal';
-import { isElementDescriptor, setClassicDecorator, get, set } from '@ember/-internals/metal';
-import { getFactoryFor } from '@ember/-internals/container';
+import { isElementDescriptor, setClassicDecorator } from '@ember/-internals/metal';
 import CoreObject from '@ember/object/core';
-import { peekMeta } from '@ember/-internals/meta';
 
 export {
   notifyPropertyChange,
@@ -27,89 +25,7 @@ export {
   @extends CoreObject
   @public
 */
-class EmberObject extends CoreObject {
-  // NOT TYPE SAFE!
-  /**
-    Set the value of a property to the current value plus some amount.
-
-    ```javascript
-    person.incrementProperty('age');
-    team.incrementProperty('score', 2);
-    ```
-
-    @method incrementProperty
-    @param {String} keyName The name of the property to increment
-    @param {Number} increment The amount to increment by. Defaults to 1
-    @return {Number} The new property value
-    @public
-  */
-  incrementProperty(keyName: keyof this & string, increment = 1): number {
-    assert(
-      'Must pass a numeric value to incrementProperty',
-      !isNaN(parseFloat(String(increment))) && isFinite(increment)
-    );
-    return set(this, keyName, (parseFloat(get(this, keyName) as string) || 0) + increment);
-  }
-  // NOT TYPE SAFE!
-  /**
-    Set the value of a property to the current value minus some amount.
-
-    ```javascript
-    player.decrementProperty('lives');
-    orc.decrementProperty('health', 5);
-    ```
-
-    @method decrementProperty
-    @param {String} keyName The name of the property to decrement
-    @param {Number} decrement The amount to decrement by. Defaults to 1
-    @return {Number} The new property value
-    @public
-  */
-  decrementProperty(keyName: keyof this & string, decrement = 1): number {
-    assert(
-      'Must pass a numeric value to decrementProperty',
-      (typeof decrement === 'number' || !isNaN(parseFloat(decrement))) && isFinite(decrement)
-    );
-    return set(this, keyName, ((get(this, keyName) as number) || 0) - decrement);
-  }
-  // NOT TYPE SAFE!
-  /**
-    Set the value of a boolean property to the opposite of its
-    current value.
-
-    ```javascript
-    starship.toggleProperty('warpDriveEngaged');
-    ```
-
-    @method toggleProperty
-    @param {String} keyName The name of the property to toggle
-    @return {Boolean} The new property value
-    @public
-  */
-  toggleProperty(keyName: keyof this & string): boolean {
-    return set(this, keyName, !get(this, keyName));
-  }
-  /**
-    Returns the cached value of a computed property, if it exists.
-    This allows you to inspect the value of a computed property
-    without accidentally invoking it if it is intended to be
-    generated lazily.
-
-    @method cacheFor
-    @param {String} keyName
-    @return {Object} The cached value of the computed property, if any
-    @public
-  */
-  cacheFor(keyName: keyof this & string): unknown {
-    let meta = peekMeta(this);
-    return meta !== null ? meta.valueFor(keyName) : undefined;
-  }
-
-  get _debugContainerKey() {
-    let factory = getFactoryFor(this);
-    return factory !== undefined && factory.fullName;
-  }
-}
+class EmberObject extends CoreObject {}
 
 export default EmberObject;
 

packages/@ember/object/index.ts

@@ -37,20 +37,6 @@ const p = new Person(owner);
 
 expectTypeOf(p.firstName).toEqualTypeOf<string>();
 
-expectTypeOf(p.incrementProperty('age')).toEqualTypeOf<number>();
-expectTypeOf(p.incrementProperty('age', 2)).toEqualTypeOf<number>();
-// @ts-expect-error must increment by a value
-p.incrementProperty('age', 'foo');
-
-expectTypeOf(p.decrementProperty('age')).toEqualTypeOf<number>();
-expectTypeOf(p.decrementProperty('age', 2)).toEqualTypeOf<number>();
-// @ts-expect-error must decrement by a value
-p.decrementProperty('age', 'foo');
-
-expectTypeOf(p.toggleProperty('age')).toEqualTypeOf<boolean>();
-
-expectTypeOf(p.cacheFor('age')).toEqualTypeOf<unknown>();
-
 const p2 = Person.create({ firstName: 'string' });
 expectTypeOf(p2.firstName).toEqualTypeOf<string>();
 

packages/@ember/object/type-tests/ember-object.test.ts

@@ -752,7 +752,7 @@ moduleFor(
         router: service(),
 
         increment: action(function () {
-          this.incrementProperty('foo');
+          set(this, 'foo', this.foo + 1);
           this.router.refresh();
         }),
       });