Make strict mode the default for template()

Author: wycats

packages/@ember/-internals/glimmer/tests/integration/components/runtime-template-compiler-explicit-test.ts

@@ -1,6 +1,8 @@
 import { template } from '@ember/template-compiler/runtime';
 import { RenderingTestCase, defineSimpleModifier, moduleFor } from 'internal-test-helpers';
 import GlimmerishComponent from '../../utils/glimmerish-component';
+import { on } from '@ember/modifier/on';
+import { fn } from '@ember/helper';
 
 moduleFor(
   'Strict Mode - Runtime Template Compiler (explicit)',
@@ -274,7 +276,7 @@ moduleFor(
         };
 
         return template('<button {{on "click" (fn handleClick 123)}}>Click</button>', {
-          scope: () => ({ handleClick }),
+          scope: () => ({ handleClick, on, fn }),
         });
       });
 

packages/@ember/-internals/glimmer/tests/integration/components/runtime-template-compiler-implicit-test.ts

@@ -2,6 +2,13 @@
 import { template } from '@ember/template-compiler/runtime';
 import { RenderingTestCase, defineSimpleModifier, moduleFor } from 'internal-test-helpers';
 import GlimmerishComponent from '../../utils/glimmerish-component';
+import { on } from '@ember/modifier/on';
+import { fn } from '@ember/helper';
+
+// Assign these to constants so that they don't get removed by an
+// eager transpiler pass. These days, people should be using
+// verbatim-mode compilers, but this codebase isn't doing that yet.
+const _ = [on, fn];
 
 moduleFor(
   'Strict Mode - Runtime Template Compiler (implicit)',

packages/@ember/template-compiler/lib/template.ts

@@ -14,6 +14,11 @@ type ComponentClass = abstract new (...args: any[]) => object;
  */
 export interface BaseTemplateOptions {
   moduleName?: string;
+  /**
+   * Whether the template should be treated as a strict-mode template. Defaults
+   * to `true`.
+   */
+  strictMode?: boolean;
 }
 
 /**
@@ -230,8 +235,9 @@ export function template<C extends ComponentClass>(
 ): C;
 export function template(
   templateString: string,
-  options?: BaseTemplateOptions | BaseClassTemplateOptions<any>
+  providedOptions?: BaseTemplateOptions | BaseClassTemplateOptions<any>
 ): object {
+  const options: EmberPrecompileOptions = { strictMode: true, ...providedOptions };
   const evaluate = buildEvaluator(options);
 
   const normalizedOptions = compileOptions(options);
@@ -261,12 +267,10 @@ function buildEvaluator(options: Partial<EmberPrecompileOptions> | undefined) {
   } else {
     const scope = options.scope?.();
 
-    if (!scope && options.component) {
+    if (!scope) {
       return evaluator;
     }
 
-    assert(`The 'template' function must be called with an evaluator, scope or component`, scope);
-
     return (source: string) => {
       const argNames = Object.keys(scope);
       const argValues = Object.values(scope);