Merge pull request #20449 from emberjs/types-from-source

[FEATURE] Publish stable types for Ember

Author: chriskrycho

broccoli/packages.js

@@ -140,6 +140,12 @@ module.exports.backburnerES = function _backburnerES() {
   return funnelLib('backburner.js', 'dist/es6', {
     files: ['backburner.js'],
     annotation: 'backburner es',
+    // This writes the "output" to `backburner.js.js` in the funnel, which means
+    // that when it gets fed into the Babel AMD transform, which (implicitly)
+    // pulls off the trailing `.js`, the result is just `backburner.js`, which
+    // is the actual Node-resolve-able (and therefore TS-resolve-able) ES module
+    // on disk.
+    getDestinationPath: (relativePath) => relativePath + '.js',
   });
 };
 

package.json

@@ -58,9 +58,24 @@
     "@babel/helper-module-imports": "^7.16.7",
     "@babel/plugin-transform-block-scoping": "^7.20.5",
     "@ember/edition-utils": "^1.2.0",
+    "@glimmer/compiler": "0.84.2",
+    "@glimmer/component": "^1.1.2",
+    "@glimmer/destroyable": "0.84.2",
+    "@glimmer/env": "^0.1.7",
+    "@glimmer/global-context": "0.84.2",
+    "@glimmer/interfaces": "0.84.2",
+    "@glimmer/manager": "0.84.2",
+    "@glimmer/node": "0.84.2",
+    "@glimmer/opcode-compiler": "0.84.2",
+    "@glimmer/owner": "0.84.2",
+    "@glimmer/program": "0.84.2",
+    "@glimmer/reference": "0.84.2",
+    "@glimmer/runtime": "0.84.2",
+    "@glimmer/validator": "0.84.2",
     "@glimmer/vm-babel-plugins": "0.84.2",
     "babel-plugin-debug-macros": "^0.3.4",
     "babel-plugin-filter-imports": "^4.0.0",
+    "backburner.js": "^2.7.0",
     "broccoli-concat": "^4.2.5",
     "broccoli-debug": "^0.6.4",
     "broccoli-file-creator": "^2.1.1",
@@ -79,26 +94,14 @@
     "ember-router-generator": "^2.0.0",
     "inflection": "^1.13.2",
     "resolve": "^1.22.0",
+    "route-recognizer": "^0.3.4",
+    "router_js": "^8.0.3",
     "semver": "^7.3.8",
     "silent-error": "^1.1.1"
   },
   "devDependencies": {
     "@aws-sdk/client-s3": "^3.321.1",
     "@babel/preset-env": "^7.16.11",
-    "@glimmer/compiler": "0.84.2",
-    "@glimmer/component": "^1.1.2",
-    "@glimmer/destroyable": "0.84.2",
-    "@glimmer/env": "^0.1.7",
-    "@glimmer/global-context": "0.84.2",
-    "@glimmer/interfaces": "0.84.2",
-    "@glimmer/manager": "0.84.2",
-    "@glimmer/node": "0.84.2",
-    "@glimmer/opcode-compiler": "0.84.2",
-    "@glimmer/owner": "0.84.2",
-    "@glimmer/program": "0.84.2",
-    "@glimmer/reference": "0.84.2",
-    "@glimmer/runtime": "0.84.2",
-    "@glimmer/validator": "0.84.2",
     "@simple-dom/document": "^1.4.0",
     "@tsconfig/ember": "^2.0.0",
     "@types/node": "^18.11.11",
@@ -110,7 +113,6 @@
     "auto-dist-tag": "^2.1.1",
     "aws-sdk": "^2.1325.0",
     "babel-template": "^6.26.0",
-    "backburner.js": "^2.7.0",
     "broccoli-babel-transpiler": "^7.8.1",
     "broccoli-persistent-filter": "^2.3.1",
     "broccoli-plugin": "^4.0.3",
@@ -152,8 +154,6 @@
     "puppeteer": "^19.4.1",
     "qunit": "^2.19.4",
     "recast": "^0.22.0",
-    "route-recognizer": "^0.3.4",
-    "router_js": "^8.0.3",
     "rsvp": "^4.8.5",
     "serve-static": "^1.14.2",
     "simple-dom": "^1.4.0",

packages/@ember/-internals/glimmer/index.ts

@@ -450,7 +450,12 @@ export { default as Input } from './lib/components/input';
 export { default as LinkTo } from './lib/components/link-to';
 export { default as Textarea } from './lib/components/textarea';
 export { default as Component } from './lib/component';
-export { default as Helper, helper } from './lib/helper';
+export {
+  default as Helper,
+  helper,
+  type FunctionBasedHelper,
+  type FunctionBasedHelperInstance,
+} from './lib/helper';
 export { SafeString, escapeExpression, htmlSafe, isHTMLSafe } from './lib/utils/string';
 export { Renderer, _resetRenderers, renderSettled } from './lib/renderer';
 export {

packages/@ember/-internals/glimmer/lib/component-managers/curly.ts

@@ -219,7 +219,7 @@ export default class CurlyComponentManager
       Object.assign(named, args.named.capture());
 
       for (let i = 0; i < count; i++) {
-        let name = positionalParams[i];
+        let name: string | undefined = positionalParams[i];
         assert('Expected at least one positional param', name);
 
         assert(