Skip to content

Commit 73145ba

Browse files
committed
Update tagging strategy
This is preparation to make it possible to have more than one published package living in this monorepo. It changes the tagging strategy so that releases of ember-source should be tagged like `v6.0.0-ember-source` instead of `v6.0.0`.
1 parent 040d925 commit 73145ba

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

.github/workflows/alpha-releases.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
5353
- name: push tag
5454
# Push in a way that will NOT trigger other workflows
55-
run: git push origin v${{env.NEXT_ALPHA}}
55+
run: git push origin v${{env.NEXT_ALPHA}}-ember-source
5656

5757
notify:
5858
name: Notify Discord

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ jobs:
126126
run: pnpm vite build --mode=development
127127

128128
- name: Set BrowserStack Local Identifier
129-
if: startsWith(github.ref, 'refs/tags/v')
129+
if: startsWith(github.ref, 'refs/tags/v') && endsWith(github.ref, '-ember-source')
130130
run: |
131131
BROWSERSTACK_LOCAL_IDENTIFIER="$GITHUB_RUN_ID-$GITHUB_RUN_ATTEMPT"
132132
echo "BROWSERSTACK_LOCAL_IDENTIFIER=$BROWSERSTACK_LOCAL_IDENTIFIER" >> $GITHUB_ENV
@@ -210,7 +210,7 @@ jobs:
210210
blueprint-test,
211211
browser-test,
212212
]
213-
if: startsWith(github.ref, 'refs/tags/v')
213+
if: startsWith(github.ref, 'refs/tags/v') && endsWith(github.ref, '-ember-source')
214214
steps:
215215
- uses: actions/checkout@v4
216216
- uses: ./.github/actions/setup

broccoli/build-info.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,9 @@ function readPackageVersion(root) {
125125
* @param {string} tag
126126
*/
127127
function parseTagVersion(tag) {
128-
return tag && semver.parse(tag).version;
128+
if (tag) {
129+
return semver.parse(tag.replace(/-ember-source$/, '')).version;
130+
}
129131
}
130132

131133
/**

tests/node/build-info-test.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,14 @@ QUnit.module('parseTagVersion', () => {
4848
tag: 'v3.1.1-beta.2',
4949
expected: '3.1.1-beta.2',
5050
},
51+
{
52+
tag: 'v3.4.4-ember-source',
53+
expected: '3.4.4',
54+
},
55+
{
56+
tag: 'v3.1.1-beta.2-ember-source',
57+
expected: '3.1.1-beta.2',
58+
},
5159
].forEach(({ tag, expected }) => {
5260
QUnit.test(JSON.stringify(tag), function (assert) {
5361
assert.equal(parseTagVersion(tag), expected);

0 commit comments

Comments
 (0)