Skip to content

Commit 75427e7

Browse files
committed
Kill ViewStateSupport mixin
1 parent 4b0041d commit 75427e7

File tree

5 files changed

+15
-39
lines changed

5 files changed

+15
-39
lines changed

broccoli/amd-compat-entrypoints/ember.debug.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,6 @@ d('@ember/-internals/views/lib/component_lookup', emberinternalsViewsLibComponen
107107
import * as emberinternalsViewsLibMixinsActionSupport from '@ember/-internals/views/lib/mixins/action_support';
108108
d('@ember/-internals/views/lib/mixins/action_support', emberinternalsViewsLibMixinsActionSupport);
109109

110-
import * as emberinternalsViewsLibMixinsViewStateSupport from '@ember/-internals/views/lib/mixins/view_state_support';
111-
d(
112-
'@ember/-internals/views/lib/mixins/view_state_support',
113-
emberinternalsViewsLibMixinsViewStateSupport
114-
);
115-
116110
import * as emberinternalsViewsLibMixinsViewSupport from '@ember/-internals/views/lib/mixins/view_support';
117111
d('@ember/-internals/views/lib/mixins/view_support', emberinternalsViewsLibMixinsViewSupport);
118112

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@
215215
"@ember/-internals/views/lib/compat/fallback-view-registry.js": "ember-source/@ember/-internals/views/lib/compat/fallback-view-registry.js",
216216
"@ember/-internals/views/lib/component_lookup.js": "ember-source/@ember/-internals/views/lib/component_lookup.js",
217217
"@ember/-internals/views/lib/mixins/action_support.js": "ember-source/@ember/-internals/views/lib/mixins/action_support.js",
218-
"@ember/-internals/views/lib/mixins/view_state_support.js": "ember-source/@ember/-internals/views/lib/mixins/view_state_support.js",
219218
"@ember/-internals/views/lib/mixins/view_support.js": "ember-source/@ember/-internals/views/lib/mixins/view_support.js",
220219
"@ember/-internals/views/lib/system/action_manager.js": "ember-source/@ember/-internals/views/lib/system/action_manager.js",
221220
"@ember/-internals/views/lib/system/event_dispatcher.js": "ember-source/@ember/-internals/views/lib/system/event_dispatcher.js",

packages/@ember/-internals/glimmer/lib/component.ts

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
import type { PropertyDidChange } from '@ember/-internals/metal/lib/property_events';
99
import { getOwner } from '@ember/-internals/owner';
1010
import { TargetActionSupport } from '@ember/-internals/runtime';
11+
import type { ViewStates } from '@ember/-internals/views';
1112
import {
1213
ActionSupport,
1314
addChildView,
@@ -16,7 +17,6 @@ import {
1617
getChildViews,
1718
getViewElement,
1819
ViewMixin,
19-
ViewStateSupport,
2020
} from '@ember/-internals/views';
2121
import { assert } from '@ember/debug';
2222
import { DEBUG } from '@glimmer/env';
@@ -775,22 +775,19 @@ declare const SIGNATURE: unique symbol;
775775
@uses Ember.TargetActionSupport
776776
@uses Ember.ActionSupport
777777
@uses Ember.ViewMixin
778-
@uses Ember.ViewStateSupport
779778
@public
780779
*/
781780
// This type param is used in the class, so must appear here.
782781
// eslint-disable-next-line @typescript-eslint/no-unused-vars
783782
interface Component<S = unknown>
784783
extends CoreView,
785-
ViewStateSupport,
786784
TargetActionSupport,
787785
ActionSupport,
788786
ViewMixin,
789787
ComponentMethods {}
790788

791789
class Component<S = unknown>
792790
extends CoreView.extend(
793-
ViewStateSupport,
794791
TargetActionSupport,
795792
ActionSupport,
796793
ViewMixin,
@@ -1228,6 +1225,19 @@ class Component<S = unknown>
12281225
addChildView(this, view);
12291226
}
12301227

1228+
_transitionTo(this: Component, state: keyof typeof ViewStates) {
1229+
let priorState = this._currentState;
1230+
let currentState = (this._currentState = this._states[state]);
1231+
this._state = state;
1232+
1233+
if (priorState && priorState.exit) {
1234+
priorState.exit(this);
1235+
}
1236+
if (currentState.enter) {
1237+
currentState.enter(this);
1238+
}
1239+
}
1240+
12311241
static isComponentFactory = true;
12321242

12331243
static toString() {

packages/@ember/-internals/views/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ export {
1818
export { default as EventDispatcher } from './lib/system/event_dispatcher';
1919
export { default as ComponentLookup } from './lib/component_lookup';
2020
export { default as CoreView } from './lib/views/core_view';
21-
export { default as ViewStateSupport } from './lib/mixins/view_state_support';
2221
export { default as ViewMixin } from './lib/mixins/view_support';
2322
export { default as ActionSupport } from './lib/mixins/action_support';
2423
export { MUTABLE_CELL } from './lib/compat/attrs';
2524
export { default as ActionManager } from './lib/system/action_manager';
25+
export { default as ViewStates } from './lib/views/states';

packages/@ember/-internals/views/lib/mixins/view_state_support.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)