Skip to content

Commit 91467a6

Browse files
authored
Merge pull request #20842 from NullVoxPopuli/nvp/upgrade-glimmer-vm-0-94
Upgrade glimmer-vm
2 parents 930df88 + 64fc979 commit 91467a6

File tree

66 files changed

+690
-680
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+690
-680
lines changed

.eslintrc.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,8 @@ module.exports = {
2626

2727
'disable-features/disable-async-await': 'error',
2828
'disable-features/disable-generator-functions': 'error',
29-
'import/no-unresolved': [
30-
'error',
31-
{
32-
ignore: ['@ember/template-compiler'],
33-
},
34-
],
29+
// Doesn't work with package.json#exports
30+
'import/no-unresolved': 'off',
3531
},
3632

3733
settings: {

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
matrix:
5757
# I removed 'next' from this list because we're seeing buggy behavior in
5858
# the so-far unreleased 5.4. -ef4
59-
ts-version: ['4.9', '5.0', '5.1', '5.2', '5.3']
59+
ts-version: ['5.0', '5.1', '5.2', '5.3', '5.4', '5.5', '5.6', '5.7']
6060
steps:
6161
- uses: actions/checkout@v4
6262
- uses: ./.github/actions/setup

bin/run-tests-browser-runner.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,17 @@ module.exports = class BrowserRunner {
6565
}
6666

6767
async newBrowser() {
68-
let browser = await puppeteer.launch({ dumpio: true, headless: 'new' });
68+
let browser = await puppeteer.launch({
69+
dumpio: true,
70+
headless: 'new',
71+
userDataDir: '/tmp/new-profile',
72+
args: [
73+
'--no-sandbox',
74+
'--disable-dev-shm-usage',
75+
'--disable-software-rasterizer',
76+
'--mute-audio',
77+
],
78+
});
6979
return browser;
7080
}
7181

bin/run-tests.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,13 @@ run()
8181
process.exit(0); // eslint-disable-line n/no-process-exit
8282
})
8383
.catch(function (err) {
84-
console.error(chalk.red(err.toString()));
84+
console.error(chalk.red(`Error!`));
85+
86+
if ('passed' in err) {
87+
console.error(err);
88+
} else {
89+
console.error(chalk.red(err.toString()));
90+
}
8591
console.error(chalk.red('Failed!'));
8692
process.exit(1); // eslint-disable-line n/no-process-exit
8793
});

broccoli/amd-compat-entrypoints/ember.debug.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -419,9 +419,6 @@ d('@ember/utils/lib/type-of', emberUtilsLibTypeOf);
419419
import * as emberVersionIndex from '@ember/version/index';
420420
d('@ember/version/index', emberVersionIndex);
421421

422-
import * as glimmerDebug from '@glimmer/debug';
423-
d('@glimmer/debug', glimmerDebug);
424-
425422
import * as glimmerDestroyable from '@glimmer/destroyable';
426423
d('@glimmer/destroyable', glimmerDestroyable);
427424

package.json

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -66,23 +66,23 @@
6666
"@babel/core": "^7.24.4",
6767
"@ember/edition-utils": "^1.2.0",
6868
"@embroider/addon-shim": "^1.9.0",
69-
"@glimmer/compiler": "0.92.4",
70-
"@glimmer/destroyable": "0.92.3",
69+
"@glimmer/compiler": "0.94.8",
70+
"@glimmer/destroyable": "0.94.6",
7171
"@glimmer/env": "^0.1.7",
72-
"@glimmer/global-context": "0.92.3",
73-
"@glimmer/interfaces": "0.92.3",
74-
"@glimmer/manager": "0.92.4",
75-
"@glimmer/node": "0.92.4",
76-
"@glimmer/opcode-compiler": "0.92.4",
77-
"@glimmer/owner": "0.92.3",
78-
"@glimmer/program": "0.92.4",
79-
"@glimmer/reference": "0.92.3",
80-
"@glimmer/runtime": "0.92.4",
81-
"@glimmer/syntax": "0.92.3",
82-
"@glimmer/util": "0.92.3",
83-
"@glimmer/validator": "0.92.3",
84-
"@glimmer/vm": "0.92.3",
85-
"@glimmer/vm-babel-plugins": "0.92.3",
72+
"@glimmer/global-context": "0.93.2",
73+
"@glimmer/interfaces": "0.94.5",
74+
"@glimmer/manager": "0.94.7",
75+
"@glimmer/node": "0.94.7",
76+
"@glimmer/opcode-compiler": "0.94.7",
77+
"@glimmer/owner": "0.93.2",
78+
"@glimmer/program": "0.94.7",
79+
"@glimmer/reference": "0.94.6",
80+
"@glimmer/runtime": "0.94.7",
81+
"@glimmer/syntax": "0.94.7",
82+
"@glimmer/util": "0.94.6",
83+
"@glimmer/validator": "0.94.6",
84+
"@glimmer/vm": "0.94.6",
85+
"@glimmer/vm-babel-plugins": "0.93.3",
8686
"@simple-dom/interface": "^1.4.0",
8787
"backburner.js": "^2.8.0",
8888
"broccoli-file-creator": "^2.1.1",
@@ -117,7 +117,7 @@
117117
"@simple-dom/document": "^1.4.0",
118118
"@swc-node/register": "^1.6.8",
119119
"@swc/core": "^1.3.100",
120-
"@tsconfig/ember": "^2.0.0",
120+
"@tsconfig/ember": "3.0.8",
121121
"@types/qunit": "^2.19.4",
122122
"@types/rsvp": "^4.0.4",
123123
"@typescript-eslint/eslint-plugin": "^5.59.8",
@@ -153,9 +153,10 @@
153153
"mocha": "^10.2.0",
154154
"npm-run-all2": "^6.0.6",
155155
"prettier": "^2.8.0",
156-
"puppeteer": "^24.1.0",
156+
"puppeteer": "^24.2.0",
157157
"qunit": "^2.19.4",
158158
"recast": "^0.22.0",
159+
"resolve.exports": "^2.0.3",
159160
"rollup": "^4.2.0",
160161
"rsvp": "^4.8.5",
161162
"serve-static": "^1.14.2",
@@ -331,7 +332,6 @@
331332
"@ember/utils/lib/is_present.js": "ember-source/@ember/utils/lib/is_present.js",
332333
"@ember/utils/lib/type-of.js": "ember-source/@ember/utils/lib/type-of.js",
333334
"@ember/version/index.js": "ember-source/@ember/version/index.js",
334-
"@glimmer/debug/index.js": "ember-source/@glimmer/debug/index.js",
335335
"@glimmer/destroyable/index.js": "ember-source/@glimmer/destroyable/index.js",
336336
"@glimmer/encoder/index.js": "ember-source/@glimmer/encoder/index.js",
337337
"@glimmer/env/index.js": "ember-source/@glimmer/env/index.js",
@@ -399,4 +399,4 @@
399399
"node": "16.20.0",
400400
"pnpm": "8.10.0"
401401
}
402-
}
402+
}

packages/@ember/-internals/glimmer/lib/component-managers/curly.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ import type {
2828
import type { Reference } from '@glimmer/reference';
2929
import { childRefFor, createComputeRef, createPrimitiveRef, valueForRef } from '@glimmer/reference';
3030
import { reifyPositional } from '@glimmer/runtime';
31-
import { EMPTY_ARRAY, unwrapTemplate } from '@glimmer/util';
31+
import { EMPTY_ARRAY } from '@glimmer/util';
32+
import { unwrapTemplate } from './unwrap-template';
3233
import {
3334
beginTrackFrame,
3435
beginUntrackFrame,

packages/@ember/-internals/glimmer/lib/component-managers/mount.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import type { Nullable } from '@ember/-internals/utility-types';
2121
import { capabilityFlagsFrom } from '@glimmer/manager';
2222
import type { Reference } from '@glimmer/reference';
2323
import { createConstRef, valueForRef } from '@glimmer/reference';
24-
import { unwrapTemplate } from '@glimmer/util';
24+
import { unwrapTemplate } from './unwrap-template';
2525
import type RuntimeResolver from '../resolver';
2626

2727
interface EngineState {

packages/@ember/-internals/glimmer/lib/component-managers/outlet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { capabilityFlagsFrom } from '@glimmer/manager';
1919
import type { Reference } from '@glimmer/reference';
2020
import { UNDEFINED_REFERENCE, valueForRef } from '@glimmer/reference';
2121
import { EMPTY_ARGS } from '@glimmer/runtime';
22-
import { unwrapTemplate } from '@glimmer/util';
22+
import { unwrapTemplate } from './unwrap-template';
2323

2424
import type { DynamicScope } from '../renderer';
2525
import type { OutletState } from '../utils/outlet';

packages/@ember/-internals/glimmer/lib/component-managers/route-template.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import type {
44
CapturedArguments,
55
CompilableProgram,
66
ComponentDefinition,
7+
CurriedComponent,
78
CustomRenderNode,
89
Destroyable,
910
InternalComponentCapabilities,
@@ -18,8 +19,7 @@ import { capabilityFlagsFrom } from '@glimmer/manager';
1819
import type { Reference } from '@glimmer/reference';
1920
import { createDebugAliasRef, valueForRef } from '@glimmer/reference';
2021
import { curry, type CurriedValue } from '@glimmer/runtime';
21-
import { unwrapTemplate } from '@glimmer/util';
22-
import { CurriedType } from '@glimmer/vm';
22+
import { unwrapTemplate } from './unwrap-template';
2323

2424
interface RouteTemplateInstanceState {
2525
self: Reference;
@@ -158,5 +158,5 @@ export function makeRouteTemplate(
158158
template: Template
159159
): CurriedValue {
160160
let routeTemplate = new RouteTemplate(name, template);
161-
return curry(CurriedType.Component, routeTemplate, owner, null, true);
161+
return curry(0 as CurriedComponent, routeTemplate, owner, null, true);
162162
}

0 commit comments

Comments
 (0)