Skip to content

Commit a6760ec

Browse files
committed
Kill TargetActionSupport
1 parent e7291d5 commit a6760ec

File tree

12 files changed

+8
-465
lines changed

12 files changed

+8
-465
lines changed

broccoli/amd-compat-entrypoints/ember.debug.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,6 @@ d(
6868
emberinternalsRuntimeLibMixinsRegistryProxy
6969
);
7070

71-
import * as emberinternalsRuntimeLibMixinsTargetActionSupport from '@ember/-internals/runtime/lib/mixins/target_action_support';
72-
d(
73-
'@ember/-internals/runtime/lib/mixins/target_action_support',
74-
emberinternalsRuntimeLibMixinsTargetActionSupport
75-
);
76-
7771
import * as emberinternalsStringIndex from '@ember/-internals/string/index';
7872
d('@ember/-internals/string/index', emberinternalsStringIndex);
7973

@@ -98,9 +92,6 @@ d(
9892
import * as emberinternalsViewsLibComponentLookup from '@ember/-internals/views/lib/component_lookup';
9993
d('@ember/-internals/views/lib/component_lookup', emberinternalsViewsLibComponentLookup);
10094

101-
import * as emberinternalsViewsLibMixinsActionSupport from '@ember/-internals/views/lib/mixins/action_support';
102-
d('@ember/-internals/views/lib/mixins/action_support', emberinternalsViewsLibMixinsActionSupport);
103-
10495
import * as emberinternalsViewsLibSystemActionManager from '@ember/-internals/views/lib/system/action_manager';
10596
d('@ember/-internals/views/lib/system/action_manager', emberinternalsViewsLibSystemActionManager);
10697

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,15 +205,13 @@
205205
"@ember/-internals/runtime/lib/ext/rsvp.js": "ember-source/@ember/-internals/runtime/lib/ext/rsvp.js",
206206
"@ember/-internals/runtime/lib/mixins/container_proxy.js": "ember-source/@ember/-internals/runtime/lib/mixins/container_proxy.js",
207207
"@ember/-internals/runtime/lib/mixins/registry_proxy.js": "ember-source/@ember/-internals/runtime/lib/mixins/registry_proxy.js",
208-
"@ember/-internals/runtime/lib/mixins/target_action_support.js": "ember-source/@ember/-internals/runtime/lib/mixins/target_action_support.js",
209208
"@ember/-internals/string/index.js": "ember-source/@ember/-internals/string/index.js",
210209
"@ember/-internals/utility-types/index.js": "ember-source/@ember/-internals/utility-types/index.js",
211210
"@ember/-internals/utils/index.js": "ember-source/@ember/-internals/utils/index.js",
212211
"@ember/-internals/views/index.js": "ember-source/@ember/-internals/views/index.js",
213212
"@ember/-internals/views/lib/compat/attrs.js": "ember-source/@ember/-internals/views/lib/compat/attrs.js",
214213
"@ember/-internals/views/lib/compat/fallback-view-registry.js": "ember-source/@ember/-internals/views/lib/compat/fallback-view-registry.js",
215214
"@ember/-internals/views/lib/component_lookup.js": "ember-source/@ember/-internals/views/lib/component_lookup.js",
216-
"@ember/-internals/views/lib/mixins/action_support.js": "ember-source/@ember/-internals/views/lib/mixins/action_support.js",
217215
"@ember/-internals/views/lib/system/action_manager.js": "ember-source/@ember/-internals/views/lib/system/action_manager.js",
218216
"@ember/-internals/views/lib/system/event_dispatcher.js": "ember-source/@ember/-internals/views/lib/system/event_dispatcher.js",
219217
"@ember/-internals/views/lib/system/utils.js": "ember-source/@ember/-internals/views/lib/system/utils.js",

packages/@ember/-internals/glimmer/lib/component-managers/curly.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default class CurlyComponentManager
239239
/*
240240
* This hook is responsible for actually instantiating the component instance.
241241
* It also is where we perform additional bookkeeping to support legacy
242-
* features like exposed by view mixins like ChildViewSupport, ActionSupport,
242+
* features like exposed by view mixins like ChildViewSupport,
243243
* etc.
244244
*/
245245
create(

packages/@ember/-internals/glimmer/lib/component.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@ import {
77
} from '@ember/-internals/metal';
88
import type { PropertyDidChange } from '@ember/-internals/metal/lib/property_events';
99
import { getOwner } from '@ember/-internals/owner';
10-
import { TargetActionSupport } from '@ember/-internals/runtime';
1110
import type { ViewStates } from '@ember/-internals/views';
1211
import {
13-
ActionSupport,
1412
addChildView,
1513
CoreView,
1614
EventDispatcher,
@@ -789,22 +787,14 @@ declare const SIGNATURE: unique symbol;
789787
790788
@class Component
791789
@extends Ember.CoreView
792-
@uses Ember.TargetActionSupport
793-
@uses Ember.ActionSupport
794790
@public
795791
*/
796792
// This type param is used in the class, so must appear here.
797793
// eslint-disable-next-line @typescript-eslint/no-unused-vars
798-
interface Component<S = unknown>
799-
extends CoreView,
800-
TargetActionSupport,
801-
ActionSupport,
802-
ComponentMethods {}
794+
interface Component<S = unknown> extends CoreView, ComponentMethods {}
803795

804796
class Component<S = unknown>
805797
extends CoreView.extend(
806-
TargetActionSupport,
807-
ActionSupport,
808798
{
809799
// These need to be overridable via extend/create but should still
810800
// have a default. Defining them here is the best way to achieve that.
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
export { default as RegistryProxyMixin } from './lib/mixins/registry_proxy';
22
export { default as ContainerProxyMixin } from './lib/mixins/container_proxy';
33
export { default as MutableEnumerable } from '@ember/enumerable/mutable';
4-
export { default as TargetActionSupport } from './lib/mixins/target_action_support';
54

65
export { default as RSVP, onerrorDefault } from './lib/ext/rsvp'; // just for side effect of extending Ember.RSVP

packages/@ember/-internals/runtime/lib/mixins/target_action_support.ts

Lines changed: 0 additions & 176 deletions
This file was deleted.

0 commit comments

Comments
 (0)