Inline lifecycle methods

Author: wagenet

packages/@ember/-internals/glimmer/lib/component.ts

@@ -61,150 +61,6 @@ function matches(el: Element, selector: string): boolean {
 @module @ember/component
 */
 
-interface ComponentMethods {
-  // Overrideable methods are defined here since you can't `declare` a method in a class
-
-  /**
-   Called when the attributes passed into the component have been updated.
-    Called both during the initial render of a container and during a rerender.
-    Can be used in place of an observer; code placed here will be executed
-    every time any attribute updates.
-    @method didReceiveAttrs
-    @public
-    @since 1.13.0
-    */
-  didReceiveAttrs(): void;
-
-  /**
-   Called when the attributes passed into the component have been updated.
-    Called both during the initial render of a container and during a rerender.
-    Can be used in place of an observer; code placed here will be executed
-    every time any attribute updates.
-    @event didReceiveAttrs
-    @public
-    @since 1.13.0
-    */
-
-  /**
-   Called after a component has been rendered, both on initial render and
-    in subsequent rerenders.
-    @method didRender
-    @public
-    @since 1.13.0
-    */
-  didRender(): void;
-
-  /**
-   Called after a component has been rendered, both on initial render and
-    in subsequent rerenders.
-    @event didRender
-    @public
-    @since 1.13.0
-    */
-
-  /**
-   Called before a component has been rendered, both on initial render and
-    in subsequent rerenders.
-    @method willRender
-    @public
-    @since 1.13.0
-    */
-  willRender(): void;
-
-  /**
-   Called before a component has been rendered, both on initial render and
-    in subsequent rerenders.
-    @event willRender
-    @public
-    @since 1.13.0
-    */
-
-  /**
-   Called when the attributes passed into the component have been changed.
-    Called only during a rerender, not during an initial render.
-    @method didUpdateAttrs
-    @public
-    @since 1.13.0
-    */
-  didUpdateAttrs(): void;
-
-  /**
-   Called when the attributes passed into the component have been changed.
-    Called only during a rerender, not during an initial render.
-    @event didUpdateAttrs
-    @public
-    @since 1.13.0
-    */
-
-  /**
-   Called when the component is about to update and rerender itself.
-    Called only during a rerender, not during an initial render.
-    @method willUpdate
-    @public
-    @since 1.13.0
-    */
-  willUpdate(): void;
-
-  /**
-   Called when the component is about to update and rerender itself.
-    Called only during a rerender, not during an initial render.
-    @event willUpdate
-    @public
-    @since 1.13.0
-    */
-
-  /**
-   Called when the component has updated and rerendered itself.
-    Called only during a rerender, not during an initial render.
-    @method didUpdate
-    @public
-    @since 1.13.0
-    */
-  didUpdate(): void;
-
-  /**
-   Called when the component has updated and rerendered itself.
-    Called only during a rerender, not during an initial render.
-    @event didUpdate
-    @public
-    @since 1.13.0
-    */
-
-  /**
-    The HTML `id` of the component's element in the DOM. You can provide this
-    value yourself but it must be unique (just as in HTML):
-
-    ```handlebars
-    {{my-component elementId="a-really-cool-id"}}
-    ```
-
-    ```handlebars
-    <MyComponent @elementId="a-really-cool-id" />
-    ```
-    If not manually set a default value will be provided by the framework.
-    Once rendered an element's `elementId` is considered immutable and you
-    should never change it. If you need to compute a dynamic value for the
-    `elementId`, you should do this when the component or element is being
-    instantiated:
-
-    ```javascript
-    export default class extends Component {
-      init() {
-        super.init(...arguments);
-
-        var index = this.get('index');
-        this.set('elementId', `component-id${index}`);
-      }
-    }
-    ```
-
-    @property elementId
-    @type String
-    @public
-  */
-  layoutName?: string;
-}
-
 // A zero-runtime-overhead private symbol to use in branding the component to
 // preserve its type parameter.
 declare const SIGNATURE: unique symbol;
@@ -793,34 +649,12 @@ declare const SIGNATURE: unique symbol;
   @uses Ember.ActionSupport
   @public
 */
-// This type param is used in the class, so must appear here.
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-interface Component<S = unknown>
-  extends CoreView,
-    TargetActionSupport,
-    ActionSupport,
-    ComponentMethods {}
-
 class Component<S = unknown>
-  extends CoreView.extend(
-    TargetActionSupport,
-    ActionSupport,
-    {
-      // These need to be overridable via extend/create but should still
-      // have a default. Defining them here is the best way to achieve that.
-      didReceiveAttrs() {},
-      didRender() {},
-      didUpdate() {},
-      didUpdateAttrs() {},
-      willRender() {},
-      willUpdate() {},
-    } as ComponentMethods,
-    {
-      concatenatedProperties: ['attributeBindings', 'classNames', 'classNameBindings'],
-      classNames: EMPTY_ARRAY,
-      classNameBindings: EMPTY_ARRAY,
-    }
-  )
+  extends CoreView.extend({
+    concatenatedProperties: ['attributeBindings', 'classNames', 'classNameBindings'],
+    classNames: EMPTY_ARRAY,
+    classNameBindings: EMPTY_ARRAY,
+  })
   implements PropertyDidChange
 {
   isComponent = true;
@@ -1681,6 +1515,98 @@ class Component<S = unknown>
 
   // End ViewMixin
 
+  // Begin lifecycle hooks
+
+  /**
+   Called when the attributes passed into the component have been updated.
+   Called both during the initial render of a container and during a rerender.
+   Can be used in place of an observer; code placed here will be executed
+   every time any attribute updates.
+   @method didReceiveAttrs
+   @public
+   @since 1.13.0
+  */
+  didReceiveAttrs(): void {}
+
+  /**
+   Called after a component has been rendered, both on initial render and
+    in subsequent rerenders.
+    @method didRender
+    @public
+    @since 1.13.0
+    */
+  didRender(): void {}
+
+  /**
+   Called after a component has been rendered, both on initial render and
+    in subsequent rerenders.
+    @event didRender
+    @public
+    @since 1.13.0
+    */
+
+  /**
+   Called before a component has been rendered, both on initial render and
+    in subsequent rerenders.
+    @method willRender
+    @public
+    @since 1.13.0
+    */
+  willRender(): void {}
+
+  /**
+   Called before a component has been rendered, both on initial render and
+    in subsequent rerenders.
+    @event willRender
+    @public
+    @since 1.13.0
+    */
+
+  /**
+   Called when the attributes passed into the component have been changed.
+    Called only during a rerender, not during an initial render.
+    @method didUpdateAttrs
+    @public
+    @since 1.13.0
+    */
+  didUpdateAttrs(): void {}
+
+  /**
+   Called when the attributes passed into the component have been changed.
+    Called only during a rerender, not during an initial render.
+    @event didUpdateAttrs
+    @public
+    @since 1.13.0
+    */
+
+  /**
+   Called when the component is about to update and rerender itself.
+    Called only during a rerender, not during an initial render.
+    @method willUpdate
+    @public
+    @since 1.13.0
+    */
+  willUpdate(): void {}
+
+  /**
+   Called when the component is about to update and rerender itself.
+    Called only during a rerender, not during an initial render.
+    @event willUpdate
+    @public
+    @since 1.13.0
+    */
+
+  /**
+   Called when the component has updated and rerendered itself.
+    Called only during a rerender, not during an initial render.
+    @method didUpdate
+    @public
+    @since 1.13.0
+    */
+  didUpdate(): void {}
+
+  // End lifecycle hooks
+
   static isComponentFactory = true;
 
   static toString() {