Disable @typescript-eslint/no-empty-object-type at the site of

complaints. I don't know enough to make any changes but the directives
are better than blocking an upgrade.

Author: kategengler

packages/@ember/-internals/glimmer/lib/components/link-to.ts

@@ -16,6 +16,7 @@ import LinkToTemplate from '../templates/link-to';
 import InternalComponent, { type OpaqueInternalComponentConstructor, opaquify } from './internal';
 import { type Opaque } from '@ember/-internals/utility-types';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 const EMPTY_ARRAY: {}[] = [];
 const EMPTY_QUERY_PARAMS = {};
 
@@ -32,6 +33,7 @@ function isPresent<T>(value: Maybe<T>): value is T {
 
 interface QueryParams {
   isQueryParams: true;
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   values: Nullable<{}>;
 }
 
@@ -434,6 +436,7 @@ class _LinkTo extends InternalComponent {
   }
 
   // TODO: not sure why generateURL takes {}[] instead of unknown[]
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   private get models(): {}[] {
     if ('models' in this.args.named) {
       let models = this.named('models');
@@ -445,6 +448,7 @@ class _LinkTo extends InternalComponent {
 
       return models;
     } else if ('model' in this.args.named) {
+      // eslint-disable-next-line @typescript-eslint/no-empty-object-type
       return [this.named('model') as {}];
     } else {
       return EMPTY_ARRAY;
@@ -623,11 +627,13 @@ let descriptorFor = (target: object, property: string): Nullable<PropertyDescrip
     superModelsDescriptor && typeof superModelsDescriptor.get === 'function'
   );
 
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   let superModelsGetter = superModelsDescriptor.get as (this: _LinkTo) => {}[];
 
   Object.defineProperty(prototype, 'models', {
     configurable: true,
     enumerable: false,
+    // eslint-disable-next-line @typescript-eslint/no-empty-object-type
     get: function models(this: _LinkTo): {}[] {
       let models = superModelsGetter.call(this);
 
@@ -648,11 +654,13 @@ let descriptorFor = (target: object, property: string): Nullable<PropertyDescrip
     superQueryDescriptor && typeof superQueryDescriptor.get === 'function'
   );
 
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   let superQueryGetter = superQueryDescriptor.get as (this: _LinkTo) => {};
 
   Object.defineProperty(prototype, 'query', {
     configurable: true,
     enumerable: false,
+    // eslint-disable-next-line @typescript-eslint/no-empty-object-type
     get: function query(this: _LinkTo): {} {
       if ('query' in this.args.named) {
         let qp = superQueryGetter.call(this);

packages/@ember/-internals/glimmer/lib/helper.ts

@@ -19,6 +19,7 @@ export const RECOMPUTE_TAG = Symbol('RECOMPUTE_TAG');
 // Signature type utilities
 type GetOr<T, K, Else> = K extends keyof T ? T[K] : Else;
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 type Args<S> = GetOr<S, 'Args', {}>;
 
 type DefaultPositional = unknown[];

packages/@ember/routing/lib/dsl.ts

@@ -9,6 +9,7 @@ let uuid = 0;
 export interface RouteOptions {
   path?: string;
   resetNamespace?: boolean;
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   serialize?: (model: {}, params: string[]) => { [key: string]: unknown | undefined };
   overrideNameAssertion?: boolean;
 }
@@ -49,6 +50,7 @@ export interface DSLImplOptions {
 
 export default class DSLImpl implements DSL {
   parent: string | null;
+  // eslint-disable-next-line @typescript-eslint/no-wrapper-object-types
   matches: Array<Object | undefined>;
   enableLoadingSubstates: boolean;
   explicitIndex = false;
@@ -128,6 +130,7 @@ export default class DSLImpl implements DSL {
     url: string,
     name: string,
     callback?: MatchCallback,
+    // eslint-disable-next-line @typescript-eslint/no-empty-object-type
     serialize?: (model: {}, params: string[]) => { [key: string]: unknown | undefined }
   ): void {
     let parts = name.split('.');

packages/@ember/routing/lib/engines.ts

@@ -7,5 +7,6 @@ export interface EngineInfo {
 
 export interface EngineRouteInfo extends EngineInfo {
   localFullName: string;
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   serializeMethod?: (model: {}, params: string[]) => { [key: string]: unknown | undefined };
 }

packages/@ember/routing/lib/generate_controller.ts

@@ -16,10 +16,12 @@ import { DEBUG } from '@glimmer/env';
   @private
 */
 
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 export function generateControllerFactory(
   owner: Owner,
   controllerName: string
 ): InternalFactory<{}> {
+  /* eslint-enable @typescript-eslint/no-empty-object-type */
   let factoryManager = owner.factoryFor('controller:basic');
   assert(
     '[BUG] unexpectedly missing a factoryManager for `controller:basic`',
@@ -46,6 +48,7 @@ export function generateControllerFactory(
 
   owner.register(fullName, Factory);
 
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   return owner.factoryFor(fullName) as InternalFactory<{}>;
 }
 

packages/@ember/routing/lib/utils.ts

@@ -137,6 +137,7 @@ function _calculateCacheValuePrefix(prefix: string, part: string) {
 /*
   Stolen from Controller
 */
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export function calculateCacheKey(prefix: string, parts: string[] = [], values: {} | null): string {
   let suffixes = '';
   for (let part of parts) {

packages/@ember/routing/route.ts

@@ -720,6 +720,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)
 
     @property _optionsForQueryParam
   */
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   _optionsForQueryParam(qp: QueryParam): {} {
     const queryParams = get(this, 'queryParams');
     return (
@@ -2097,6 +2098,7 @@ Route.reopen({
     @returns {boolean}
     @private
    */
+    // eslint-disable-next-line @typescript-eslint/no-empty-object-type
     queryParamsDidChange<T>(this: Route<T>, changed: {}, _totalPresent: unknown, removed: {}) {
       // SAFETY: Since `_qp` is protected we can't infer the type
       let qpMap = (get(this, '_qp') as Route<T>['_qp']).map;
@@ -2120,6 +2122,7 @@ Route.reopen({
     finalizeQueryParamChange<T>(
       this: Route<T>,
       params: Record<string, string | null | undefined>,
+      // eslint-disable-next-line @typescript-eslint/no-empty-object-type
       finalParams: {}[],
       transition: Transition
     ) {

packages/@ember/routing/router.ts

@@ -109,6 +109,7 @@ export interface QueryParam {
   type: string;
   route: Route;
   parts?: string[];
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   values: {} | null;
   scopedPropertyName: string;
   scope: string;
@@ -1068,6 +1069,7 @@ class EmberRouter extends EmberObject.extend(Evented) implements Evented {
     targetRouteName: string,
     models: ModelFor<Route>[],
     queryParams: Record<string, unknown>,
+    // eslint-disable-next-line @typescript-eslint/no-empty-object-type
     _queryParams: {}
   ) {
     // merge in any queryParams from the active transition which could include