Kill ChildViewsSupport mixin

Author: wagenet

broccoli/amd-compat-entrypoints/ember.debug.js

@@ -107,12 +107,6 @@ d('@ember/-internals/views/lib/component_lookup', emberinternalsViewsLibComponen
 import * as emberinternalsViewsLibMixinsActionSupport from '@ember/-internals/views/lib/mixins/action_support';
 d('@ember/-internals/views/lib/mixins/action_support', emberinternalsViewsLibMixinsActionSupport);
 
-import * as emberinternalsViewsLibMixinsChildViewsSupport from '@ember/-internals/views/lib/mixins/child_views_support';
-d(
-  '@ember/-internals/views/lib/mixins/child_views_support',
-  emberinternalsViewsLibMixinsChildViewsSupport
-);
-
 import * as emberinternalsViewsLibMixinsClassNamesSupport from '@ember/-internals/views/lib/mixins/class_names_support';
 d(
   '@ember/-internals/views/lib/mixins/class_names_support',

package.json

@@ -215,7 +215,6 @@
       "@ember/-internals/views/lib/compat/fallback-view-registry.js": "ember-source/@ember/-internals/views/lib/compat/fallback-view-registry.js",
       "@ember/-internals/views/lib/component_lookup.js": "ember-source/@ember/-internals/views/lib/component_lookup.js",
       "@ember/-internals/views/lib/mixins/action_support.js": "ember-source/@ember/-internals/views/lib/mixins/action_support.js",
-      "@ember/-internals/views/lib/mixins/child_views_support.js": "ember-source/@ember/-internals/views/lib/mixins/child_views_support.js",
       "@ember/-internals/views/lib/mixins/class_names_support.js": "ember-source/@ember/-internals/views/lib/mixins/class_names_support.js",
       "@ember/-internals/views/lib/mixins/view_state_support.js": "ember-source/@ember/-internals/views/lib/mixins/view_state_support.js",
       "@ember/-internals/views/lib/mixins/view_support.js": "ember-source/@ember/-internals/views/lib/mixins/view_support.js",

packages/@ember/-internals/glimmer/lib/component.ts

@@ -1,13 +1,15 @@
-import { get, PROPERTY_DID_CHANGE } from '@ember/-internals/metal';
+import type { View } from '@ember/-internals/glimmer/lib/renderer';
+import { get, nativeDescDecorator, PROPERTY_DID_CHANGE } from '@ember/-internals/metal';
 import type { PropertyDidChange } from '@ember/-internals/metal/lib/property_events';
 import { getOwner } from '@ember/-internals/owner';
 import { TargetActionSupport } from '@ember/-internals/runtime';
 import {
   ActionSupport,
-  ChildViewsSupport,
+  addChildView,
   ClassNamesSupport,
   CoreView,
   EventDispatcher,
+  getChildViews,
   getViewElement,
   ViewMixin,
   ViewStateSupport,
@@ -775,7 +777,6 @@ declare const SIGNATURE: unique symbol;
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 interface Component<S = unknown>
   extends CoreView,
-    ChildViewsSupport,
     ViewStateSupport,
     ClassNamesSupport,
     TargetActionSupport,
@@ -785,7 +786,6 @@ interface Component<S = unknown>
 
 class Component<S = unknown>
   extends CoreView.extend(
-    ChildViewsSupport,
     ViewStateSupport,
     ClassNamesSupport,
     TargetActionSupport,
@@ -1118,6 +1118,27 @@ class Component<S = unknown>
     */
   declare ariaRole?: string;
 
+  /**
+    Array of child views. You should never edit this array directly.
+
+    @property childViews
+    @type Array
+    @default []
+    @private
+  */
+  // @ts-expect-error TODO: Fix these types
+  @nativeDescDecorator({
+    configurable: false,
+    enumerable: false,
+  })
+  get childViews() {
+    return getChildViews(this);
+  }
+
+  appendChild(view: View) {
+    addChildView(this, view);
+  }
+
   static isComponentFactory = true;
 
   static toString() {

packages/@ember/-internals/views/index.ts

@@ -19,7 +19,6 @@ export { default as EventDispatcher } from './lib/system/event_dispatcher';
 export { default as ComponentLookup } from './lib/component_lookup';
 export { default as CoreView } from './lib/views/core_view';
 export { default as ClassNamesSupport } from './lib/mixins/class_names_support';
-export { default as ChildViewsSupport } from './lib/mixins/child_views_support';
 export { default as ViewStateSupport } from './lib/mixins/view_state_support';
 export { default as ViewMixin } from './lib/mixins/view_support';
 export { default as ActionSupport } from './lib/mixins/action_support';