Remove property change methods from EmberObject

Author: wagenet

packages/@ember/object/index.ts

@@ -4,9 +4,6 @@ import {
   isElementDescriptor,
   setClassicDecorator,
   hasListeners,
-  beginPropertyChanges,
-  notifyPropertyChange,
-  endPropertyChanges,
   addObserver,
   removeObserver,
   get,
@@ -43,65 +40,6 @@ type ObserverMethod<Target, Sender> =
   @public
 */
 class EmberObject extends CoreObject {
-  /**
-    Begins a grouping of property changes.
-
-    You can use this method to group property changes so that notifications
-    will not be sent until the changes are finished. If you plan to make a
-    large number of changes to an object at one time, you should call this
-    method at the beginning of the changes to begin deferring change
-    notifications. When you are done making changes, call
-    `endPropertyChanges()` to deliver the deferred change notifications and end
-    deferring.
-
-    @method beginPropertyChanges
-    @return {Observable}
-    @private
-  */
-  beginPropertyChanges() {
-    beginPropertyChanges();
-    return this;
-  }
-
-  /**
-    Ends a grouping of property changes.
-
-    You can use this method to group property changes so that notifications
-    will not be sent until the changes are finished. If you plan to make a
-    large number of changes to an object at one time, you should call
-    `beginPropertyChanges()` at the beginning of the changes to defer change
-    notifications. When you are done making changes, call this method to
-    deliver the deferred change notifications and end deferring.
-
-    @method endPropertyChanges
-    @return {Observable}
-    @private
-  */
-  endPropertyChanges() {
-    endPropertyChanges();
-    return this;
-  }
-  /**
-    Convenience method to call `propertyWillChange` and `propertyDidChange` in
-    succession.
-
-    Notify the observer system that a property has just changed.
-
-    Sometimes you need to change a value directly or indirectly without
-    actually calling `get()` or `set()` on it. In this case, you can use this
-    method instead. Calling this method will notify all observers that the
-    property has potentially changed value.
-
-    @method notifyPropertyChange
-    @param {String} keyName The property key to be notified about.
-    @return {Observable}
-    @public
-  */
-  notifyPropertyChange(keyName: string) {
-    notifyPropertyChange(this, keyName);
-    return this;
-  }
-
   /**
     Adds an observer on a property.
 

packages/@ember/object/type-tests/ember-object.test.ts

@@ -51,8 +51,6 @@ expectTypeOf(p.toggleProperty('age')).toEqualTypeOf<boolean>();
 
 expectTypeOf(p.cacheFor('age')).toEqualTypeOf<unknown>();
 
-expectTypeOf(p.notifyPropertyChange('firstName')).toEqualTypeOf(p);
-
 const p2 = Person.create({ firstName: 'string' });
 expectTypeOf(p2.firstName).toEqualTypeOf<string>();
 

packages/@ember/routing/router.ts

@@ -1,7 +1,7 @@
 import { privatize as P } from '@ember/-internals/container';
 import type { BootEnvironment, OutletState, OutletView } from '@ember/-internals/glimmer';
-import { sendEvent } from '@ember/-internals/metal';
 import { computed, get, set } from '@ember/object';
+import { notifyPropertyChange, sendEvent } from '@ember/-internals/metal';
 import type { default as Owner, FactoryManager } from '@ember/owner';
 import { getOwner } from '@ember/owner';
 import { default as BucketCache } from './lib/cache';
@@ -60,7 +60,7 @@ function defaultDidTransition(this: EmberRouter, infos: InternalRouteInfo<Route>
 
   this._cancelSlowTransitionTimer();
 
-  this.notifyPropertyChange('url');
+  notifyPropertyChange(this, 'url');
   set(this, 'currentState', this.targetState);
 
   if (DEBUG) {