Update call to NewTypedUnmanaged to remove manager

embik · embik · commit 88eb5e520394 · 2025-05-22T19:40:27.000+02:00
Reference: kubernetes-sigs/controller-runtime#3141 On-behalf-of: SAP <marvin.beckers@sap.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
diff --git a/pkg/controller/controller.go b/pkg/controller/controller.go
@@ -85,7 +85,7 @@ func NewUnmanaged(name string, mgr mcmanager.Manager, options Options) (Controll
 //
 // The name must be unique as it is used to identify the controller in metrics and logs.
 func NewTypedUnmanaged[request mcreconcile.ClusterAware[request]](name string, mgr mcmanager.Manager, options controller.TypedOptions[request]) (TypedController[request], error) {
-	c, err := controller.NewTypedUnmanaged[request](name, mgr.GetLocalManager(), options)
+	c, err := controller.NewTypedUnmanaged[request](name, options)
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func NewUnmanaged(name string, mgr mcmanager.Manager, options Options) (Controll`
`85`	`85`	`//`
`86`	`86`	`// The name must be unique as it is used to identify the controller in metrics and logs.`
`87`	`87`	`func NewTypedUnmanaged[request mcreconcile.ClusterAware[request]](name string, mgr mcmanager.Manager, options controller.TypedOptions[request]) (TypedController[request], error) {`
`88`		`- c, err := controller.NewTypedUnmanaged[request](name, mgr.GetLocalManager(), options)`
	`88`	`+ c, err := controller.NewTypedUnmanaged[request](name, options)`
`89`	`89`	`if err != nil {`
`90`	`90`	`return nil, err`
`91`	`91`	`}`