Merge pull request #340 from embroider-build/nvp/fix-tsconfig

Move off @tsconfig/ember

Author: NullVoxPopuli

files/__addonLocation__/package.json

@@ -39,14 +39,14 @@
     "@babel/core": "^7.25.2",
     <% if (typescript) { %>"@babel/plugin-transform-typescript": "^7.25.2",<% } %>
     "@babel/eslint-parser": "^7.25.1",
-    "@babel/runtime": "^7.25.6",
+    "@babel/runtime": "^7.25.6",<% if (typescript) { %>
+    "@ember/library-tsconfig": "^1.1.3",<% } %>
     "@eslint/js": "^9.17.0",
     "@embroider/addon-dev": "^7.1.0",<% if (typescript) { %>
     "@glint/core": "^1.4.0",
     "@glint/environment-ember-loose": "^1.4.0",
     "@glint/environment-ember-template-imports": "^1.4.0",
-    "@glint/template": "^1.4.0",
-    "@tsconfig/ember": "^3.0.8",<% } %>
+    "@glint/template": "^1.4.0",<% } %>
     "@rollup/plugin-babel": "^6.0.4",
     "babel-plugin-ember-template-compilation": "^2.2.5",
     "concurrently": "^9.0.1",

files/__addonLocation__/tsconfig.json

@@ -1,32 +1,12 @@
 {
-  "extends": "@tsconfig/ember/tsconfig.json",
+  "extends": "@ember/library-tsconfig",
   "include": ["src/**/*", "unpublished-development-types/**/*"],
   "glint": {
     "environment": ["ember-loose", "ember-template-imports"]
   },
   "compilerOptions": {
     "allowJs": true,
     "declarationDir": "declarations",
-    /**
-      https://www.typescriptlang.org/tsconfig#noEmit
-
-      We want to emit declarations, so this option must be set to `false`.
-      @tsconfig/ember sets this to `true`, which is incompatible with our need to set `emitDeclarationOnly`.
-      @tsconfig/ember is more optimized for apps, which wouldn't emit anything, only type check.
-    */
-    "noEmit": false,
-    /**
-      https://www.typescriptlang.org/tsconfig#emitDeclarationOnly
-      We want to only emit declarations as we use Rollup to emit JavaScript.
-    */
-    "emitDeclarationOnly": true,
-
-    /**
-      https://www.typescriptlang.org/tsconfig#noEmitOnError
-      Do not block emit on TS errors.
-    */
-    "noEmitOnError": false,
-
     /**
       https://www.typescriptlang.org/tsconfig#rootDir
       "Default: The longest common path of all non-declaration input files."
@@ -38,15 +18,6 @@
       imports to files on disk
     */
     "rootDir": "./src",
-
-    /**
-      https://www.typescriptlang.org/tsconfig#allowImportingTsExtensions
-
-      We want our tooling to know how to resolve our custom files so the appropriate plugins
-      can do the proper transformations on those files.
-    */
-    "allowImportingTsExtensions": true,
-
     "types": ["ember-source/types"]
   }
 }

index.js

@@ -177,7 +177,7 @@ module.exports = {
     await appBlueprint.install(appOptions);
 
     await Promise.all([
-      this.updateTestAppPackageJson(path.join(testAppPath, 'package.json'), isPnpm(options)),
+      this.updateTestAppPackageJson(path.join(testAppPath, 'package.json'), options),
       this.overrideTestAppFiles(testAppPath, path.join(options.target, 'test-app-overrides')),
     ]);
 
@@ -198,7 +198,8 @@ module.exports = {
     }
   },
 
-  async updateTestAppPackageJson(packageJsonPath, useWorkspaceProtocol) {
+  async updateTestAppPackageJson(packageJsonPath, options) {
+    const useWorkspaceProtocol = isPnpm(options);
     const pkg = await fs.readJSON(packageJsonPath);
     const additions = require('./additional-test-app-package.json');