[type=module] Quest Issue

[NullVoxPopuli]

TypeScript

• [Bug] Types cannot be found when using type=module, moduleResolution=node16 emberjs/ember.js#20621
  ember-source must become a type=module package for consumers to be able to use Node16

For Libraries

• importSync breaks the builds of apps consuming type=module packages #1672
• type=module packages are not translated correctly if they are v2 addons #1674
• [type=module] _ember_component_template_only is not a function #1774

Notes

• keywords' ember-addon is required
• addon shim required for "app-js"

For Apps

• top-level-await causes component loading to break #1678

Reproductions / Test Cases

https://github.com/NullVoxPopuli/embroider-type-module-testing

• library with no imports
  • ✅ ember-auto-import
  • ✅ embroider 3
  • embroider 4
• library that imports from ember-source meta package via @ember/* imports
  • ✅ ember-auto-import
  • ✅ embroider 3
  • embroider 4
• library that imports from @glimmer/tracking (and @glimmer/component (and @ember/modifier))
  • 🚫 ember-auto-import
  • 🚫 embroider 3
  • embroider 4
• library that uses embroider macros' importSync
  • 🚫 ember-auto-import
  • 🚫 embroider 3
  • embroider 4

---

Key (because qubit checkboxing)

• Not in the repro repo monorepo of repos
• Example is in the repro repo monorepo of repos
• ✅ "type": "module" works as expected
• 🚫 "type": "module" does not work and errors.

---

For erroring on the @glimmer/* case, I have a strong hunch it's also macros related

• https://github.com/glimmerjs/glimmer.js/blob/v1.1.2/packages/%40glimmer/component/addon/-private/ember-component-manager.ts#L7C1-L7C51
  • we don't need to be using ember-compatibility-helpers at all
    • doubly so if glimmer.js (or at least @glimmer/component) is brought in to the ember.js repo

For @embroider/macros related issues, there is already a failing test PR here:

• Test v2 addon as a type=module package #1572