Skip to content

Commit b5df603

Browse files
committed
Declutter: Remove dead code and comments
1 parent 405b315 commit b5df603

File tree

4 files changed

+11
-43
lines changed

4 files changed

+11
-43
lines changed

app/assets/stylesheets/global.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,3 @@ a {
2222
color: $DJSsunshine;
2323
}
2424
}
25-
26-
//ul {
27-
// list-style: none;
28-
//}
29-
////let screenreaders know there is a list, to fix list style none
30-
//ul li::before {
31-
// content: "\200B";
32-
//}

app/assets/stylesheets/home.scss

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -122,15 +122,4 @@ hr.separator-line {
122122

123123
ul {
124124
list-style: outside "\2043"+" ";
125-
//list-style: none;
126-
}
127-
//ul li::before {
128-
// content: "\2043"; //flat streepje
129-
// color: $DJSsunshine;
130-
// font-weight: bold;
131-
// display: inline-block;
132-
// width: 1em;
133-
// margin-left: -1em;
134-
//}
135-
//
136-
125+
}

app/assets/stylesheets/navbar.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
/*
32
header |flex|
43
- logo
@@ -8,8 +7,6 @@ header |flex|
87

98
header {
109
display: flex;
11-
/*justify-content:space-between; << option 1*/
12-
/*option 2*/
1310
justify-content: flex-end;
1411
align-items: center;
1512

@@ -19,9 +16,6 @@ header {
1916
}
2017

2118
.logo {
22-
/* option 2*: push the logo to the left
23-
in combination justify flex-end/
24-
*/
2519
margin-right: auto;
2620
}
2721

app/views/pages/home.html.erb

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@
6767
This course is not for you if:
6868
<ul>
6969
<li>
70-
You know exactly what you're doing and why re: JavaScript in your Rails app
70+
You know exactly what you're doing and why with regard to JavaScript in your Rails app
7171
</li>
7272
<li>
73-
You are looking for the next course: how to refactor JavaScript files into independent components (this will be a follow up course)
73+
You are looking for the next course: how to refactor JavaScript files into independent components (we are working on a follow up course, see ->)
7474
</li>
7575
<li> </li>
7676
</ul>
@@ -81,7 +81,6 @@
8181
<div class="hero-txt">
8282
<div class="hero-over-title"> How to write and maintain</div>
8383
<div class="hero-title">Clean JavaScript Code in your Rails App</div>
84-
<!-- <hr class="separator-line">-->
8584
<div class="hero-payoff">An online course about writing, organising and re-using JavaScript code for Ruby on Rails
8685
developers
8786
</div>
@@ -150,20 +149,14 @@
150149
</section>
151150

152151
<section>
153-
<div id="aboutus">
154-
155-
<div class="card-text">
156-
Maud about DJ: "I always wondered why DJ loved JavaScript so much. I know he loved Ruby, and I didn't understand how one can love Ruby and JavaScript at the same time.
157-
When I showed him a piece of my JavaScript in Rails code, and I started refactoring according to his opinions, I finally started to see
158-
what JavaScript <em>could</em> be - but almost never is. I admire his ability to play with the differences between the languages. And it's good fun to work with him."
159-
DJ about Maud:
160-
</div>
161-
</div> <!--end cards grid-->
162-
</section>
163-
164-
<section>
165-
<div class="cards">
166-
<div class="card" id="aboutus">Nice blablabla about us</div>
152+
<div id="aboutus">
153+
<div class="card-text">
154+
Maud about DJ: "I always wondered why DJ loved JavaScript so much. I know he loved Ruby, and I didn't understand how one can love Ruby and JavaScript at the same time.
155+
When I showed him a piece of my JavaScript in Rails code, and I started refactoring according to his opinions, I finally started to see
156+
what JavaScript <em>could</em> be - but almost never is. I admire his ability to play with the differences between the languages. And it's good fun to work with him."
157+
DJ about Maud:
158+
</div>
167159
</div>
168160
</section>
169161

162+

0 commit comments

Comments
 (0)