requests: add explicit_bucket_boundaries_advisory support for duration metrics

Signed-off-by: emdneto <[email protected]>

Author: emdneto

instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py

@@ -87,6 +87,7 @@ def response_hook(span, request_obj, response):
 from requests.structures import CaseInsensitiveDict
 
 from opentelemetry.instrumentation._semconv import (
+    _DURATION_HISTOGRAM_NEW_EXPLICIT_BOUNDS,
     _client_duration_attrs_new,
     _client_duration_attrs_old,
     _filter_semconv_duration_attrs,
@@ -445,6 +446,7 @@ def _instrument(self, **kwargs: Any):
                 name=HTTP_CLIENT_REQUEST_DURATION,
                 unit="s",
                 description="Duration of HTTP client requests.",
+                explicit_bucket_boundaries_advisory=_DURATION_HISTOGRAM_NEW_EXPLICIT_BOUNDS,
             )
         _instrument(
             tracer,

instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py

@@ -23,6 +23,8 @@
 import opentelemetry.instrumentation.requests
 from opentelemetry import trace
 from opentelemetry.instrumentation._semconv import (
+    _DURATION_HISTOGRAM_NEW_EXPLICIT_BOUNDS,
+    _DURATION_HISTOGRAM_OLD_EXPLICIT_BOUNDS,
     OTEL_SEMCONV_STABILITY_OPT_IN,
     _OpenTelemetrySemanticConventionStability,
 )
@@ -762,6 +764,10 @@ def test_basic_metric_success(self):
                         "measures the duration of the outbound HTTP request",
                     )
                     for data_point in metric.data.data_points:
+                        self.assertEqual(
+                            data_point.explicit_bounds,
+                            _DURATION_HISTOGRAM_OLD_EXPLICIT_BOUNDS,
+                        )
                         self.assertDictEqual(
                             expected_attributes, dict(data_point.attributes)
                         )
@@ -788,6 +794,10 @@ def test_basic_metric_new_semconv(self):
                         metric.description, "Duration of HTTP client requests."
                     )
                     for data_point in metric.data.data_points:
+                        self.assertEqual(
+                            data_point.explicit_bounds,
+                            _DURATION_HISTOGRAM_NEW_EXPLICIT_BOUNDS,
+                        )
                         self.assertDictEqual(
                             expected_attributes, dict(data_point.attributes)
                         )

opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py

@@ -47,6 +47,43 @@
 from opentelemetry.semconv.trace import SpanAttributes
 from opentelemetry.trace.status import Status, StatusCode
 
+# Values defined in milliseconds
+_DURATION_HISTOGRAM_OLD_EXPLICIT_BOUNDS = (
+    0.0,
+    5.0,
+    10.0,
+    25.0,
+    50.0,
+    75.0,
+    100.0,
+    250.0,
+    500.0,
+    750.0,
+    1000.0,
+    2500.0,
+    5000.0,
+    7500.0,
+    10000.0,
+)
+
+# Values defined in seconds
+_DURATION_HISTOGRAM_NEW_EXPLICIT_BOUNDS = (
+    0.005,
+    0.01,
+    0.025,
+    0.05,
+    0.075,
+    0.1,
+    0.25,
+    0.5,
+    0.75,
+    1,
+    2.5,
+    5,
+    7.5,
+    10,
+)
+
 # These lists represent attributes for metrics that are currently supported
 
 _client_duration_attrs_old = [