Skip to content

Commit fd169a7

Browse files
kjagielloxrmxemdnetoocelotl
authored
Fix the py.typed marker file usage (open-telemetry#4172)
* Fix the py.typed marker file usage As defined in PEP 561, the py.typed marker files for namespace packages should be placed "in the submodules of the namespace". In commit 732ea8a, the markers were added to the subpackage roots, which serves no purpose. This changeset addresses all marker-related issues in this repository. A summary of the changes: - Removed the unnecessary py.typed markers from the subpackage roots. - Added the missing marker to the prometheus exporter. Fixes open-telemetry#4113. - Added the missing marker to opentelemetry._events. - Removed the accidentally reintroduced jaeger exporters, which were originally removed in commit 1625b35. * Add missing py.typed * Add pyright and fix the reported issues * Update the generated workflow --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Emídio Neto <[email protected]> Co-authored-by: Diego Hurtado <[email protected]>
1 parent cafd7f2 commit fd169a7

File tree

33 files changed

+46
-0
lines changed

33 files changed

+46
-0
lines changed

.github/workflows/misc_0.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,24 @@ jobs:
8888
- name: Run tests
8989
run: tox -e mypyinstalled
9090

91+
pyright:
92+
name: pyright
93+
runs-on: ubuntu-latest
94+
steps:
95+
- name: Checkout repo @ SHA - ${{ github.sha }}
96+
uses: actions/checkout@v4
97+
98+
- name: Set up Python 3.10
99+
uses: actions/setup-python@v5
100+
with:
101+
python-version: "3.10"
102+
103+
- name: Install tox
104+
run: pip install tox
105+
106+
- name: Run tests
107+
run: tox -e pyright
108+
91109
docs:
92110
name: docs
93111
runs-on: ubuntu-latest

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10+
- Removed superfluous py.typed markers and added them where they were missing
11+
([#4172](https://github.com/open-telemetry/opentelemetry-python/pull/4172))
1012
- Include metric info in encoding exceptions
1113
([#4154](https://github.com/open-telemetry/opentelemetry-python/pull/4154))
1214
- sdk: Add support for log formatting

exporter/opentelemetry-exporter-otlp-proto-http/py.typed

Whitespace-only changes.

exporter/opentelemetry-exporter-otlp/py.typed

Whitespace-only changes.

exporter/opentelemetry-exporter-prometheus/py.typed

Whitespace-only changes.

exporter/opentelemetry-exporter-zipkin-json/py.typed

Whitespace-only changes.

exporter/opentelemetry-exporter-zipkin-proto-http/py.typed

Whitespace-only changes.

exporter/opentelemetry-exporter-zipkin/py.typed

Whitespace-only changes.

opentelemetry-api/py.typed

Whitespace-only changes.

0 commit comments

Comments
 (0)