Use EqualFold to compare case insensitively

moredure · emersion · commit cc994104dd86 · 2022-04-09T18:57:59.000+02:00
diff --git a/message.go b/message.go
@@ -61,13 +61,12 @@ const (
 // If the flag is defined in RFC 3501, it returns the flag with the case of the
 // RFC. Otherwise, it returns the lowercase version of the flag.
 func CanonicalFlag(flag string) string {
-	flag = strings.ToLower(flag)
 	for _, f := range flags {
-		if strings.ToLower(f) == flag {
+		if strings.EqualFold(f, flag) {
 			return f
 		}
 	}
-	return flag
+	return strings.ToLower(flag)
 }
 
 func ParseParamList(fields []interface{}) (map[string]string, error) {

Original file line number	Diff line number	Diff line change
`@@ -61,13 +61,12 @@ const (`
`61`	`61`	`// If the flag is defined in RFC 3501, it returns the flag with the case of the`
`62`	`62`	`// RFC. Otherwise, it returns the lowercase version of the flag.`
`63`	`63`	`func CanonicalFlag(flag string) string {`
`64`		`- flag = strings.ToLower(flag)`
`65`	`64`	`for _, f := range flags {`
`66`		`- if strings.ToLower(f) == flag {`
	`65`	`+ if strings.EqualFold(f, flag) {`
`67`	`66`	`return f`
`68`	`67`	`}`
`69`	`68`	`}`
`70`		`- return flag`
	`69`	`+ return strings.ToLower(flag)`
`71`	`70`	`}`
`72`	`71`
`73`	`72`	`func ParseParamList(fields []interface{}) (map[string]string, error) {`