test(task): cover mcp task APIs, lock release, and event listing

Author: emmahyde

tests/test_server.py

@@ -457,3 +457,74 @@ async def test_list_kbs_empty(self, tmp_db):
         app = await create_app(db_path=tmp_db, anthropic_client=mock_client, embeddings=_mock_embedding_engine())
         result = await app.list_knowledge_bases()
         assert "No knowledge bases" in result
+
+
+class TestTaskStateMachineTools:
+    @pytest.mark.asyncio
+    async def test_create_and_get_task(self, tmp_db):
+        mock_client = MagicMock()
+        app = await create_app(db_path=tmp_db, anthropic_client=mock_client, embeddings=_mock_embedding_engine())
+
+        created = json.loads(await app.create_task(title="index docs", owner="agent-1"))
+        assert created["title"] == "index docs"
+        assert created["owner"] == "agent-1"
+        assert created["status"] == "todo"
+
+        fetched = json.loads(await app.get_task(created["task_id"]))
+        assert fetched["task_id"] == created["task_id"]
+        assert fetched["version"] == 0
+
+    @pytest.mark.asyncio
+    async def test_assign_and_release_task_locks(self, tmp_db):
+        mock_client = MagicMock()
+        app = await create_app(db_path=tmp_db, anthropic_client=mock_client, embeddings=_mock_embedding_engine())
+
+        task_a = json.loads(await app.create_task(title="task-a"))
+        task_b = json.loads(await app.create_task(title="task-b"))
+
+        assigned = json.loads(await app.assign_task_locks(task_a["task_id"], ["src/a.py"]))
+        assert assigned["count"] == 1
+
+        released = json.loads(await app.release_task_locks(task_a["task_id"]))
+        assert released["released"] == 1
+
+        assigned_b = json.loads(await app.assign_task_locks(task_b["task_id"], ["src/a.py"]))
+        assert assigned_b["count"] == 1
+
+    @pytest.mark.asyncio
+    async def test_transition_task(self, tmp_db):
+        mock_client = MagicMock()
+        app = await create_app(db_path=tmp_db, anthropic_client=mock_client, embeddings=_mock_embedding_engine())
+
+        created = json.loads(await app.create_task(title="transition"))
+        transitioned = json.loads(
+            await app.transition_task(
+                task_id=created["task_id"],
+                from_state="todo",
+                to_state="in_progress",
+                actor="orchestrator",
+                expected_version=0,
+            )
+        )
+        assert transitioned["task"]["status"] == "in_progress"
+        assert transitioned["task"]["version"] == 1
+
+    @pytest.mark.asyncio
+    async def test_append_and_list_task_events(self, tmp_db):
+        mock_client = MagicMock()
+        app = await create_app(db_path=tmp_db, anthropic_client=mock_client, embeddings=_mock_embedding_engine())
+
+        created = json.loads(await app.create_task(title="events"))
+        event = json.loads(
+            await app.append_task_event(
+                task_id=created["task_id"],
+                event_type="worklog",
+                actor="agent-1",
+                payload_json=json.dumps({"action": "start"}),
+            )
+        )
+        assert event["event_type"] == "worklog"
+
+        events = json.loads(await app.list_task_events(task_id=created["task_id"], limit=10))
+        assert len(events) >= 1
+        assert events[0]["task_id"] == created["task_id"]

tests/test_task_store.py

@@ -41,6 +41,34 @@ async def test_lock_conflict_enforced_by_db(self, tmp_db):
         with pytest.raises(LockConflict):
             await task_store.assign_locks(t2.task_id, ["src/a.py"])
 
+    async def test_lock_prefix_conflict_enforced_by_db(self, tmp_db):
+        store = InsightStore(tmp_db)
+        await store.initialize()
+        task_store = TaskStore(tmp_db)
+
+        t1 = await task_store.create_task("task 1")
+        t2 = await task_store.create_task("task 2")
+
+        await task_store.assign_locks(t1.task_id, ["src"])
+
+        with pytest.raises(LockConflict):
+            await task_store.assign_locks(t2.task_id, ["src/a.py"])
+
+    async def test_release_locks_allows_reacquire(self, tmp_db):
+        store = InsightStore(tmp_db)
+        await store.initialize()
+        task_store = TaskStore(tmp_db)
+
+        t1 = await task_store.create_task("task 1")
+        t2 = await task_store.create_task("task 2")
+
+        await task_store.assign_locks(t1.task_id, ["src/a.py"])
+        released = await task_store.release_locks(t1.task_id)
+        assert released == 1
+
+        lock_ids = await task_store.assign_locks(t2.task_id, ["src/a.py"])
+        assert len(lock_ids) == 1
+
     async def test_invalid_transition_rejected(self, tmp_db):
         store = InsightStore(tmp_db)
         await store.initialize()
@@ -146,6 +174,18 @@ async def test_task_events_append_only(self, tmp_db):
                 await db.execute("UPDATE task_events SET event_type = 'changed' WHERE id = ?", (event.id,))
                 await db.commit()
 
+    async def test_list_events_returns_latest_first(self, tmp_db):
+        store = InsightStore(tmp_db)
+        await store.initialize()
+        task_store = TaskStore(tmp_db)
+
+        task = await task_store.create_task("events")
+        await task_store.append_event(task.task_id, "first", "operator", {"i": 1})
+        await task_store.append_event(task.task_id, "second", "operator", {"i": 2})
+
+        events = await task_store.list_events(task.task_id, limit=2)
+        assert [event.event_type for event in events] == ["second", "first"]
+
     async def test_migration_created_task_tables(self, tmp_db):
         store = InsightStore(tmp_db)
         await store.initialize()
@@ -159,3 +199,6 @@ async def test_migration_created_task_tables(self, tmp_db):
                 "SELECT name FROM sqlite_master WHERE type='index' AND name='ux_task_locks_active_resource'"
             )
             assert await cursor.fetchone() is not None
+            cursor = await db.execute("SELECT MAX(version) FROM schema_versions")
+            row = await cursor.fetchone()
+            assert row is not None and row[0] >= 7