Skip to content

Fails with "Typethis.manufacturer?.toLowerCase is not a function" #1900

@statyk

Description

@statyk

Paste the command

~/igir copy zip test --dat /Volumes/media/games/arcade/FBANEO/FinalBurn\ Neo\ (ClrMame\ Pro\ XML,\ Arcade\ only).dat --input /Volumes/media/games/arcade/FBANEO/roms/ --output fbneo-fullnonmerged-78dcc8a/roms/ --merge-roms fullnonmerged --only-retail

Describe the bug

When using the --only-retail option, this error occurs after parsing the DAT and before writing any output. If I leave off that option, the error still occurs but only at the end of the process after roms have been written to the new location.

shawn@Shawns-Mac-mini:ext $ ~/igir copy zip test --dat /Volumes/media/games/arcade/FBANEO/FinalBurn\ Neo\ (ClrMame\ Pro\ XML,\ Arcade\ only).dat --input /Volumes/media/games/arcade/FBANEO/roms/ --output fbneo-fullnonmerged-78dcc8a/roms/ --merge-roms fullnonmerged --only-retail

@@@@@@ @@@@@@ @@@@@@ @@@@@@@@
@@ @@ @@ @@ @@ @@
@@ @@ @@ @@ @@ @@ ROM collection manager
@@@@@@ @@ @@@@@@ @@@@@@@@@ https://igir.io/
@@@ @@@@ @@@
@@ @@ @@ @@ @@ @@ v4.2.0
@@ @@ @@ @@ @@ @@
@@ @@@@@@@@@@@@ @@ @@ @@

✓ Scanning for DATs » 1 DAT found
✓ Scanning for ROMs » 74,235 files found

∆ FinalBurn Neo - Arcade Games
■■■■■■■■■■■■■■■■■■■■■■■■■■■■ 0/8,041
ERROR: Typethis.manufacturer?.toLowerCase is not a function
ERROR: at _Game.isBootleg (file:///private/var/folders/yn/jlwxryrj1ds7jpvw931jk1jm0000gn/T/caxa/applications/igir/sm0kdh8bng/0/dist/bundle.js:3753:31)
ERROR: at _Game.isRetail (file:///private/var/folders/yn/jlwxryrj1ds7jpvw931jk1jm0000gn/T/caxa/applications/igir/sm0kdh8bng/0/dist/bundle.js:3897:32)
ERROR: at _DATStatus.pushValueIntoMap (file:///private/var/folders/yn/jlwxryrj1ds7jpvw931jk1jm0000gn/T/caxa/applications/igir/sm0kdh8bng/0/dist/bundle.js:16431:14)
ERROR: at file:///private/var/folders/yn/jlwxryrj1ds7jpvw931jk1jm0000gn/T/caxa/applications/igir/sm0kdh8bng/0/dist/bundle.js:16405:18
ERROR: at Array.forEach ()
ERROR: at new _DATStatus (file:///private/var/folders/yn/jlwxryrj1ds7jpvw931jk1jm0000gn/T/caxa/applications/igir/sm0kdh8bng/0/dist/bundle.js:16404:20)
ERROR: at _StatusGenerator.generate (file:///private/var/folders/yn/jlwxryrj1ds7jpvw931jk1jm0000gn/T/caxa/applications/igir/sm0kdh8bng/0/dist/bundle.js:17295:23)
ERROR: at file:///private/var/folders/yn/jlwxryrj1ds7jpvw931jk1jm0000gn/T/caxa/applications/igir/sm0kdh8bng/0/dist/bundle.js:18354:58

Expected behavior

Program does not error out and applies the --only-retail filter.

Debug logs

igir_debug.txt

DAT(s) used

https://archive.org/download/FBANEO/FinalBurn%20Neo%20%28ClrMame%20Pro%20XML%2C%20Arcade%20only%29.dat

igir version

v4.2.0

Node.js version

N/A

Operating system

MacOS Version 15.6.1

Additional context

This example is from MacOS Sequoia, but I have reproduced the same error on Linux ARM (Raspberry Pi OS Bookworm) and Linux x86 Debian (also Bookworm).

Metadata

Metadata

Assignees

Labels

potential-bugA potential issue that needs confirmation and/or triage

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions