Removed auto-prefixing for widely available features (#3296)

* Drop prefixer

* changeset

* Revert "Drop prefixer"

This reverts commit 3759507.

* prefix what's not widely-avaialble

* Remove moz and ms prefixes for user-select, hyphens, text-size-adjust

* Remove zoom- and grab prefixing in cursor property

* Remove unused moz and mz prefix imports

* Remove image-set prefixing in cursor (image-set will be widely available so soon, just prefixing image-set for cursor is weird and cursor is such a small progressive enhancement thing anyway that if it doesn't work in older browsers, it's fine)

* update snapshots

* update changeset

---------

Co-authored-by: Emma Hamilton <[email protected]>

Author: Andarist

.changeset/late-horses-join.md

@@ -0,0 +1,8 @@
+---
+'@emotion/styled': major
+'@emotion/cache': major
+'@emotion/react': major
+'@emotion/css': major
+---
+
+Removed auto-prefixing for widely available features.

packages/cache/__tests__/__snapshots__/index.js.snap

@@ -2,9 +2,6 @@
 
 exports[`should accept container option 1`] = `
 .emotion-0 {
-  display: -webkit-box;
-  display: -webkit-flex;
-  display: -ms-flexbox;
   display: flex;
   color: blue;
 }
@@ -22,7 +19,7 @@ exports[`should accept container option 1`] = `
       data-s=""
     >
       
-      .emotion-0{display:-webkit-box;display:-webkit-flex;display:-ms-flexbox;display:flex;color:blue;}
+      .emotion-0{display:flex;color:blue;}
     </style>
   </div>
   <div>
@@ -45,7 +42,7 @@ exports[`should accept insertionPoint option 1`] = `
     data-s=""
   >
     
-    .test-insertion-point-83n355{display:-webkit-box;display:-webkit-flex;display:-ms-flexbox;display:flex;color:blue;}
+    .test-insertion-point-83n355{display:flex;color:blue;}
   </style>
   
     

packages/cache/src/prefixer.ts

@@ -1,46 +1,16 @@
 /* eslint-disable no-fallthrough */
 /* eslint-disable eqeqeq */
-import {
-  charat,
-  combine,
-  copy,
-  DECLARATION,
-  hash,
-  indexof,
-  KEYFRAMES,
-  match,
-  MOZ,
-  MS,
-  replace,
-  RULESET,
-  serialize,
-  strlen,
-  WEBKIT,
-  Element,
-  Middleware
-} from 'stylis'
+import { DECLARATION, Element, hash, WEBKIT } from 'stylis'
 
-// this is a copy of [email protected] prefixer, the latter version introduced grid prefixing which we don't want
+// this is a slice of [email protected] prefixer, the latter version introduced grid prefixing which we don't want
+// this version only includes css properties that are not widely available according to https://web-platform-dx.github.io/web-features/
 
 function prefix(value: string, length: number): string {
   switch (hash(value, length)) {
     // color-adjust
     case 5103:
       return WEBKIT + 'print-' + value + value
-    // animation, animation-(delay|direction|duration|fill-mode|iteration-count|name|play-state|timing-function)
-    case 5737:
-    case 4201:
-    case 3177:
-    case 3433:
-    case 1641:
-    case 4457:
-    case 2921:
-    // text-decoration, filter, clip-path, backface-visibility, column, box-decoration-break
-    case 5572:
-    case 6356:
-    case 5844:
-    case 3191:
-    case 6645:
+    // box-decoration-break
     case 3005:
     // mask, mask-image, mask-(mode|clip|size), mask-(repeat|origin), mask-position, mask-composite,
     case 6391:
@@ -49,299 +19,18 @@ function prefix(value: string, length: number): string {
     case 6135:
     case 4599:
     case 4855:
-    // background-clip, columns, column-(count|fill|gap|rule|rule-color|rule-style|rule-width|span|width)
-    case 4215:
-    case 6389:
-    case 5109:
-    case 5365:
-    case 5621:
-    case 3829:
-      return WEBKIT + value + value
-    // appearance, user-select, transform, hyphens, text-size-adjust
-    case 5349:
+    // user-select, hyphens, text-size-adjust
     case 4246:
-    case 4810:
     case 6968:
     case 2756:
-      return WEBKIT + value + MOZ + value + MS + value + value
-    // flex, flex-direction
-    case 6828:
-    case 4268:
-      return WEBKIT + value + MS + value + value
-    // order
-    case 6165:
-      return WEBKIT + value + MS + 'flex-' + value + value
-    // align-items
-    case 5187:
-      return (
-        WEBKIT +
-        value +
-        replace(
-          value,
-          /(\w+).+(:[^]+)/,
-          WEBKIT + 'box-$1$2' + MS + 'flex-$1$2'
-        ) +
-        value
-      )
-    // align-self
-    case 5443:
-      return (
-        WEBKIT +
-        value +
-        MS +
-        'flex-item-' +
-        replace(value, /flex-|-self/, '') +
-        value
-      )
-    // align-content
-    case 4675:
-      return (
-        WEBKIT +
-        value +
-        MS +
-        'flex-line-pack' +
-        replace(value, /align-content|flex-|-self/, '') +
-        value
-      )
-    // flex-shrink
-    case 5548:
-      return WEBKIT + value + MS + replace(value, 'shrink', 'negative') + value
-    // flex-basis
-    case 5292:
-      return (
-        WEBKIT + value + MS + replace(value, 'basis', 'preferred-size') + value
-      )
-    // flex-grow
-    case 6060:
-      return (
-        WEBKIT +
-        'box-' +
-        replace(value, '-grow', '') +
-        WEBKIT +
-        value +
-        MS +
-        replace(value, 'grow', 'positive') +
-        value
-      )
-    // transition
-    case 4554:
-      return (
-        WEBKIT +
-        replace(value, /([^-])(transform)/g, '$1' + WEBKIT + '$2') +
-        value
-      )
-    // cursor
-    case 6187:
-      return (
-        replace(
-          replace(
-            replace(value, /(zoom-|grab)/, WEBKIT + '$1'),
-            /(image-set)/,
-            WEBKIT + '$1'
-          ),
-          value,
-          ''
-        ) + value
-      )
-    // background, background-image
-    case 5495:
-    case 3959:
-      return replace(value, /(image-set\([^]*)/, WEBKIT + '$1' + '$`$1')
-    // justify-content
-    case 4968:
-      return (
-        replace(
-          replace(
-            value,
-            /(.+:)(flex-)?(.*)/,
-            WEBKIT + 'box-pack:$3' + MS + 'flex-pack:$3'
-          ),
-          /s.+-b[^;]+/,
-          'justify'
-        ) +
-        WEBKIT +
-        value +
-        value
-      )
-    // (margin|padding)-inline-(start|end)
-    case 4095:
-    case 3583:
-    case 4068:
-    case 2532:
-      return replace(value, /(.+)-inline(.+)/, WEBKIT + '$1$2') + value
-    // (min|max)?(width|height|inline-size|block-size)
-    case 8116:
-    case 7059:
-    case 5753:
-    case 5535:
-    case 5445:
-    case 5701:
-    case 4933:
-    case 4677:
-    case 5533:
-    case 5789:
-    case 5021:
-    case 4765:
-      // stretch, max-content, min-content, fill-available
-      if (strlen(value) - 1 - length > 6)
-        switch (charat(value, length + 1)) {
-          // (m)ax-content, (m)in-content
-          case 109:
-            // -
-            if (charat(value, length + 4) !== 45) break
-          // (f)ill-available, (f)it-content
-          case 102:
-            return (
-              replace(
-                value,
-                /(.+:)(.+)-([^]+)/,
-                '$1' +
-                  WEBKIT +
-                  '$2-$3' +
-                  '$1' +
-                  MOZ +
-                  (charat(value, length + 3) == 108 ? '$3' : '$2-$3')
-              ) + value
-            )
-          // (s)tretch
-          case 115:
-            return ~indexof(value, 'stretch')
-              ? prefix(replace(value, 'stretch', 'fill-available'), length) +
-                  value
-              : value
-        }
-      break
-    // position: sticky
-    case 4949:
-      // (s)ticky?
-      if (charat(value, length + 1) !== 115) break
-    // display: (flex|inline-flex)
-    case 6444:
-      switch (
-        charat(value, strlen(value) - 3 - (~indexof(value, '!important') && 10))
-      ) {
-        // stic(k)y
-        case 107:
-          return replace(value, ':', ':' + WEBKIT) + value
-        // (inline-)?fl(e)x
-        case 101:
-          return (
-            replace(
-              value,
-              /(.+:)([^;!]+)(;|!.+)?/,
-              '$1' +
-                WEBKIT +
-                (charat(value, 14) === 45 ? 'inline-' : '') +
-                'box$3' +
-                '$1' +
-                WEBKIT +
-                '$2$3' +
-                '$1' +
-                MS +
-                '$2box$3'
-            ) + value
-          )
-      }
-      break
-    // writing-mode
-    case 5936:
-      switch (charat(value, length + 11)) {
-        // vertical-l(r)
-        case 114:
-          return (
-            WEBKIT +
-            value +
-            MS +
-            replace(value, /[svh]\w+-[tblr]{2}/, 'tb') +
-            value
-          )
-        // vertical-r(l)
-        case 108:
-          return (
-            WEBKIT +
-            value +
-            MS +
-            replace(value, /[svh]\w+-[tblr]{2}/, 'tb-rl') +
-            value
-          )
-        // horizontal(-)tb
-        case 45:
-          return (
-            WEBKIT +
-            value +
-            MS +
-            replace(value, /[svh]\w+-[tblr]{2}/, 'lr') +
-            value
-          )
-      }
-
-      return WEBKIT + value + MS + value + value
+      return WEBKIT + value + value
   }
 
   return value
 }
 
-export let prefixer = (
-  element: Element,
-  index: number,
-  children: Element[],
-  callback: Middleware
-) => {
-  if (element.length > -1)
-    if (!element.return)
-      switch (element.type) {
-        case DECLARATION:
-          element.return = prefix(element.value, element.length)
-          break
-        case KEYFRAMES:
-          return serialize(
-            [
-              copy(element, {
-                value: replace(element.value, '@', '@' + WEBKIT)
-              })
-            ],
-            callback
-          )
-        case RULESET:
-          if (element.length)
-            return combine(element.props as string[], function (value) {
-              switch (match(value, /(::plac\w+|:read-\w+)/)) {
-                // :read-(only|write)
-                case ':read-only':
-                case ':read-write':
-                  return serialize(
-                    [
-                      copy(element, {
-                        props: [replace(value, /:(read-\w+)/, ':' + MOZ + '$1')]
-                      })
-                    ],
-                    callback
-                  )
-                // :placeholder
-                case '::placeholder':
-                  return serialize(
-                    [
-                      copy(element, {
-                        props: [
-                          replace(
-                            value,
-                            /:(plac\w+)/,
-                            ':' + WEBKIT + 'input-$1'
-                          )
-                        ]
-                      }),
-                      copy(element, {
-                        props: [replace(value, /:(plac\w+)/, ':' + MOZ + '$1')]
-                      }),
-                      copy(element, {
-                        props: [replace(value, /:(plac\w+)/, MS + 'input-$1')]
-                      })
-                    ],
-                    callback
-                  )
-              }
-
-              return ''
-            })
-      }
+export let prefixer = (element: Element) => {
+  if (element.length > -1 && !element.return && element.type === DECLARATION) {
+    element.return = prefix(element.value, element.length)
+  }
 }