Skip to content

Commit f984795

Browse files
committed
feat: remove unused errors
1 parent 37a9522 commit f984795

File tree

6 files changed

+6
-44
lines changed

6 files changed

+6
-44
lines changed

src/tgdb/application/horizon/commit_transaction.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ async def __call__(
4343
:raises tgdb.entities.horizon.horizon.NoTransactionError:
4444
:raises tgdb.entities.horizon.horizon.InvalidTransactionStateError:
4545
:raises tgdb.entities.horizon.transaction.ConflictError:
46-
:raises tgdb.entities.horizon.transaction.NonSerializableWriteTransactionError:
47-
""" # noqa: E501
46+
"""
4847

4948
effects = await gather(*map(self._effect, operators))
5049
time = await self.clock

src/tgdb/entities/horizon/horizon.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
Commit,
1010
ConflictError,
1111
IsolationLevel,
12-
NonSerializableWriteTransactionError,
1312
PreparedCommit,
1413
ReadUncommitedTransaction,
1514
SerializableTransaction,
@@ -40,12 +39,7 @@ class HorizonAlwaysWithoutTransactionsError(Exception): ...
4039
class NotMonotonicTimeError(Exception): ...
4140

4241

43-
class InvalidEffectsError(Exception): ...
44-
45-
46-
type HorizonWriteEffect = (
47-
NewTuple | MutatedTuple | DeletedTuple | Claim
48-
)
42+
type HorizonWriteEffect = NewTuple | MutatedTuple | DeletedTuple | Claim
4943

5044

5145
@dataclass
@@ -146,8 +140,7 @@ def commit_transaction(
146140
:raises tgdb.entities.horizon.horizon.NoTransactionError:
147141
:raises tgdb.entities.horizon.horizon.InvalidTransactionStateError:
148142
:raises tgdb.entities.horizon.transaction.ConflictError:
149-
:raises tgdb.entities.horizon.transaction.NonSerializableWriteTransactionError:
150-
""" # noqa: E501
143+
"""
151144

152145
self.move_to_future(time)
153146

@@ -165,7 +158,7 @@ def commit_transaction(
165158
case ReadUncommitedTransaction():
166159
del self._transaction_map(transaction)[xid]
167160
return transaction.commit()
168-
except (ConflictError, NonSerializableWriteTransactionError) as error:
161+
except ConflictError as error:
169162
del self._transaction_map(transaction)[xid]
170163
raise error from error
171164

src/tgdb/entities/horizon/transaction.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ class ConflictError(Exception):
3535
rejected_claims: frozenset[Claim]
3636

3737

38-
@dataclass(frozen=True)
39-
class NonSerializableWriteTransactionError(Exception):
40-
xid: XID
41-
42-
4338
@dataclass(frozen=True)
4439
class Commit:
4540
xid: XID

src/tgdb/presentation/fastapi/horizon/error_handling.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@
55
InvalidTransactionStateError,
66
NoTransactionError,
77
)
8-
from tgdb.entities.horizon.transaction import (
9-
ConflictError,
10-
NonSerializableWriteTransactionError,
11-
)
8+
from tgdb.entities.horizon.transaction import ConflictError
129
from tgdb.presentation.fastapi.horizon.schemas.error import (
1310
InvalidTransactionStateSchema,
1411
NoTransactionSchema,
@@ -40,11 +37,3 @@ def _(_: object, __: object) -> Response:
4037
schema.model_dump(mode="json", by_alias=True),
4138
status_code=status.HTTP_404_NOT_FOUND,
4239
)
43-
44-
@app.exception_handler(NonSerializableWriteTransactionError)
45-
def _(_: object, __: object) -> Response:
46-
schema = InvalidTransactionStateSchema()
47-
return JSONResponse(
48-
schema.model_dump(mode="json", by_alias=True),
49-
status_code=status.HTTP_404_NOT_FOUND,
50-
)

src/tgdb/presentation/fastapi/horizon/routes/commit_transaction.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from tgdb.presentation.fastapi.common.tags import Tag
1212
from tgdb.presentation.fastapi.horizon.schemas.error import (
1313
InvalidTransactionStateSchema,
14-
NonSerializableWriteTransactioneSchema,
1514
NoTransactionSchema,
1615
TransactionConflictSchema,
1716
)
@@ -42,10 +41,7 @@ class CommitTransactionSchema(BaseModel):
4241
status.HTTP_204_NO_CONTENT: {"content": None},
4342
status.HTTP_404_NOT_FOUND: {"model": NoTransactionSchema},
4443
status.HTTP_400_BAD_REQUEST: {
45-
"model": (
46-
InvalidTransactionStateSchema
47-
| NonSerializableWriteTransactioneSchema
48-
)
44+
"model": InvalidTransactionStateSchema
4945
},
5046
status.HTTP_409_CONFLICT: {"model": TransactionConflictSchema},
5147
},

src/tgdb/presentation/fastapi/horizon/schemas/error.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,3 @@ class InvalidTransactionStateSchema(BaseModel):
3636
"""
3737

3838
type: Literal["invalidTransactionState"] = "invalidTransactionState"
39-
40-
41-
class NonSerializableWriteTransactioneSchema(BaseModel):
42-
"""
43-
Transaction write could not be serialized.
44-
"""
45-
46-
type: Literal["nonSerializableWriteTransaction"] = (
47-
"nonSerializableWriteTransaction"
48-
)

0 commit comments

Comments
 (0)