clean up cmake files

Author: emrekovanci

app/CMakeLists.txt

@@ -1,7 +1,4 @@
+# Define executable and its properties
 add_executable(${PROJECT_NAME} App.cpp)
-
-# depends on CoreLibrary
-target_link_libraries(${PROJECT_NAME} PRIVATE CoreLibrary)
-
-# set the output directory for the executable
+target_link_libraries(${PROJECT_NAME} PRIVATE Core)
 set_target_properties(${PROJECT_NAME} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${PROJECT_NAME})

library/CMakeLists.txt

@@ -1,25 +1,20 @@
 set(INCROOT ${PROJECT_SOURCE_DIR}/library/include/Core)
 set(SRCROOT ${PROJECT_SOURCE_DIR}/library/src/Core)
 
-# all header files
+# Define header and source file lists
 set(LIBRARY_HEADERS
     ${INCROOT}/Lib.hpp
 )
 
-# all source files
 set(LIBRARY_SOURCES
     ${SRCROOT}/Lib.cpp
 )
 
-# define library
-add_library(CoreLibrary STATIC ${LIBRARY_HEADERS} ${LIBRARY_SOURCES})
+# Define library and its properties
+add_library(Core STATIC ${LIBRARY_HEADERS} ${LIBRARY_SOURCES})
+target_include_directories(Core PUBLIC ${PROJECT_SOURCE_DIR}/library/include)
+target_compile_features(Core PUBLIC cxx_std_17)
 
-# we need this directory, and users of our library will need it too
-target_include_directories(CoreLibrary PUBLIC ${PROJECT_SOURCE_DIR}/library/include)
-
-# all users of this library will need at least C++17
-target_compile_features(CoreLibrary PUBLIC cxx_std_17)
-
-# IDEs should put the headers and sources in a nice place
+# Group headers and sources for IDE
 source_group(TREE ${INCROOT} PREFIX "Headers" FILES ${LIBRARY_HEADERS})
 source_group(TREE ${SRCROOT} PREFIX "Sources" FILES ${LIBRARY_SOURCES})