clean up cmake files

Author: emrekovanci

CMakeLists.txt

@@ -9,7 +9,7 @@ project(
 )
 
 find_package(glad CONFIG REQUIRED)
-find_package(SFML COMPONENTS system window graphics CONFIG REQUIRED)
+find_package(SFML COMPONENTS window CONFIG REQUIRED)
 find_package(glm CONFIG REQUIRED)
 
 add_subdirectory(library)

app/CMakeLists.txt

@@ -1,15 +1,10 @@
+# Define executable and its properties
 add_executable(${PROJECT_NAME} App.cpp)
-
-# depends on CoreLibrary
-target_link_libraries(${PROJECT_NAME} PRIVATE CoreLibrary)
-
-# depends on SFML
-target_link_libraries(${PROJECT_NAME} PRIVATE sfml-system sfml-window)
-
-# set the output directory for the executable
+target_link_libraries(${PROJECT_NAME} PRIVATE Core)
+target_link_libraries(${PROJECT_NAME} PRIVATE sfml-window)
 set_target_properties(${PROJECT_NAME} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${PROJECT_NAME})
 
-# copy resources directory after build
+# Copy resources directory after build
 add_custom_command(
     TARGET ${PROJECT_NAME} POST_BUILD
     COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_SOURCE_DIR}/resources $<TARGET_FILE_DIR:${PROJECT_NAME}>/resources

library/CMakeLists.txt

@@ -1,35 +1,26 @@
 set(INCROOT ${PROJECT_SOURCE_DIR}/library/include/Core)
 set(SRCROOT ${PROJECT_SOURCE_DIR}/library/src/Core)
 
-# all header files
+# Define header and source file lists
 set(LIBRARY_HEADERS
     ${INCROOT}/Statics.hpp
     ${INCROOT}/Camera.hpp
     ${INCROOT}/Shader.hpp
 )
 
-# all source files
 set(LIBRARY_SOURCES
     ${SRCROOT}/Statics.cpp
     ${SRCROOT}/Camera.cpp
     ${SRCROOT}/Shader.cpp
 )
 
-# define library
-add_library(CoreLibrary STATIC ${LIBRARY_HEADERS} ${LIBRARY_SOURCES})
+# Define library and its properties
+add_library(Core STATIC ${LIBRARY_HEADERS} ${LIBRARY_SOURCES})
+target_include_directories(Core PUBLIC ${PROJECT_SOURCE_DIR}/library/include)
+target_link_libraries(Core PUBLIC glad::glad)
+target_link_libraries(Core PUBLIC glm::glm)
+target_compile_features(Core PUBLIC cxx_std_17)
 
-# we need this directory, and users of our library will need it too
-target_include_directories(CoreLibrary PUBLIC ${PROJECT_SOURCE_DIR}/library/include)
-
-# depends on glad
-target_link_libraries(CoreLibrary PUBLIC glad::glad)
-
-# depends on glm
-target_link_libraries(CoreLibrary PUBLIC glm::glm)
-
-# all users of this library will need at least C++17
-target_compile_features(CoreLibrary PUBLIC cxx_std_17)
-
-# IDEs should put the headers and sources in a nice place
+# Group headers and sources for IDE
 source_group(TREE ${INCROOT} PREFIX "Headers" FILES ${LIBRARY_HEADERS})
 source_group(TREE ${SRCROOT} PREFIX "Sources" FILES ${LIBRARY_SOURCES})