Get rid of additional duration parameter and directly use provided animationDuration

Author: emrepun

SampleSporify/MainTabBarController.swift

@@ -12,8 +12,8 @@ public protocol StickyViewControllerSupporting: UITabBarController {
     var collapsedHeight: CGFloat { get }
     var animationDuration: TimeInterval { get }
     func configureCollapsedTrainingView(withChildViewController childViewController: Expandable)
-    func removeCollapsibleView(withAnimation: Bool, duration: TimeInterval)
-    func collapseCollapsibleVC(duration: TimeInterval)
+    func removeCollapsibleView(animated: Bool)
+    func collapseCollapsibleVC()
 }
 
 public class StickyViewControllerSupportingTabBarController: UITabBarController, StickyViewControllerSupporting {
@@ -46,12 +46,12 @@ public class StickyViewControllerSupportingTabBarController: UITabBarController,
         collapsableVCFlow!.didMove(toParent: self)
     }
 
-    final public func removeCollapsibleView(withAnimation: Bool, duration: TimeInterval) {
+    final public func removeCollapsibleView(animated: Bool) {
         guard let collapsableVCFlow = collapsableVCFlow else {
             return
         }
-        if withAnimation {
-            UIView.animate(withDuration: duration,
+        if animated {
+            UIView.animate(withDuration: animationDuration,
                            animations: {
                             collapsableVCFlow.heightConstraint.constant = 0.0
                             collapsableVCFlow.view.layoutIfNeeded()
@@ -70,7 +70,7 @@ public class StickyViewControllerSupportingTabBarController: UITabBarController,
         }
     }
 
-    final public func collapseCollapsibleVC(duration: TimeInterval) {
+    final public func collapseCollapsibleVC() {
         guard let collapsableVCFlow = collapsableVCFlow else {
             return
         }

SampleSporify/SampleChildViewController.swift

@@ -21,9 +21,9 @@ class SampleChildViewController: UIViewController, Expandable {
     }
 
     @IBAction func shutDownTapped(_ sender: Any) {
-        expander?.removeCollapsibleView(withAnimation: true, duration: 0.50)
+        expander?.removeCollapsibleView(animated: true)
     }
     @IBAction func collapseFromExpandedTapped(_ sender: Any) {
-        expander?.collapseCollapsibleVC(duration: 0.50)
+        expander?.collapseCollapsibleVC()
     }
 }

SampleSporify/ViewController.swift

@@ -11,7 +11,7 @@ import UIKit
 class ViewController: UIViewController {
 
     var tabController: StickyViewControllerSupporting? {
-        if let tabBarController = tabBarController as? StickyViewControllerSupporting {
+        if let tabBarController = tabBarController as? StickyViewControllerSupportingTabBarController {
             return tabBarController
         }
         return nil
@@ -27,7 +27,7 @@ class ViewController: UIViewController {
     }
 
     @IBAction func removerTapped(_ sender: Any) {
-        tabController?.removeCollapsibleView(withAnimation: true, duration: 0.5)
+        tabController?.removeCollapsibleView(animated: true)
     }
 }