Skip to content

Commit 0086c50

Browse files
authored
[embind] Fix closure warning about emval_registeredMethods (#20237)
`emval_registeredMethods` is an object/map, not an array. Closure was rightly complaining about this: ``` /tmp/emscripten_temp_8ico2w6n/test_embind.jso1.js:1191:25: WARNING - [JSC_TYPE_MISMATCH] restricted index type found : string required: number 1191| emval_registeredMethods[signatureName] = returnId; ^^^^^^^^^^^^^ ```
1 parent 594d27d commit 0086c50

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/embind/emval.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ var LibraryEmVal = {
388388
return id;
389389
},
390390

391-
$emval_registeredMethods: [],
391+
$emval_registeredMethods: {},
392392
_emval_get_method_caller__deps: [
393393
'$emval_addMethodCaller', '$emval_lookupTypes',,
394394
'$makeLegalFunctionName', '$emval_registeredMethods',

test/test_core.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7612,6 +7612,7 @@ def test2():
76127612
'flag': (['--bind'],),
76137613
})
76147614
def test_embind(self, args):
7615+
self.maybe_closure()
76157616
create_file('test_embind.cpp', r'''
76167617
#include <stdio.h>
76177618
#include <emscripten/val.h>

0 commit comments

Comments
 (0)