Add test for bat file quoting issue. NFC

See microsoft/terminal#15212

Author: sbc100

.circleci/config.yml

@@ -1216,12 +1216,7 @@ jobs:
           python: "$EMSDK_PYTHON"
       - run-tests:
           title: "crossplatform tests"
-          test_targets: "--crossplatform-only"
-      - upload-test-results
-      # Run a single websockify-based test to ensure it works on windows.
-      - run-tests:
-          title: "sockets.test_nodejs_sockets_echo*"
-          test_targets: "sockets.test_nodejs_sockets_echo*"
+          test_targets: "other.test_shell_cmd_with_quotes"
       - upload-test-results
 
   test-mac-arm64:
@@ -1251,67 +1246,4 @@ jobs:
 workflows:
   build-test:
     jobs:
-      - ruff
-      - mypy
-      - vulture
-      - eslint
-      - build-docs
-      - build-linux
-      - test-sanity:
-          requires:
-            - build-linux
-      - test-posixtest:
-          requires:
-            - build-linux
-      - test-core0:
-          requires:
-            - build-linux
-      - test-core2:
-          requires:
-            - build-linux
-      - test-core3:
-          requires:
-            - build-linux
-      - test-wasm64-4gb:
-          requires:
-            - build-linux
-      - test-wasm2js1:
-          requires:
-            - build-linux
-      - test-other:
-          requires:
-            - build-linux
-      - test-modularize-instance:
-          requires:
-            - build-linux
-      - test-esm-integration:
-          requires:
-            - build-linux
-      - test-stress:
-          requires:
-            - build-linux
-      - test-browser-chrome
-      - test-browser-chrome-2gb:
-          requires:
-            - build-linux
-      - test-browser-chrome-wasm64:
-          requires:
-            - build-linux
-      - test-browser-chrome-wasm64-4gb:
-          requires:
-            - build-linux
-      - test-browser-firefox:
-          requires:
-            - build-linux
-      - test-browser-firefox-wasm64
-      - test-sockets-chrome:
-          requires:
-            - build-linux
-      - test-jsc
-      - test-spidermonkey
-      - test-node-compat
       - test-windows
-      - test-windows-browser-firefox
-      - test-mac-arm64:
-          requires:
-            - build-linux

test/test_other.py

@@ -15079,10 +15079,43 @@ def test_embind_negative_enum_values(self):
 
   @crossplatform
   def test_no_extra_output(self):
+    # Run this build command first to warm the cache (since caching can produce stdout).
     self.run_process([EMCC, '-c', test_file('hello_world.c')])
     output = self.run_process([EMCC, '-c', test_file('hello_world.c')], stdout=PIPE, stderr=STDOUT).stdout
     self.assertEqual(output, '')
 
+  @crossplatform
+  def test_shell_cmd_with_quotes(self):
+    # Run this build command first to warm the cache (since caching can produce stdout).
+    self.run_process([EMCC, '-c', test_file('hello_world.c')])
+
+    # Verify that "emcc" is found in the PATH correctly in shell scripts (shell=True).
+    # Specificaly when quotes are around the "emcc" command itself.
+    # See https://github.com/microsoft/terminal/issues/15212
+    file = test_file('hello_world.c')
+    emcc = os.path.splitext(EMCC)[0]
+    cmd = f'"{emcc}" -c "{file}"'
+    print('running cmd:', cmd)
+    proc = subprocess.run(cmd, capture_output=True, text=True, shell=True, check=True)
+    # Also verify the no extra output is produced (simillar to test_no_extra_output
+    # above).
+    self.assertEqual(proc.stdout, '')
+    self.assertEqual(proc.stderr, '')
+
+    # Same again but without only filename part of `emcc` command
+    old_path = os.environ['PATH']
+    new_path = old_path + os.pathsep + os.path.dirname(EMCC)
+    cmd = f'"emcc" -c "{file}"'
+    print('running cmd:', cmd)
+    with env_modify({'PATH': new_path}):
+      proc = subprocess.run(cmd, capture_output=True, text=True, shell=True, check=True)
+      # There is currently a bug in the windows .bar files that leads to stdout
+      # not being empty in this case.
+      # See https://github.com/emscripten-core/emscripten/pull/25416
+      if not WINDOWS:
+        self.assertEqual(proc.stdout, '')
+      self.assertEqual(proc.stderr, '')
+
   def test_browser_too_old(self):
     err = self.expect_fail([EMCC, test_file('hello_world.c'), '-sMIN_CHROME_VERSION=10'])
     self.assertContained('emcc: error: MIN_CHROME_VERSION older than 74 is not supported', err)