Skip to content

Commit 0962b6c

Browse files
authored
Use getSocketAddress helper in __syscall_sendmsg. NFC (#22661)
The code here was replicating what `getSocketAddress` was doing.
1 parent ea27be2 commit 0962b6c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/library_syscall.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ var SyscallsLibrary = {
441441
}
442442
return -{{{ cDefs.ENOPROTOOPT }}}; // The option is unknown at the level indicated.
443443
},
444-
__syscall_sendmsg__deps: ['$getSocketFromFD', '$readSockaddr', '$DNS'],
444+
__syscall_sendmsg__deps: ['$getSocketFromFD', '$getSocketAddress', '$DNS'],
445445
__syscall_sendmsg: (fd, message, flags, d1, d2, d3) => {
446446
var sock = getSocketFromFD(fd);
447447
var iov = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_iov, '*') }}};
@@ -451,10 +451,9 @@ var SyscallsLibrary = {
451451
var name = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_name, '*') }}};
452452
var namelen = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_namelen, 'i32') }}};
453453
if (name) {
454-
var info = readSockaddr(name, namelen);
455-
if (info.errno) return -info.errno;
454+
var info = getSocketAddress(name, namelen);
456455
port = info.port;
457-
addr = DNS.lookup_addr(info.addr) || info.addr;
456+
addr = info.addr;
458457
}
459458
// concatenate scatter-gather arrays into one message buffer
460459
var total = 0;

0 commit comments

Comments
 (0)