Skip to content

Commit 0bd6747

Browse files
authored
Actually do metadce in at least one variant of test_metadce_cxx. NFC (#22429)
With `-O2` we were not actually running metadce.
1 parent 7f8a05d commit 0bd6747

7 files changed

+33
-44
lines changed
Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
1-
__cxa_increment_exception_refcount
2-
__indirect_function_table
3-
__wasm_call_ctors
4-
_emscripten_stack_alloc
5-
_emscripten_stack_restore
6-
_emscripten_timeout
7-
dynCall_iiiiiijj
8-
dynCall_iiiiij
9-
dynCall_iiiiijj
10-
dynCall_jiji
11-
dynCall_viijii
12-
emscripten_stack_get_current
13-
main
14-
memory
1+
m (memory)
2+
n (__wasm_call_ctors)
3+
o (main)
4+
p (_emscripten_timeout)
5+
q (__indirect_function_table)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8661
1+
8423
Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
env._abort_js
2-
env._emscripten_memcpy_js
3-
env._emscripten_runtime_keepalive_clear
4-
env._setitimer_js
5-
env._tzset_js
6-
env.emscripten_resize_heap
7-
wasi_snapshot_preview1.environ_get
8-
wasi_snapshot_preview1.environ_sizes_get
9-
wasi_snapshot_preview1.fd_close
10-
wasi_snapshot_preview1.fd_read
11-
wasi_snapshot_preview1.fd_seek
12-
wasi_snapshot_preview1.fd_write
13-
wasi_snapshot_preview1.proc_exit
1+
a (fd_seek)
2+
b (emscripten_resize_heap)
3+
c (_tzset_js)
4+
d (_setitimer_js)
5+
e (_emscripten_runtime_keepalive_clear)
6+
f (_abort_js)
7+
g (proc_exit)
8+
h (fd_write)
9+
i (fd_read)
10+
j (fd_close)
11+
k (environ_sizes_get)
12+
l (environ_get)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
21141
1+
20434
Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
_abort_js
2-
_emscripten_memcpy_js
3-
_emscripten_runtime_keepalive_clear
4-
_setitimer_js
5-
_tzset_js
6-
emscripten_resize_heap
7-
environ_get
8-
environ_sizes_get
9-
fd_close
10-
fd_read
11-
fd_seek
12-
fd_write
13-
proc_exit
1+
a (fd_seek)
2+
b (emscripten_resize_heap)
3+
c (_tzset_js)
4+
d (_setitimer_js)
5+
e (_emscripten_runtime_keepalive_clear)
6+
f (_abort_js)
7+
g (proc_exit)
8+
h (fd_write)
9+
i (fd_read)
10+
j (fd_close)
11+
k (environ_sizes_get)
12+
l (environ_get)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
129045
1+
122726

test/test_other.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8689,7 +8689,7 @@ def test_metadce_minimal_pthreads(self):
86898689
'ctors1': (['-O2', '-sEVAL_CTORS'], [], ['waka']),
86908690
'ctors2': (['-O2', '-sEVAL_CTORS=2'], [], ['waka']),
86918691
'wasmfs': (['-O2', '-sWASMFS'], [], ['waka']),
8692-
'lto': (['-O2', '-flto'], [], ['waka']),
8692+
'lto': (['-Oz', '-flto'], [], ['waka']),
86938693
})
86948694
def test_metadce_cxx(self, *args):
86958695
# do not check functions in this test as there are a lot of libc++ functions

0 commit comments

Comments
 (0)