Skip to content

Commit 0fbf9cf

Browse files
authored
test: Remove extra try/catch in force_delete_dir (#17900)
Ths issue this was trying to work around should have been fixed in #17544.
1 parent 0ca0db4 commit 0fbf9cf

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

test/common.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -327,16 +327,7 @@ def make_writable(path):
327327

328328
def force_delete_dir(dirname):
329329
make_dir_writeable(dirname)
330-
if WINDOWS:
331-
# We have seen issues where windows was unable to cleanup the test directory
332-
# See: https://github.com/emscripten-core/emscripten/pull/17512
333-
# TODO: Remove this try/catch.
334-
try:
335-
utils.delete_dir(dirname)
336-
except IOError as e:
337-
logger.warning(f'failed to remove directory: {dirname} ({e})')
338-
else:
339-
utils.delete_dir(dirname)
330+
utils.delete_dir(dirname)
340331

341332

342333
def parameterized(parameters):

0 commit comments

Comments
 (0)