Unify Node detection code (#24354)

This was duplicated in quite a few places and slightly different in some
places.

This change reduces that size of the code a little and reduces the
number of places we specify it to just two.

This change also fixes the `instance.test_environment` test which was
failing due to broken nodejs detection in shell.js (it was checking for
`require` which doesn't exist in ES module mode).

Split out from #24344

Author: sbc100

.circleci/config.yml

@@ -652,6 +652,7 @@ jobs:
             wasmfs.test_freetype
             minimal0.test_utf
             instance.test_async_hello_v8
+            instance.test_environment
             "
   test-wasm2js1:
     environment:

src/parseTools.mjs

@@ -1093,6 +1093,10 @@ function ENVIRONMENT_IS_WORKER_THREAD() {
   return '(' + envs.join('||') + ')';
 }
 
+function nodeDetectionCode() {
+  return "typeof process == 'object' && process.versions?.node && process.type != 'renderer'";
+}
+
 addToCompileTimeContext({
   ATEXITS,
   ATPRERUNS,
@@ -1153,6 +1157,7 @@ addToCompileTimeContext({
   makeSetValue,
   makeThrow,
   modifyJSFunction,
+  nodeDetectionCode,
   receiveI64ParamAsI53,
   receiveI64ParamAsI53Unchecked,
   receivedSymbol,

src/proxyClient.js

@@ -16,7 +16,7 @@
 #endif
 
 #if ENVIRONMENT_MAY_BE_NODE
-var ENVIRONMENT_IS_NODE = typeof process == 'object' && typeof process.versions == 'object' && typeof process.versions.node == 'string' && process.type != 'renderer';
+var ENVIRONMENT_IS_NODE = {{{ nodeDetectionCode() }}};
 if (ENVIRONMENT_IS_NODE) {
   var NodeWorker = require('worker_threads').Worker;
   global.Worker = function(url, options) {

src/shell.js

@@ -84,7 +84,7 @@ var ENVIRONMENT_IS_WEB = typeof window == 'object';
 var ENVIRONMENT_IS_WORKER = typeof WorkerGlobalScope != 'undefined';
 // N.b. Electron.js environment is simultaneously a NODE-environment, but
 // also a web environment.
-var ENVIRONMENT_IS_NODE = typeof process == 'object' && typeof process.versions == 'object' && typeof process.versions.node == 'string' && process.type != 'renderer';
+var ENVIRONMENT_IS_NODE = {{{ nodeDetectionCode() }}};
 #if AUDIO_WORKLET
 var ENVIRONMENT_IS_SHELL = !ENVIRONMENT_IS_WEB && !ENVIRONMENT_IS_NODE && !ENVIRONMENT_IS_WORKER && !ENVIRONMENT_IS_AUDIO_WORKLET;
 #else
@@ -193,7 +193,8 @@ var readAsync, readBinary;
 #if ENVIRONMENT_MAY_BE_NODE
 if (ENVIRONMENT_IS_NODE) {
 #if ENVIRONMENT && ASSERTIONS
-  if (typeof process == 'undefined' || !process.release || process.release.name !== 'node') throw new Error('not compiled for this environment (did you build to HTML and try to run it not on the web, or set ENVIRONMENT to something - like node - and run it someplace else - like on the web?)');
+  const isNode = {{{ nodeDetectionCode() }}};
+  if (!isNode) throw new Error('not compiled for this environment (did you build to HTML and try to run it not on the web, or set ENVIRONMENT to something - like node - and run it someplace else - like on the web?)');
 #endif
 
 #if ASSERTIONS
@@ -276,7 +277,8 @@ if (ENVIRONMENT_IS_NODE) {
 if (ENVIRONMENT_IS_SHELL) {
 
 #if ENVIRONMENT && ASSERTIONS
-  if ((typeof process == 'object' && typeof require === 'function') || typeof window == 'object' || typeof WorkerGlobalScope != 'undefined') throw new Error('not compiled for this environment (did you build to HTML and try to run it not on the web, or set ENVIRONMENT to something - like node - and run it someplace else - like on the web?)');
+  const isNode = {{{ nodeDetectionCode() }}};
+  if (isNode || typeof window == 'object' || typeof WorkerGlobalScope != 'undefined') throw new Error('not compiled for this environment (did you build to HTML and try to run it not on the web, or set ENVIRONMENT to something - like node - and run it someplace else - like on the web?)');
 #endif
 
 #if ENVIRONMENT_MAY_BE_SHELL

src/shell_minimal.js

@@ -44,7 +44,7 @@ var readyPromise = new Promise((resolve, reject) => {
 #endif
 
 #if ENVIRONMENT_MAY_BE_NODE
-var ENVIRONMENT_IS_NODE = typeof process == 'object' && process.type != 'renderer';
+var ENVIRONMENT_IS_NODE = {{{ nodeDetectionCode() }}};
 #endif
 
 #if ENVIRONMENT_MAY_BE_SHELL

test/core/test_esm_integration.expected.mjs

@@ -6,7 +6,7 @@ export { default, _foo, _main, err, stringToNewUTF8 } from './hello_world.suppor
 // When run as the main module under node, create the module directly.  This will
 // execute any startup code along with main (if it exists).
 import init from './hello_world.support.mjs';
-const isNode = typeof process == 'object' && typeof process.versions == 'object' && typeof process.versions.node == 'string' && process.type != 'renderer';
+const isNode = globalThis.process?.versions?.node && globalThis.process?.type != 'renderer';
 if (isNode) {
   const url = await import('url');
   const isMainModule = url.pathToFileURL(process.argv[1]).href === import.meta.url;

test/other/codesize/test_codesize_cxx_ctors1.gzsize

@@ -1 +1 @@
-8208
+8202

test/other/codesize/test_codesize_cxx_ctors1.jssize

@@ -1 +1 @@
-19920
+19869

test/other/codesize/test_codesize_cxx_ctors2.gzsize

@@ -1 +1 @@
-8196
+8191

test/other/codesize/test_codesize_cxx_ctors2.jssize

@@ -1 +1 @@
-19898
+19847