Skip to content

Commit 13b11be

Browse files
committed
Review comments.
1 parent b30944b commit 13b11be

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

ChangeLog.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ See docs/process.md for more on how version tagging works.
2222
-----------------------
2323
- The freetype port was updated from v2.6 to v2.13.3. (#22585)
2424
- The number of arguments passed to Embind function calls is now only verified
25-
with ASSERTIONS enabled.
26-
- Optional arguments can now be omitted from Embind function calls.
25+
with ASSERTIONS enabled. (#22591)
26+
- Optional arguments can now be omitted from Embind function calls. (#22591)
2727

2828
3.1.67 - 09/17/24
2929
-----------------

src/embind/embind.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@ var LibraryEmbind = {
5858
// emval is passed into JS via an interface
5959
}`,
6060
$EmValOptionalType__deps: ['$EmValType'],
61-
$EmValOptionalType: undefined,
62-
$EmValOptionalType__postset: 'EmValOptionalType = Object.assign({optional: true}, EmValType);',
61+
$EmValOptionalType: '=Object.assign({optional: true}, EmValType);',
6362
$init_embind__deps: [
6463
'$getInheritedInstanceCount', '$getLiveInheritedInstances',
6564
'$flushPendingDeletes', '$setDelayFunction'],
@@ -783,8 +782,8 @@ var LibraryEmbind = {
783782
'$Asyncify',
784783
#endif
785784
#if ASSERTIONS
786-
'$getRequiredArgCount',
787-
'$checkArgCount',
785+
'$getRequiredArgCount',
786+
'$checkArgCount',
788787
#endif
789788
],
790789
$craftInvokerFunction: function(humanName, argTypes, classType, cppInvokerFunc, cppTargetFunc, /** boolean= */ isAsync) {

0 commit comments

Comments
 (0)