Skip to content

Commit 19d1d53

Browse files
committed
address @sbc100 review
1 parent fb0be1e commit 19d1d53

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tools/file_packager.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,6 @@ def generate_js(data_target, data_files, metadata):
638638
ret += '''
639639
function handleError(error) {
640640
console.error('package error:', error);
641-
return error;
642641
};
643642
644643
function loadPackage(metadata) {\n'''
@@ -1119,7 +1118,7 @@ def generate_js(data_target, data_files, metadata):
11191118
if (isNode) {
11201119
require('fs').readFile(metadataUrl, 'utf8', (err, contents) => {
11211120
if (err) {
1122-
return handleError(err);
1121+
handleError(err);
11231122
} else {
11241123
loadPackage(JSON.parse(contents));
11251124
}
@@ -1140,8 +1139,8 @@ def generate_js(data_target, data_files, metadata):
11401139
if (response.ok) {
11411140
return response.json();
11421141
}
1143-
return handleError(new Error(`${response.status}: ${response.url}`));
11441142
})
1143+
.catch((cause) => handleError(new Error(`Network Error: ${packageName}`, {cause}))) // If fetch fails, rewrite the error to include the failing URL & the cause.
11451144
.then(loadPackage);
11461145
}
11471146

0 commit comments

Comments
 (0)