Skip to content

Commit 1a64817

Browse files
authored
Fix Firefox 91 ESR and Firefox 102 ESR test runs (#25835)
#25823 added a new ES6 Worker test. Gate it behind feature check to fix Firefox 91 ESR and Firefox 102 ESR test runs.
1 parent 82a607f commit 1a64817

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/test_browser.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5671,9 +5671,11 @@ def test_rollup(self):
56715671
'es6': (['-sEXPORT_ES6', '--extern-post-js', test_file('modularize_post_js.js')], 9999),
56725672
})
56735673
def test_cross_origin(self, args, port):
5674-
# Verfies that the emscripten-generted JS and Wasm can be hosted on a different origin.
5675-
# This test create a second HTTP server running a different port that servers files from `subdir`.
5676-
# The main html is the servers from the normal 8888 server while the JS and Wasm are hosted
5674+
if '-sEXPORT_ES6' in args and browser_should_skip_feature('EMTEST_LACKS_ES6_WORKERS', Feature.WORKER_ES6_MODULES):
5675+
self.skipTest('This test requires a browser with ES6 Module Workers support')
5676+
# Verifies that the emscripten-generated JS and Wasm can be hosted on a different origin.
5677+
# This test creates a second HTTP server running on a different port that serves files from `subdir`.
5678+
# The main html is served from the normal port 8888 server while the JS and Wasm are hosted
56775679
# on the port specified above.
56785680
os.mkdir('subdir')
56795681
create_file('subdir/foo.txt', 'hello')

0 commit comments

Comments
 (0)