Skip to content

Commit 1b6121d

Browse files
authored
[wasm64] Remove table64 lowering by default (#23051)
The engines that support memory64 now all also support table64.
1 parent c47a0f8 commit 1b6121d

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

tools/link.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2003,11 +2003,10 @@ def run_embind_gen(wasm_target, js_syms, extra_settings, linker_inputs):
20032003
# Build the flags needed by Node.js to properly run the output file.
20042004
node_args = []
20052005
if settings.MEMORY64:
2006-
node_args += shared.node_memory64_flags()
2007-
# Currently we don't have any engines that support table64 so we need
2008-
# to lower it in order to run the output.
2009-
# In the normal flow this happens later in `phase_binaryen`
2010-
building.run_wasm_opt(outfile_wasm, outfile_wasm, ['--table64-lowering'])
2006+
# The final version of memory64 proposal is not yet implement in any
2007+
# shipping version of node, so we need to lower it away in order to
2008+
# execute the binary at built time.
2009+
building.run_wasm_opt(outfile_wasm, outfile_wasm, ['--memory64-lowering', '--table64-lowering'])
20112010
if settings.WASM_EXCEPTIONS:
20122011
node_args += shared.node_exception_flags(config.NODE_JS)
20132012
# Run the generated JS file with the proper flags to generate the TypeScript bindings.

0 commit comments

Comments
 (0)