Add omitexports0 test suite (#25124)

Add omitexports0 test suite to test -sDECLARE_ASM_MODULE_EXPORTS=0
option, and fix the test suite to pass in that mode.

Author: juj

src/lib/libcore.js

@@ -1615,7 +1615,11 @@ addToLibrary({
 #if !DECLARE_ASM_MODULE_EXPORTS
   // When DECLARE_ASM_MODULE_EXPORTS is not set we export native symbols
   // at runtime rather than statically in JS code.
-  $exportWasmSymbols__deps: ['$asmjsMangle'],
+  $exportWasmSymbols__deps: ['$asmjsMangle'
+#if DYNCALLS || !WASM_BIGINT
+    , '$dynCalls'
+#endif
+  ],
   $exportWasmSymbols: (wasmExports) => {
 #if ENVIRONMENT_MAY_BE_NODE && ENVIRONMENT_MAY_BE_WEB
     var global_object = (typeof process != "undefined" ? global : this);
@@ -1627,6 +1631,11 @@ addToLibrary({
 
     for (var __exportedFunc in wasmExports) {
       var jsname = asmjsMangle(__exportedFunc);
+#if DYNCALLS || !WASM_BIGINT
+      if (jsname.startsWith('dynCall_')) {
+        dynCalls[jsname.substr(8)] = wasmExports[__exportedFunc];
+      }
+#endif
 #if MINIMAL_RUNTIME
       global_object[jsname] = wasmExports[__exportedFunc];
 #else

test/common.py

@@ -765,6 +765,8 @@ def also_with_modularize(f):
   @wraps(f)
   def metafunc(self, modularize, *args, **kwargs):
     if modularize:
+      if self.get_setting('DECLARE_ASM_MODULE_EXPORTS') == 0:
+        self.skipTest('DECLARE_ASM_MODULE_EXPORTS=0 is not compatible with MODULARIZE')
       if self.get_setting('STRICT_JS'):
         self.skipTest('MODULARIZE is not compatible with STRICT_JS')
       if self.get_setting('WASM_ESM_INTEGRATION'):

test/test_core.py

@@ -356,7 +356,14 @@ def decorator(f):
 
       @wraps(f)
       def decorated(self, *args, **kwargs):
-        if (name + '=1') in self.cflags or self.get_setting(name):
+        if '=' in name:
+          key, val = name.split('=', 1)
+        else:
+          key = name
+          val = 1
+        if int(val) == 1 and f'-s{key}' in self.cflags:
+          self.skipTest(note)
+        if f'-s{key}={val}' in self.cflags or self.get_setting(key) == int(val):
           self.skipTest(note)
         f(self, *args, **kwargs)
       return decorated
@@ -382,6 +389,7 @@ def decorated(self, textdecoder, *args, **kwargs):
 no_strict = make_no_decorator_for_setting('STRICT')
 no_strict_js = make_no_decorator_for_setting('STRICT_JS')
 no_big_endian = make_no_decorator_for_setting('SUPPORT_BIG_ENDIAN')
+no_omit_asm_module_exports = make_no_decorator_for_setting('DECLARE_ASM_MODULE_EXPORTS=0')
 
 
 def is_sanitizing(args):
@@ -6355,6 +6363,7 @@ def test_jslib(self):
   @crossplatform
   @no_modularize_instance('uses MODULARIZE')
   @no_strict_js('MODULARIZE is not compatible with STRICT_JS')
+  @no_omit_asm_module_exports('MODULARIZE is not compatible with DECLARE_ASM_MODULE_EXPORTS=0')
   def test_unicode_js_library(self):
     # First verify that we have correct overridden the default python file encoding.
     # The follow program should fail, assuming the above LC_CTYPE + PYTHONUTF8
@@ -7315,7 +7324,6 @@ def test_large_exported_response(self):
 
     self.set_setting('EXPORTED_FUNCTIONS', '@large_exported_response.json')
     self.do_run(src, 'waka 4999!')
-    self.assertContained('_exported_func_from_response_file_1', read_file('src.js'))
 
   def test_emulate_function_pointer_casts(self):
     # Forcibly disable EXIT_RUNTIME due to:
@@ -8064,6 +8072,7 @@ def get_wat_addr(call_index):
       self.assertLessEqual(start_wat_addr, dwarf_addr)
       self.assertLessEqual(dwarf_addr, end_wat_addr)
 
+  @no_omit_asm_module_exports('MODULARIZE is not compatible with DECLARE_ASM_MODULE_EXPORTS=0')
   @no_modularize_instance('uses -sMODULARIZE')
   @no_strict_js('MODULARIZE is not compatible with STRICT_JS')
   def test_modularize_closure_pre(self):
@@ -8631,7 +8640,7 @@ def test_memprof_requirements(self):
           if (typeof _emscripten_stack_get_base === 'function' &&
               typeof _emscripten_stack_get_end === 'function' &&
               typeof _emscripten_stack_get_current === 'function' &&
-              typeof Module['___heap_base'] === 'number') {
+              Module['___heap_base'] > 0) {
              out('able to run memprof');
              return 0;
            } else {
@@ -9121,6 +9130,7 @@ def test_asan_api(self):
 
   @asan
   @no_strict_js('MODULARIZE is not compatible with STRICT_JS')
+  @no_omit_asm_module_exports('MODULARIZE is not compatible with DECLARE_ASM_MODULE_EXPORTS=0')
   def test_asan_modularized_with_closure(self):
     # the bug is that createModule() returns undefined, instead of the
     # proper Promise object.
@@ -9780,6 +9790,7 @@ def test_esm_integration(self):
     self.assertContained('hello, world! (3)', self.run_js('runner.mjs'))
     self.assertFileContents(test_file('core/test_esm_integration.expected.mjs'), read_file('hello_world.mjs'))
 
+  @no_omit_asm_module_exports('MODULARIZE is not compatible with DECLARE_ASM_MODULE_EXPORTS=0')
   @no_strict_js('MODULARIZE is not compatible with STRICT_JS')
   def test_modularize_instance_hello(self):
     self.do_core_test('test_hello_world.c', cflags=['-sMODULARIZE=instance', '-Wno-experimental'])
@@ -9788,6 +9799,7 @@ def test_modularize_instance_hello(self):
     '': ([],),
     'pthreads': (['-pthread'],),
   })
+  @no_omit_asm_module_exports('MODULARIZE is not compatible with DECLARE_ASM_MODULE_EXPORTS=0')
   @no_strict_js('MODULARIZE is not compatible with STRICT_JS')
   def test_modularize_instance(self, args):
     if args:
@@ -9822,6 +9834,7 @@ def test_modularize_instance(self, args):
 
     self.assertContained('main1\nmain2\nfoo\nbar\nbaz\n', self.run_js('runner.mjs'))
 
+  @no_omit_asm_module_exports('MODULARIZE is not compatible with DECLARE_ASM_MODULE_EXPORTS=0')
   @no_4gb('EMBIND_AOT can\'t lower 4gb')
   @no_strict_js('MODULARIZE is not compatible with STRICT_JS')
   def test_modularize_instance_embind(self):
@@ -10037,5 +10050,7 @@ def setUp(self):
 # runs all unit tests via qemu on the s390x big endian version of Node.js.
 bigendian0 = make_run('bigendian0', cflags=['-O0', '-Wno-experimental'], settings={'SUPPORT_BIG_ENDIAN': 1})
 
+omitexports0 = make_run('omitexports0', cflags=['-O0'], settings={'DECLARE_ASM_MODULE_EXPORTS': 0})
+
 # TestCoreBase is just a shape for the specific subclasses, we don't test it itself
 del TestCoreBase # noqa