Skip to content

Commit 1fbcff0

Browse files
authored
Fix poppler benchmark. (#22616)
std::basic_string<unsigned short> will no longer work with LLVM 19.
1 parent 10a67f2 commit 1fbcff0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

test/third_party/poppler/cpp/poppler-global.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ typedef unsigned int /* time_t */ time_type;
7979
#pragma warning(push)
8080
#pragma warning(disable: 4251) /* class 'A' needs to have dll interface for to be used by clients of class 'B'. */
8181
#endif
82-
class POPPLER_CPP_EXPORT ustring : public std::basic_string<unsigned short>
82+
class POPPLER_CPP_EXPORT ustring : public std::basic_string<char16_t>
8383
{
8484
public:
8585
ustring();

test/third_party/poppler/readme.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ This is Poppler. See README and COPYING.
22

33
Changes for Emscripten:
44
Object.h, Array.cc, Dict.cc are modified to avoid uninitialization errors (search for 'Emscripten')
5-
5+
poppler-global.h is modified to use std::basic_string<char16_t> to compile with newer versions of
6+
LLVM (this matches newer upstream versions of poppler)

0 commit comments

Comments
 (0)