Skip to content

Commit 2162d17

Browse files
committed
Bump minimum supported chrome version from 32 to 33
This allows us to remove the promise polyfill.
1 parent 1a6c21e commit 2162d17

File tree

7 files changed

+4
-308
lines changed

7 files changed

+4
-308
lines changed

ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ See docs/process.md for more on how version tagging works.
2020

2121
3.1.74 (in development)
2222
-----------------------
23+
- The minimum supported chrome version was bumpd from 32 to 33. (#23077)
2324

2425
3.1.73 - 11/28/24
2526
-----------------

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2939,7 +2939,7 @@ This setting also applies to modern Chromium-based Edge, which shares version
29392939
numbers with Chrome.
29402940
Chrome 85 was released on 2020-08-25.
29412941
MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
2942-
Minimum supported value is 32, which was released on 2014-01-04.
2942+
Minimum supported value is 33, which was released on 2014-02-18.
29432943

29442944
Default value: 85
29452945

src/polyfill/promise.js

Lines changed: 0 additions & 274 deletions
This file was deleted.

src/settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1919,7 +1919,7 @@ var MIN_SAFARI_VERSION = 140100;
19191919
// numbers with Chrome.
19201920
// Chrome 85 was released on 2020-08-25.
19211921
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
1922-
// Minimum supported value is 32, which was released on 2014-01-04.
1922+
// Minimum supported value is 33, which was released on 2014-02-18.
19231923
// [link]
19241924
var MIN_CHROME_VERSION = 85;
19251925

src/shell.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,6 @@ var Module = typeof {{{ EXPORT_NAME }}} != 'undefined' ? {{{ EXPORT_NAME }}} : {
3434
#endif // USE_CLOSURE_COMPILER
3535

3636
#if POLYFILL
37-
#if ((MAYBE_WASM2JS && WASM != 2) || MODULARIZE) && (MIN_CHROME_VERSION < 33 || MIN_FIREFOX_VERSION < 29 || MIN_SAFARI_VERSION < 80000)
38-
// Include a Promise polyfill for legacy browsers. This is needed either for
39-
// wasm2js, where we polyfill the wasm API which needs Promises, or when using
40-
// modularize which creates a Promise for when the module is ready.
41-
// See https://caniuse.com/#feat=promises
42-
#include "polyfill/promise.js"
43-
#endif
44-
4537
#if MIN_CHROME_VERSION < 45 || MIN_FIREFOX_VERSION < 34 || MIN_SAFARI_VERSION < 90000
4638
// See https://caniuse.com/mdn-javascript_builtins_object_assign
4739
#include "polyfill/objassign.js"

test/test_other.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -12426,29 +12426,6 @@ def test_standalone_syscalls(self):
1242612426
for engine in config.WASM_ENGINES:
1242712427
self.assertContained(expected, self.run_js('test.wasm', engine))
1242812428

12429-
@parameterized({
12430-
'wasm2js': (['-sWASM=0'],),
12431-
'modularize': (['-sMODULARIZE', '--extern-post-js', test_file('modularize_post_js.js')],),
12432-
})
12433-
def test_promise_polyfill(self, constant_args):
12434-
def test(args, expect_fail):
12435-
# legacy browsers may lack Promise, which wasm2js depends on. see what
12436-
# happens when we kill the global Promise function.
12437-
self.run_process([EMCC, test_file('hello_world.c')] + constant_args + args)
12438-
js = read_file('a.out.js')
12439-
create_file('a.out.js', 'Promise = undefined;\n' + js)
12440-
return self.run_js('a.out.js', assert_returncode=NON_ZERO if expect_fail else 0)
12441-
12442-
# we fail without legacy support
12443-
test([], expect_fail=True)
12444-
12445-
# but work with it
12446-
output = test(['-sLEGACY_VM_SUPPORT'], expect_fail=False)
12447-
self.assertContained('hello, world!', output)
12448-
12449-
# unless we explicitly disable polyfills
12450-
test(['-sLEGACY_VM_SUPPORT', '-sNO_POLYFILL'], expect_fail=True)
12451-
1245212429
@parameterized({
1245312430
'': ([],),
1245412431
'assertions': (['-sASSERTIONS'],),

tools/feature_matrix.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# Oldest support browser versions. These have been set somewhat
1919
# arbitrarily for now.
2020
# TODO(sbc): Design a of policy for managing these values.
21-
OLDEST_SUPPORTED_CHROME = 32
21+
OLDEST_SUPPORTED_CHROME = 33
2222
OLDEST_SUPPORTED_FIREFOX = 34
2323
OLDEST_SUPPORTED_SAFARI = 90000
2424
# 10.19.0 is the oldest version of node that we do any testing with.

0 commit comments

Comments
 (0)