Skip to content

Commit 22758b8

Browse files
authored
Fix test_embind_tsgen_memory64_pthread (#26017)
I noticed this test was failing locally. This test was being skipped in CI because the `other` runner skips all wasm64 tests and the the `wasm64` runner it only runs `other.*_wasm64` tests. The `_emscripten_thread_mailbox_await` function unconditionally depends on `waitAsyncPolyfilled` to the symbol needs to at least always exist.
1 parent dfa6966 commit 22758b8

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

src/lib/libatomic.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ addToLibrary({
6262
return { async: true, value: promise };
6363
};
6464
}`,
65+
#else
66+
$waitAsyncPolyfilled: false,
6567
#endif
6668

6769
$polyfillWaitAsync__internal: true,

test/test_other.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3663,13 +3663,13 @@ def test_embind_tsgen_bigint(self):
36633663
'pthread': [['-pthread']],
36643664
})
36653665
@requires_wasm64
3666-
def test_embind_tsgen_memory64(self, args):
3667-
# Check that when memory64 is enabled longs & unsigned longs are mapped to bigint in the generated TS bindings
3668-
self.run_process([EMXX, test_file('other/embind_tsgen_memory64.cpp'),
3669-
'-lembind', '--emit-tsd', 'embind_tsgen_memory64.d.ts', '-sMEMORY64'] +
3666+
def test_embind_tsgen_wasm64(self, args):
3667+
# Check that when wasm64 is enabled longs & unsigned longs are mapped to bigint in the generated TS bindings
3668+
self.run_process([EMXX, test_file('other/embind_tsgen_wasm64.cpp'),
3669+
'-lembind', '--emit-tsd', 'embind_tsgen_wasm64.d.ts', '-sMEMORY64'] +
36703670
args +
36713671
self.get_cflags())
3672-
self.assertFileContents(test_file('other/embind_tsgen_memory64.d.ts'), read_file('embind_tsgen_memory64.d.ts'))
3672+
self.assertFileContents(test_file('other/embind_tsgen_wasm64.d.ts'), read_file('embind_tsgen_wasm64.d.ts'))
36733673

36743674
@requires_jspi
36753675
def test_embind_tsgen_jspi(self):

0 commit comments

Comments
 (0)