Skip to content

Commit 27a0573

Browse files
committed
Followed same review comments from #23695
1 parent 6fc8fbe commit 27a0573

6 files changed

+8
-29
lines changed

test/webaudio/audioworklet_2x_in_hard_pan.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,7 @@ bool process(int numInputs, const AudioSampleFrame* inputs, int numOutputs, Audi
4747

4848
// Audio processor created, now register the audio callback
4949
void processorCreated(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unused data) {
50-
if (!success) {
51-
assert("Audio worklet failed in processorCreated()" && success);
52-
return;
53-
}
50+
assert(success && "Audio worklet failed in processorCreated()");
5451
emscripten_out("Audio worklet processor created");
5552
emscripten_out("Click to toggle audio playback");
5653

test/webaudio/audioworklet_2x_in_out_stereo.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,7 @@ bool process(int numInputs, const AudioSampleFrame* inputs, int numOutputs, Audi
4646

4747
// Audio processor created, now register the audio callback
4848
void processorCreated(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unused data) {
49-
if (!success) {
50-
assert("Audio worklet failed in processorCreated()" && success);
51-
return;
52-
}
49+
assert(success && "Audio worklet failed in processorCreated()");
5350
emscripten_out("Audio worklet processor created");
5451
emscripten_out("Click to toggle audio playback");
5552

test/webaudio/audioworklet_in_out_mono.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,7 @@ bool process(int numInputs, const AudioSampleFrame* inputs, int numOutputs, Audi
5454

5555
// Audio processor created, now register the audio callback
5656
void processorCreated(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unused data) {
57-
if (!success) {
58-
assert("Audio worklet failed in processorCreated()" && success);
59-
return;
60-
}
57+
assert(success && "Audio worklet failed in processorCreated()");
6158
emscripten_out("Audio worklet processor created");
6259
emscripten_out("Click to toggle audio playback");
6360

test/webaudio/audioworklet_in_out_stereo.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,7 @@ bool process(int numInputs, const AudioSampleFrame* inputs, int numOutputs, Audi
5454

5555
// Audio processor created, now register the audio callback
5656
void processorCreated(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unused data) {
57-
if (!success) {
58-
assert("Audio worklet failed in processorCreated()" && success);
59-
return;
60-
}
57+
assert(success && "Audio worklet failed in processorCreated()");
6158
emscripten_out("Audio worklet processor created");
6259
emscripten_out("Click to toggle audio playback");
6360

test/webaudio/audioworklet_params_mixing.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,7 @@ bool onPress(int __unused type, const EmscriptenKeyboardEvent* e, void* data) {
102102

103103
// Audio processor created, now register the audio callback
104104
void processorCreated(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unused data) {
105-
if (!success) {
106-
assert("Audio worklet failed in processorCreated()" && success);
107-
return;
108-
}
105+
assert(success && "Audio worklet failed in processorCreated()");
109106
emscripten_out("Audio worklet processor created");
110107
emscripten_out("Click to toggle audio playback");
111108
emscripten_out("Keypress to fade the beat in or out");
@@ -144,10 +141,7 @@ void processorCreated(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unuse
144141

145142
// Worklet thread inited, now create the audio processor
146143
void initialisedWithParams(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unused data) {
147-
if (!success) {
148-
assert("Audio worklet failed initialised()" && success);
149-
return;
150-
}
144+
assert(success && "Audio worklet failed initialised()");
151145
emscripten_out("Audio worklet initialised");
152146

153147
// Custom audio params we'll use as a fader

test/webaudio/audioworklet_test_shared.inc

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ bool playedAndMixed(double __unused time, void* __unused data) {
2525
#else
2626
if (audioProcessedCount >= 375) {
2727
#endif
28-
emscripten_force_exit(EXIT_SUCCESS);
28+
emscripten_force_exit(0);
2929
return false;
3030
}
3131
return true;
@@ -89,10 +89,7 @@ void processorCreated(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* data);
8989

9090
// Worklet thread inited, now create the audio processor
9191
void initialised(EMSCRIPTEN_WEBAUDIO_T context, bool success, void* __unused data) {
92-
if (!success) {
93-
assert("Audio worklet failed in initialised()" && success);
94-
return;
95-
}
92+
assert(success && "Audio worklet failed in initialised()");
9693
emscripten_out("Audio worklet initialised");
9794

9895
WebAudioWorkletProcessorCreateOptions opts = {

0 commit comments

Comments
 (0)