Skip to content

Commit 28022f6

Browse files
authored
Fix test_override_js_execution_environment under v8. NFC (#25109)
Tested with v8, node and spidermonkey all in JS_ENGINES.
1 parent ae9bfff commit 28022f6

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

test/test_other.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8949,15 +8949,10 @@ def test_override_js_execution_environment(self):
89498949
});
89508950
}
89518951
''')
8952-
# use SINGLE_FILE since we don't want to depend on loading a side .wasm file on the environment in this test;
8953-
# with the wrong env we have very odd failures
8954-
self.run_process([EMCC, 'main.c', '-sSINGLE_FILE'])
8952+
self.run_process([EMCC, 'main.c', '-sENVIRONMENT=node,shell'])
89558953
src = read_file('a.out.js')
8956-
envs = ['web', 'worker', 'node', 'shell']
8957-
for env in envs:
8954+
for env in ['web', 'worker', 'node', 'shell']:
89588955
for engine in config.JS_ENGINES:
8959-
if engine == config.V8_ENGINE:
8960-
continue # ban v8, weird failures
89618956
actual = 'NODE' if engine == config.NODE_JS_TEST else 'SHELL'
89628957
print(env, actual, engine)
89638958
module = {'ENVIRONMENT': env}

0 commit comments

Comments
 (0)