ports: Skip cleaning of build directory at start of each build. NFC (#17857)

`clear_project_build` is already called each time a new vesion of a
port is extracted.  There is no reason to also clear the build directory
during the `create` call.

This helps with #17809 and also simplifies the code in each port.

Author: sbc100

tools/ports/__init__.py

@@ -108,7 +108,8 @@ def install_headers(src_dir, pattern='*.h', target=None):
       shutil.copyfile(f, os.path.join(dest, os.path.basename(f)))
 
   @staticmethod
-  def build_port(src_dir, output_path, build_dir, includes=[], flags=[], exclude_files=[], exclude_dirs=[], srcs=[]):  # noqa
+  def build_port(src_dir, output_path, port_name, includes=[], flags=[], exclude_files=[], exclude_dirs=[], srcs=[]):  # noqa
+    build_dir = os.path.join(Ports.get_build_dir(), port_name)
     if srcs:
       srcs = [os.path.join(src_dir, s) for s in srcs]
     else:

tools/ports/boost_headers.py

@@ -23,17 +23,17 @@ def create(final):
     logging.info('building port: boost_headers')
 
     # includes
-    source_path_include = os.path.join(ports.get_dir(), 'boost_headers', 'boost')
+    source_path = os.path.join(ports.get_dir(), 'boost_headers')
+    source_path_include = os.path.join(source_path, 'boost')
     ports.install_header_dir(source_path_include, 'boost')
 
     # write out a dummy cpp file, to create an empty library
     # this is needed as emscripted ports expect this, even if it is not used
-    build_dir = ports.clear_project_build('boost_headers')
-    dummy_file = os.path.join(build_dir, 'dummy.cpp')
+    dummy_file = os.path.join(source_path, 'dummy.cpp')
     shared.safe_ensure_dirs(os.path.dirname(dummy_file))
     Path(dummy_file).write_text('static void dummy() {}')
 
-    ports.build_port(build_dir, final, build_dir)
+    ports.build_port(source_path, final, 'boost_headers', srcs=['dummy.cpp'])
 
   return [shared.Cache.get_lib('libboost_headers.a', create, what='port')]
 

tools/ports/bullet.py

@@ -45,8 +45,7 @@ def create(final):
       '-std=gnu++14'
     ]
 
-    build_dir = ports.clear_project_build('bullet')
-    ports.build_port(src_path, final, build_dir, includes=includes, flags=flags, exclude_dirs=['MiniCL'])
+    ports.build_port(src_path, final, 'bullet', includes=includes, flags=flags, exclude_dirs=['MiniCL'])
 
   return [shared.Cache.get_lib('libbullet.a', create)]
 

tools/ports/bzip2.py

@@ -25,8 +25,7 @@ def create(final):
       'blocksort.c', 'compress.c', 'decompress.c', 'huffman.c',
       'randtable.c', 'bzlib.c', 'crctable.c',
     ]
-    build_dir = ports.clear_project_build('bzip2')
-    ports.build_port(source_path, final, build_dir, srcs=srcs)
+    ports.build_port(source_path, final, 'bzip2', srcs=srcs)
 
   return [shared.Cache.get_lib('libbz2.a', create, what='port')]
 

tools/ports/cocos2d.py

@@ -44,13 +44,12 @@ def create(final):
       '-sUSE_ZLIB=1',
       '-sUSE_LIBPNG=1',
     ]
-    build_dir = ports.clear_project_build('cocos2d')
 
     for dirname in includes:
       target = os.path.join('cocos2d', os.path.relpath(dirname, cocos2d_root))
       ports.install_header_dir(dirname, target=target)
 
-    ports.build_port(cocos2d_src, final, build_dir,
+    ports.build_port(cocos2d_src, final, 'cocos2d',
                      flags=flags,
                      includes=includes,
                      srcs=srcs)

tools/ports/freetype.py

@@ -91,8 +91,7 @@ def create(final):
       '-pthread'
     ]
 
-    build_dir = ports.clear_project_build('freetype')
-    ports.build_port(source_path, final, build_dir, flags=flags, srcs=srcs)
+    ports.build_port(source_path, final, 'freetype', flags=flags, srcs=srcs)
 
   return [shared.Cache.get_lib('libfreetype.a', create, what='port')]
 

tools/ports/giflib.py

@@ -21,8 +21,7 @@ def create(final):
     logging.info('building port: giflib')
     source_path = os.path.join(ports.get_dir(), 'giflib', f'giflib-{VERSION}')
     ports.install_headers(source_path)
-    build_dir = ports.clear_project_build('giflib')
-    ports.build_port(source_path, final, build_dir)
+    ports.build_port(source_path, final, 'giflib')
 
   return [shared.Cache.get_lib('libgif.a', create, what='port')]
 

tools/ports/harfbuzz.py

@@ -130,8 +130,7 @@ def create(final):
     else:
       cflags.append('-DHB_NO_MT')
 
-    build_dir = ports.clear_project_build('harfbuzz')
-    ports.build_port(os.path.join(source_path, 'src'), final, build_dir, flags=cflags, srcs=srcs)
+    ports.build_port(os.path.join(source_path, 'src'), final, 'harfbuzz', flags=cflags, srcs=srcs)
 
   return [shared.Cache.get_lib(get_lib_name(settings), create, what='port')]
 

tools/ports/icu.py

@@ -29,12 +29,10 @@ def get(ports, settings, shared):
   url = 'https://github.com/unicode-org/icu/releases/download/%s/icu4c-%s-src.zip' % (TAG, VERSION)
   ports.fetch_project('icu', url, 'icu', sha512hash=HASH)
   icu_source_path = None
-  build_dir = None
 
   def prepare_build():
-    nonlocal icu_source_path, build_dir
+    nonlocal icu_source_path
     source_path = os.path.join(ports.get_dir(), 'icu', 'icu') # downloaded icu4c path
-    build_dir = ports.clear_project_build('icu') # icu build path
     icu_source_path = os.path.join(source_path, 'source')
 
   def build_lib(lib_output, lib_src, other_includes, build_flags):
@@ -59,7 +57,7 @@ def build_lib(lib_output, lib_src, other_includes, build_flags):
     if settings.USE_PTHREADS:
       additional_build_flags.append('-pthread')
 
-    ports.build_port(lib_src, lib_output, build_dir, includes=other_includes, flags=build_flags + additional_build_flags)
+    ports.build_port(lib_src, lib_output, 'icu', includes=other_includes, flags=build_flags + additional_build_flags)
 
   # creator for libicu_common
   def create_libicu_common(lib_output):

tools/ports/libjpeg.py

@@ -31,8 +31,7 @@ def create(final):
       'jmemansi.c', 'jmemdos.c', 'jmemmac.c', 'jmemname.c',
       'jpegtran.c', 'rdjpgcom.c', 'wrjpgcom.c',
     ]
-    build_dir = ports.clear_project_build('libjpeg')
-    ports.build_port(source_path, final, build_dir, exclude_files=excludes)
+    ports.build_port(source_path, final, 'libjpeg', exclude_files=excludes)
 
   return [shared.Cache.get_lib('libjpeg.a', create, what='port')]