Skip to content

Commit 2f77367

Browse files
committed
rename promise handlers
1 parent 8900631 commit 2f77367

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

test/test_other.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3951,15 +3951,15 @@ def test_file_packager_embed(self):
39513951
self.assertContained('hello data', output)
39523952

39533953
def test_file_packager_export_es6(self):
3954-
create_file('data.txt', 'hello data')
3955-
self.run_process([FILE_PACKAGER, 'test.data', '--export-es6', '--preload', 'data.txt', '--js-output=dataFileLoader.js', '--no-node'])
3954+
create_file('smth.txt', 'hello data')
3955+
self.run_process([FILE_PACKAGER, 'test.data', '--export-es6', '--preload', 'smth.txt', '--js-output=dataFileLoader.js'])
39563956

39573957
create_file('test.c', '''
39583958
#include <stdio.h>
39593959
#include <emscripten.h>
39603960

39613961
EMSCRIPTEN_KEEPALIVE int test_fun() {
3962-
FILE* f = fopen("data.txt", "r");
3962+
FILE* f = fopen("smth.txt", "r");
39633963
char buf[64] = {0};
39643964
int rtn = fread(buf, 1, 64, f);
39653965
buf[rtn] = '\\0';

tools/file_packager.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -634,11 +634,7 @@ def generate_js(data_target, data_files, metadata):
634634
else:
635635
if options.export_es6:
636636
ret = '''export default function loadDataFile(Module) {
637-
var readyPromiseResolve, readyPromiseReject;
638-
var readyPromise = new Promise((resolve, reject) => {
639-
readyPromiseResolve = resolve;
640-
readyPromiseReject = reject;
641-
});'''
637+
return new Promise((loadDataResolve, loadDataReject) => {'''
642638

643639
else:
644640
ret = '''
@@ -710,7 +706,7 @@ def generate_js(data_target, data_files, metadata):
710706
Module['FS_createDataFile'](this.name, null, byteArray, true, true, true);
711707
Module['removeRunDependency'](`fp ${that.name}`);'''
712708
ready_promise = '''
713-
readyPromiseResolve();'''
709+
loadDataResolve();'''
714710

715711
if not options.lz4:
716712
# Data requests - for getting a block of data out of the big archive - have
@@ -987,7 +983,7 @@ def generate_js(data_target, data_files, metadata):
987983
}'''.strip()
988984

989985
reject_promise = '''
990-
readyPromiseReject();'''
986+
loadDataReject();'''
991987

992988
ret += '''
993989
function fetchRemotePackage(packageName, packageSize, callback, errback) {
@@ -1170,7 +1166,7 @@ def generate_js(data_target, data_files, metadata):
11701166

11711167
if options.export_es6:
11721168
ret += '''
1173-
return readyPromise;
1169+
});
11741170
}
11751171
// END the loadDataFile function
11761172
'''

0 commit comments

Comments
 (0)