Skip to content

Commit 3088726

Browse files
committed
fix doc, disable bigint with old node
1 parent 166dcc7 commit 3088726

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2186,10 +2186,9 @@ WASM_BIGINT
21862186

21872187
WebAssembly integration with JavaScript BigInt. When enabled we don't need to
21882188
legalize i64s into pairs of i32s, as the wasm VM will use a BigInt where an
2189-
i64 is used. If WASM_BIGINT is present, the default minimum supported browser
2190-
versions will be increased to the min version that supports BigInt.
2189+
i64 is used.
21912190

2192-
Default value: false
2191+
Default value: true
21932192

21942193
.. _emit_producers_section:
21952194

test/common.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
from tools.shared import get_canonical_temp_dir, path_from_root
3838
from tools.utils import MACOS, WINDOWS, read_file, read_binary, write_binary, exit_with_error
3939
from tools.settings import COMPILE_TIME_SETTINGS
40-
from tools import shared, line_endings, building, config, utils
40+
from tools import shared, feature_matrix, line_endings, building, config, utils
4141

4242
logger = logging.getLogger('common')
4343

@@ -1085,6 +1085,8 @@ def setUp(self):
10851085
if node_version < emcc_min_node_version:
10861086
self.emcc_args += building.get_emcc_node_flags(node_version)
10871087
self.emcc_args.append('-Wno-transpile')
1088+
if node_version < feature_matrix.min_browser_versions[feature_matrix.Feature.JS_BIGINT_INTEGRATION]
1089+
self.emcc_args.append('-sWASM_BIGINT=0')
10881090

10891091
self.v8_args = ['--wasm-staging']
10901092
self.env = {}

0 commit comments

Comments
 (0)